Jonathan Druart 6eade474ed Bug 18276: Remove GetBiblioFromItemNumber - Easy ones ... The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2017-07-10 12:22:29 -03:00
..
clubs	Bug 12461 - Add patron clubs feature	2017-04-28 08:37:44 -04:00
errors
external/overdrive	bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron	2017-02-21 19:58:20 +00:00
rss
sco	Bug 7550: SCO - Restrict access of patron's image	2017-05-08 09:00:26 -04:00
svc	Bug 14224: Use encode_json instead of to_json	2017-04-28 09:03:23 -04:00
ilsdi.pl	Bug 16476: Do not call CGI->param in list context, some more	2016-05-16 17:11:46 +00:00
maintenance.pl
oai.pl
opac-account-pay-paypal-return.pl	Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl	2017-01-12 13:42:47 +00:00
opac-account-pay.pl
opac-account.pl
opac-addbybiblionumber.pl	Bug 18228: Implement the new columns in code	2017-07-05 13:35:23 -03:00
opac-alert-subscribe.pl	Bug 10357: Do not change the alerttype	2017-04-21 10:58:33 -04:00
opac-article-request-cancel.pl	Bug 14610 - Add and update scripts	2016-10-26 12:15:14 +00:00
opac-authorities-home.pl	Bug 18204 - Authority searches are not saved in Search history	2017-05-28 22:12:01 -04:00
opac-authoritiesdetail.pl
opac-basket.pl	Bug 17642: Add and use get_descriptions_by_koha_field	2016-11-18 15:52:00 +00:00
opac-blocked.pl
opac-browser.pl	Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes	2017-07-05 13:42:21 -03:00
opac-changelanguage.pl	Bug 16776: Do not forget external language choice in language switcher	2016-08-10 13:51:33 +00:00
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl	Bug 10357: Do not change the alerttype	2017-04-21 10:58:33 -04:00
opac-discharge.pl	Bug 18432 : Follow up - Updating to use they/them	2017-04-21 10:56:43 -04:00
opac-downloadcart.pl	Bug 8612: [Follow-up] Make usage and type different columns in table	2017-06-05 12:02:08 -03:00
opac-downloadshelf.pl	Bug 8612: [Follow-up] Make usage and type different columns in table	2017-06-05 12:02:08 -03:00
opac-export.pl	Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls	2016-09-08 11:54:22 +00:00
opac-ics.pl	Bug 5456 - Create a link to opac-ics.pl	2016-09-02 15:55:32 +00:00
opac-idref.pl	Bug 16447: Remove occurrence of the borrow permission which does no longer exist	2016-05-05 21:28:14 +00:00
opac-image.pl
opac-imageviewer.pl
opac-ISBDdetail.pl	Bug 17835: Replace GetItemTypes with Koha::ItemTypes	2017-04-14 10:43:51 -04:00
opac-issue-note.pl	Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes	2017-04-28 09:03:22 -04:00
opac-main.pl	Bug 14764 - [followup] Addressing QA concerns	2017-03-03 18:27:52 +00:00
opac-MARCdetail.pl	Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls	2016-09-08 11:54:22 +00:00
opac-memberentry.pl	Bug 17762: Send lang to GetPreparedLetter	2017-05-09 20:56:41 +00:00
opac-messaging.pl	Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch	2016-09-08 14:36:04 +00:00
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl
opac-news-rss.pl	Bug 16447: Remove occurrence of the borrow permission which does no longer exist	2016-05-05 21:28:14 +00:00
opac-overdrive-search.pl	Bug 18632: Remove 'CGI::param called in list context' warnings	2017-05-28 22:25:22 -04:00
opac-passwd.pl
opac-password-recovery.pl	Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username	2017-07-06 14:52:53 -03:00
opac-patron-image.pl
opac-privacy.pl	Bug 18169: Make 'before' param non mandatory for Koha::Patrons->anonymise_issue_history	2017-03-03 18:16:54 +00:00
opac-ratings-ajax.pl	Bug 17089: Improve errors handling	2016-09-09 09:31:30 +00:00
opac-ratings.pl	Bug 17089: Improve errors handling	2016-09-09 09:31:30 +00:00
opac-readingrecord.pl	Bug 17835: Replace GetItemTypes with Koha::ItemTypes	2017-04-14 10:43:51 -04:00
opac-registration-verify.pl	Bug 17080: borrowers table - use default values defined in the DBIx::Class schema	2016-10-21 17:33:19 +00:00
opac-renew.pl	Bug 17578: GetMemberDetails - Remove GetMemberDetails	2016-12-16 13:12:44 +00:00
opac-request-article.pl	Bug 14610 - Add and update scripts	2016-10-26 12:15:14 +00:00
opac-reserve.pl	Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls	2017-07-10 12:06:37 -03:00
opac-restrictedpage.pl	Bug 16447: Remove occurrence of the borrow permission which does no longer exist	2016-05-05 21:28:14 +00:00
opac-retrieve-file.pl	Bug 17501: Move getCategories and httpheaders from Upload.pm	2017-01-20 14:20:05 +00:00
opac-review.pl	Bug 15839: [QA Follow-up] Error checking in opac-review.pl	2016-09-09 10:31:06 +00:00
opac-search-history.pl	BUG 18505: opac-search-history does not respect opacPublic	2017-05-08 10:16:20 -04:00
opac-search.pl	Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes	2017-07-05 13:42:21 -03:00
opac-sendbasket.pl	Bug 18124: Change the calls to generate and check CSRF tokens	2017-03-30 09:07:09 +00:00
opac-sendshelf.pl	Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects	2016-10-11 13:14:46 +00:00
opac-serial-issues.pl	Bug 10357: Do not change the alerttype	2017-04-21 10:58:33 -04:00
opac-shareshelf.pl	Bug 17762: Send lang to GetPreparedLetter	2017-05-09 20:56:41 +00:00
opac-shelves.pl	Bug 18276: Remove GetBiblioFromItemNumber - Easy ones	2017-07-10 12:22:29 -03:00
opac-showmarc.pl	Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls	2016-09-08 11:54:22 +00:00
opac-showreviews.pl	Bug 17578: GetMemberDetails - Remove GetMemberDetails	2016-12-16 13:12:44 +00:00
opac-suggestions.pl	Bug 17578: GetMemberDetails - Remove GetMemberDetails	2016-12-16 13:12:44 +00:00
opac-tags.pl	Bug 15263: (QA followup) Use the new XSLTParse4Display everywhere	2016-05-04 13:40:35 +00:00
opac-tags_subject.pl	Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes	2017-07-05 13:42:21 -03:00
opac-topissues.pl	Bug 17835: Replace GetItemTypes with Koha::ItemTypes	2017-04-14 10:43:51 -04:00
opac-user.pl	Bug 18179: Update existing calls	2017-06-05 11:35:58 -03:00
tracklinks.pl
unapi