Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
David Cook f4cf075fbe Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected behaviour 
When using the WYSIWYG editor for system preferences, the editor only
updates the textarea element if the content is different from the
original content. This means if you change a system preference and
then change it back to the original content, the textarea will have
the 2nd last change you made.

This patch removes the TinyMCE.isDirty() check, which was responsible
for comparing the original and changed content. Every input/keydown/dragend
or TinyMCE command will cause the textarea element to be updated and
trigger the input event which causes the "modified" class to be added
to the element, so that the system preference can be saved.

__TEST PLAN__

_Before applying_
0. Change "UseWYSIWYGinSystemPreferences" to "Show"
1. Change "opaccredits" to "123a"
2. Click "Save all OPAC preferences"
3. Reload the page
4. Change "opaccredits" to "123"
5. Change "opaccredits" to "123a"
6. Click "Save all OPAC preferences"
7. Reload the page
8. Note that "opaccredits" says "123"

_Apply the patch_

_After applying_
1. Change "opaccredits" to "123a"
2. Change "opaccredits" to "123"
3. Click "Save all OPAC preferences"
4. Reload the page
5. Note that "opaccredits" says "123" (and not "123a")
6. Change "opaccredits" to "1234"
7. Click "Save all OPAC preferences"
8. Reload the page
9. Note that "opaccredits" says "1234"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-09 11:11:22 +00:00
..
catalogue
csv_headers Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" 2018-02-08 14:52:01 -03:00
modals Bug 18327: Rename submit button with 'OK' 2018-04-19 16:37:21 -03:00
virtualshelves/merge
account_offset_type.inc Bug 20980: Add 'Manual Credit' and fix existing offsets 2018-07-06 12:50:05 +00:00
accounttype.inc Bug 20703: (RM follow-up) Remove the word 'Payment' from void 2018-07-06 11:13:49 +00:00
acquisitions-add-to-basket.inc
acquisitions-menu.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
acquisitions-search.inc
acquisitions-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
additem.js.inc
admin-items-search-field-form.inc
admin-menu.inc Bug 7651: (follow-up) Correct visibility on admin sidebar 2018-07-18 17:45:21 +00:00
adv-search.inc Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
auth-finder-search.inc Bug 19582: Use compat routines for searching authorities in auth_finder.pl 2018-03-27 17:50:37 -03:00
authorities-search-results.inc
authorities-search.inc Bug 19785: Move template JavaScript to the footer: Authorities, part 1 2018-02-18 16:48:44 -03:00
authorities-toolbar.inc Bug 19436: Add SRU support for authorities 2018-08-08 20:31:34 +00:00
authorities.inc
authorities_js.inc Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button 2018-07-02 11:29:20 +00:00
av-build-dropbox.inc
biblio-default-view.inc
biblio-view-menu.inc Bug 20918: Fix left-side navigation on the checkout history page 2018-06-15 10:18:28 +00:00
blocked-fines.inc
blocking_errors.inc Bug 20659: Fix blocking errors display 2018-04-25 16:52:07 -03:00
borrower_debarments.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
branch-selector.inc
browser-strings.inc
budgets-active-currency.inc Bug 7651: (QA follow-up) Fix warning about undefined active currency 2018-07-18 17:45:22 +00:00
budgets-admin-search.inc
budgets-admin-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
calendar.inc
cat-menu.inc
cat-search.inc
cat-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
catalog-strings.inc Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc 2018-07-02 11:06:59 +00:00
cataloging-search.inc
cateditor-ui.inc Bug 21064: Use undefined instead of undef 2018-07-19 16:24:30 +00:00
cateditor-widgets-marc21.inc Bug 20700: MARC21 add/update leader/007/008 codes 2018-06-08 09:48:12 -04:00
checkin-search.inc Bug 18521: Fix key binding in the header 2018-06-22 20:19:10 +00:00
checkouts-table-footer.inc
checkouts-table.inc
circ-menu.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
circ-nav.inc Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
circ-patron-search-results.inc Bug 18474: (QA follow-up) Remove useless else in template 2018-04-02 18:07:34 -03:00
circ-search.inc
cities-admin-search.inc
columns_settings.inc Bug 18791: Export visible columns only 2018-04-13 13:55:22 -03:00
contracts-admin-search.inc
country-list.inc
currencies-admin-search.inc
datatables.inc Bug 18791: (follow up) Fix translation of copy messages 2018-04-13 13:55:22 -03:00
date-format.inc
delimiter_text.inc Bug 19910: Use span to make translators happy 2018-04-04 16:06:56 -03:00
doc-head-close-receipt.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
doc-head-close.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
doc-head-open.inc
empty_line.inc
facets.inc Bug 18322: Add a facet for ccode fields to Zebra 2018-07-18 17:42:48 +00:00
form-blocks.inc
format_price.inc
greybox.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
guided-reports-view.inc Bug 19856: Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
header.inc Bug 2426: Remove deprecated management permission 2018-06-08 12:17:25 +00:00
help-bottom.inc
help-top.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
home-search.inc Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
html_helpers.inc Bug 19289: Use the ACQ framework to display bibliographic details 2018-04-11 16:45:20 -03:00
ill-toolbar.inc Bug 20515: (follow-up) Add missing CAN_user_ill 2018-04-16 13:59:34 -03:00
installer-doc-head-close.inc Bug 20173: Fix favicon.ico path in installer 2018-03-19 13:55:47 -03:00
installer-strings.inc
intranet-bottom.inc Bug 20135: Prevent staff client language choose pop-up from appearing off-screen 2018-02-13 12:50:34 -03:00
intranetstylesheet.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
js_includes.inc Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" 2018-07-06 10:12:36 +00:00
labels-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
langmenu-staff-top.inc Bug 20135: Prevent staff client language choose pop-up from appearing off-screen 2018-02-13 12:50:34 -03:00
letters-search.inc
member-alt-address-style-de.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-alt-address-style-fr.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-alt-address-style-us.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-alt-contact-style-de.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-alt-contact-style-fr.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-alt-contact-style-us.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-address-style-de.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-address-style-fr.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-address-style-us.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-alt-address-style-de.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-alt-address-style-fr.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-display-alt-address-style-us.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-main-address-style-de.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-main-address-style-fr.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
member-main-address-style-us.inc Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
members-menu.inc Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
members-toolbar.inc Bug 3886: Fix mismatch of required permissions for printing slips 2018-05-29 13:52:34 +00:00
merge-record-strings.inc
merge-record.inc
messaging-preference-form.inc Bug 19641: Move patron templates to the footer 2018-02-15 13:30:23 -03:00
nl-search-form.tt
noadd-warnings.inc
onboarding_messages.inc
page-numbers.inc Bug 19502: (follow-up) Pass parameters to avoid making templates depend on search engine 2018-07-12 13:04:21 +00:00
password_check.inc Bug 19908: Do not use .optional in password match validation function 2018-03-19 12:23:13 -03:00
patron-article-requests.inc
patron-search-box.inc
patron-search.inc Bug 18789: Use the patron variable in circulation.[pl|tt] 2018-02-16 13:03:58 -03:00
patron-title.inc Bug 20981: Fix organization name when displaying patron's info 2018-06-22 13:16:44 +00:00
patron-toolbar.inc Bug 20205: Add IDs to buttons in patron-toolbar.inc 2018-02-16 13:03:58 -03:00
patroncards-errors.inc
patroncards-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
patrons-admin-search.inc
permissions.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
popup-bottom.inc
prefs-admin-search.inc
prefs-menu.inc Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' 2018-04-11 16:45:09 -03:00
quotes-toolbar.inc
quotes-upload-toolbar.inc
reports-menu.inc Bug 19856: (follow-up) Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
reports-toolbar.inc Bug 20945: (RM follow-up) Escape param_name too 2018-06-29 20:09:38 +00:00
resort_form.inc
rotating-collections-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
search_indexes.inc
select2.inc Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
serials-menu.inc
serials-search.inc
serials-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
slip-print.inc
strings.inc Bug 21029: Make "Suspend until:" translatable 2018-07-06 10:13:52 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc
timepicker.inc
tools-item-action.inc
tools-menu.inc Bug 11317: (QA follow-up) Change tool name to be more general 2018-05-03 13:26:50 -03:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
wysiwyg-systempreferences.inc Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected behaviour 2018-08-09 11:11:22 +00:00
xslt-handler.inc Bug 20272: Changes for Breeding.pm and Record.pm 2018-07-02 12:12:49 +00:00
z3950-admin-search.inc
z3950_search.inc