6cf8c901f5
This patch uses the patron category of the patron who requested the most relevant recall to check for more specific circulation rules relating to recalls. This ensures that patrons who are allowed to place recalls are able to fill their recalls, especially when recalls are not generally available for all patron categories. To test: 1) Go to Administration -> System preferences and enable UseRecalls 2) Go to Administration -> Circulation and fines rules and set a general All/All rule and a Category A/Itemtype A rule. All values can be set however you like except for these recalls rules: All/All rule: Recalls allowed: 0 Recalls per record: 0 On shelf recalls allowed: if any unavailable Category A/Itemtype A rule: Recalls allowed: 5 Recalls per record: 5 On shelf recalls allowed: if any unavailable 3) Find an item of Itemtype A. Check it out to Patron A (any category). 4) Log into the OPAC as Patron B (of Category A). Find the item and place a recall on the item. 5) Back in the staff interface, check in the item. This should trigger the recalls process so you can allocate the item to Patron B's recall, however the pop-up box to confirm the recall does not show. This is the bug. 6) Apply the patch and restart services 7) Check in the item again. Confirm the pop-up box to confirm the recall shows and you are able to allocate the item to Patron B's recall. 8) Confirm tests pass t/db_dependent/Koha/Item.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
||
|---|---|---|
| .. | ||
| Acquisition | ||
| Biblio | ||
| Budgets | ||
| Circulation | ||
| cypress | ||
| data | ||
| db_dependent | ||
| edi_testfiles | ||
| etc | ||
| External | ||
| Koha | ||
| lib | ||
| Members | ||
| Number | ||
| Search | ||
| Serials | ||
| SIP | ||
| Test | ||
| 00-check-atomic-updates.t | ||
| 00-deprecated.t | ||
| 00-load.t | ||
| 00-merge-conflict-markers.t | ||
| 00-testcritic.t | ||
| 00-valid-xml.t | ||
| Auth.t | ||
| Auth_with_shibboleth.t | ||
| AuthoritiesMarc_MARC21.t | ||
| AuthoritiesMarc_UNIMARC.t | ||
| Barcodes_annual.t | ||
| Barcodes_EAN13.t | ||
| Barcodes_hbyymmincr.t | ||
| Barcodes_incremental.t | ||
| Biblio.t | ||
| Biblio2.t | ||
| Budgets.t | ||
| Calendar.t | ||
| Charset.t | ||
| Circulation_barcodedecode.t | ||
| ClassSortRoutine.t | ||
| ClassSortRoutine_Dewey.t | ||
| ClassSortRoutine_Generic.t | ||
| ClassSortRoutine_LCC.t | ||
| ClassSource.t | ||
| Context.t | ||
| Contract.t | ||
| CookieManager.t | ||
| Creators.t | ||
| DateUtils.t | ||
| dummy.t | ||
| Edifact.t | ||
| EdiInvoice.t | ||
| Ediorder.t | ||
| Ediordrsp.t | ||
| EdiTransport.t | ||
| Form_MessagingPreferences.t | ||
| HtmlTags.t | ||
| ImportBatch.t | ||
| Installer_PerlModules.t | ||
| ItemCirculationAlertPreference.t | ||
| Koha.t | ||
| Koha_MetadataRecord.t | ||
| Koha_SearchEngine_Elasticsearch_Browse.t | ||
| Koha_Template_Plugin_Cache.t | ||
| Koha_Template_Plugin_HtmlId.t | ||
| Koha_Template_Plugin_Koha.t | ||
| Koha_Util_FrameworkPlugin.t | ||
| Koha_Util_MARC.t | ||
| Koha_XSLT_HTTPS.t | ||
| Labels.t | ||
| Labels_split_ccn.t | ||
| Labels_split_ddcn.t | ||
| Labels_split_lccn.t | ||
| Labels_split_Regex.t | ||
| Languages.t | ||
| Letters.t | ||
| Logger.t | ||
| Makefile.t | ||
| Matcher.t | ||
| Members_Messaging.t | ||
| OpenLibrarySearch.t | ||
| Output.t | ||
| Output_JSONStream.t | ||
| Patron.t | ||
| Patroncards.t | ||
| Patroncards_Batch.t | ||
| Patroncards_Lib.t | ||
| Patroncards_Patroncard.t | ||
| Patroncards_Profile.t | ||
| Patroncards_Template.t | ||
| Prices.t | ||
| RecordProcessor.t | ||
| Ris.t | ||
| Scheduler.t | ||
| Scrubber.t | ||
| Search.t | ||
| Search_PazPar2.t | ||
| SimpleMARC.t | ||
| SMS.t | ||
| SocialData.t | ||
| Stats.t | ||
| SuggestionEngine.t | ||
| SuggestionEngine_AuthorityFile.t | ||
| template_filters.t | ||
| timezones.t | ||
| TmplToken.t | ||
| Token.t | ||
| XSLT.t | ||