Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart 710c0e5df6 Bug 18856: Don't show cancel option for waiting holds in OPAC 
This is the alternative patch of Kyle's
"""
If a hold is 'waiting' for the patron to collect then the patron should
be prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure'
alert and when you click Yes the page just refreshes and the hold
remains.
Staff can cancel the hold from the staff interface but they can then
action the waiting hold.
I think therefore that it is correct behaviour that a patron cannot
cancel a hold when it reaches waiting state via the opac but it would be
useful to either have a warning to prevent the cancellation or a useful
message when they attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a
hold,
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds
"""

It sounds better to keep the ->is_cancelable method, for readability

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-05-17 11:40:03 -03:00
..
Acquisition Bug 20144: [sql_modes] Add default value for export_basket.description in tests 2018-02-13 13:58:57 -03:00
api/v1 Bug 20624: Net::OAuth2::AuthorizationServer is not a hard dependency 2018-05-09 12:56:03 -03:00
Auth
Authority Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio Bug 20126: Add simple test for ModBiblioMarc 2018-02-02 12:08:42 -03:00
Circulation Bug 20562: Fix Returns.t test 2018-04-19 16:26:51 -03:00
Creators Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests 2018-02-13 13:58:59 -03:00
data
Exporter Bug 18201: Tidy tests 2017-12-21 13:21:12 -03:00
Holds Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest 2018-02-13 13:02:23 -03:00
Illrequest Bug 7317: Remove traces of UnmediatedILL 2017-11-09 11:42:16 -03:00
Items Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory 2018-02-13 13:59:00 -03:00
Koha Bug 20764: (follow-up) Rename the test file 2018-05-14 12:33:48 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters Bug 19578: Remove MARC punctuation in notices (TT syntax) 2018-04-04 15:45:43 -03:00
Members Bug 20531: (follow-up) Set the timestamps to the same value to get a correct order 2018-05-07 12:22:44 -03:00
OAI Bug 20665: Units tests for testing MySQL connection time zone 2018-05-03 12:46:55 -03:00
Patron Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly 2018-03-30 13:15:16 -03:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 20144: [sql_modes] Fix values when creating a sql report in tests 2018-02-13 13:59:00 -03:00
Reserves Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos 2017-10-09 13:47:02 -03:00
Search Bug 20144: [sql_modes] Fix search history tests 2018-02-13 13:59:00 -03:00
selenium Bug 19181: Do not screenshot 2018-05-14 10:36:12 -03:00
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:59:00 -03:00
SIP Bug 18625: (QA follow-up) Unit tests 2018-04-11 16:45:10 -03:00
Template/Plugin Bug 19655: Add tests 2017-11-26 12:59:31 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 18336: Full stack tests for supplemental UTF-8 chars 2018-02-16 17:53:42 -03:00
XSLT_Handler
00-strict.t Bug 18055: (QA followup) Only print output if DEBUG 2018-03-28 15:53:12 -03:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 2696: (QA follow-up) Add more test, move to subtest 2018-04-24 14:01:48 -03:00
Acquisition.t Bug 17457: Add tests for each marc flavour 2018-03-23 11:45:38 -03:00
AdditionalField.t Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
Amazon.t
ArticleRequests.t Bug 18403: Article requests 2018-02-12 15:41:41 -03:00
AudioAlerts.t
Auth.t Bug 20489: Prevent DB user login 2018-04-20 12:24:00 -03:00
Auth_with_cas.t Bug 19373: Update tests 2017-10-16 09:38:41 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 9701: (follow-up) Adjust tests 2018-04-12 10:50:34 -03:00
Bookseller.t Bug 20144: [sql_modes] Fix date format in tests 2018-02-13 13:58:50 -03:00
Breeding.t
Budgets.t Bug 18999: (QA followup) ModReceiveOrder expects a hashref 2017-09-29 13:03:38 -03:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
check_kohastructure.t Bug 19783: Move check_kohastructure.t to db_dependent 2018-01-19 15:13:56 -03:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
Circulation.t Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly 2018-05-07 13:15:34 -03:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
Context.t Bug 19788: Add a test 2017-12-22 13:15:37 -03:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 19705: Try to fix random failures from DecreaseLoanHighHolds.t 2018-01-23 17:01:29 -03:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t Bug 20204: Add TestBuilder to replace CPL branch 2018-02-15 11:15:53 -03:00
Heading_MARC21.t
Hold.t Bug 18856: Don't show cancel option for waiting holds in OPAC 2018-05-17 11:40:03 -03:00
Holds.t Bug 19766: (bug 19058 follow-up) Fix Preview routing slip 2017-12-07 09:37:01 -03:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
ILSDI_Services.t Bug 12001: Move GetMemberAccountBalance to Koha::Account->non_issues_charges 2018-02-23 10:57:30 -03:00
ImportBatch.t Bug 20764: (QA follow-up) Fix path to sample plugins 2018-05-14 12:13:20 -03:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 18816: (QA follow-up) Convert param to hashref, fix typo 2018-04-06 14:51:15 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 20144: [sql_modes] Correct quotes.timestamp values in tests 2018-02-13 13:58:54 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 19581: Fix Koha_Elasticsearch.t 2018-04-09 17:44:20 -03:00
Koha_Elasticsearch_Indexer.t Bug 19581: Unit tests 2018-04-09 16:15:18 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 19564: (QA follow-up) Make commented out tests pass 2018-03-28 16:05:10 -03:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 19855: Move getalert, addalert and delalert to Koha::Subscription 2018-04-23 14:22:15 -03:00
LibraryGroups.t Bug 18403: Add new method Koha::Library::Group->has_child 2018-02-12 15:41:37 -03:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 19069: Fix 'does not match' behaviour in MARC modification template 2017-10-27 14:09:01 -03:00
Members.t Bug 20590: Fix Members.t 2018-04-20 10:17:49 -03:00
MungeMarcPrice.t
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 20474: Mimick Letters.t 2018-03-27 12:21:44 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 9302: (QA follow-up) Consistency follow-up 2018-04-20 13:34:41 -03:00
Plugins.t Bug 20764: Fix Plugins.t 2018-05-14 13:09:37 -03:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t Bug 20097: (follow-up) Add a unit test 2018-03-19 13:54:50 -03:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 20724: Add tests for ReservesNeedReturns 2018-05-16 10:53:13 -03:00
rollingloans.t Bug 18797: Create the biblioitem entry 2018-03-26 17:31:17 -03:00
RotatingCollections.t Bug 16735: Migrate library search groups into the new hierarchical groups 2018-02-12 15:41:25 -03:00
Search.t Bug 19873: Add unit tests 2018-04-20 13:34:41 -03:00
Serials.t Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:56 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 17770: Perltidy 2017-12-21 13:09:16 -03:00
Stats.t Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan 2018-02-26 13:24:45 -03:00
sysprefs.t
Tags.t
Templates.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
TestBuilder.t Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty 2018-01-23 16:05:54 -03:00
Upload.t Bug 20081: Set inline headers for uploaded pdfs 2018-03-26 17:31:17 -03:00
UsageStats.t Bug 20264: Remove syspref checkdigit 2018-03-23 11:45:38 -03:00
Virtualshelves.t Bug 11943: Add unit test for double accepts 2018-05-11 10:52:44 -03:00
XISBN.t Bug 20321: Remove get_biblionumber_from_isbn 2018-03-19 13:55:47 -03:00
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
zebra_config.pl