Koha/svc
Aleisha Amohia 700b7dfa09 Bug 7862: Preventing warns when creating a notice
To reproduce warns:
1) Go to Tools -> Notices & slips
2) Create a new notice of any module

Notice these warns:
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.

CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.

3) Create a new notice of the Circulation module

Notice this additional warn:
Use of uninitialized value $code in pattern match (m//) at
/home/vagrant/kohaclone/tools/letter.pl line 258.

To test:
4) Apply patch and refresh page
5) Run steps 1-3 again and confirm no warns show

Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-05-15 12:10:52 +00:00
..
cataloguing Bug 19263: Rancor - Add auto-001 widget 2018-10-27 13:26:08 +00:00
club
config Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences 2018-11-07 12:29:32 +00:00
hold
letters Bug 7862: Preventing warns when creating a notice 2019-05-15 12:10:52 +00:00
mana Bug 22250: Clean up Mana KB integration with serials and reports 2019-04-11 11:34:14 +00:00
members Bug 22483: Restore svc/members/search 2019-03-09 05:16:40 -03:00
records
virtualshelves
article_request
authentication
barcode
bib
bib_framework Bug 16424: (QA follow-up) Use Modern::Perl 2018-09-28 19:01:51 +00:00
bib_profile
checkin Bug 14576: Allow arbitrary automatic update of location on checkin 2019-04-25 11:36:23 +00:00
checkout_notes
checkouts
convert_report
cover_images
creator_batches Bug 15766: (follow-up) Fixing layout of description button 2018-10-24 13:52:43 +00:00
holds
import_bib
localization Bug 14391: Add granular permissions to the administration module 2018-11-07 12:29:32 +00:00
new_bib Bug 16424: Handle framework code properly also when adding a new record 2018-09-28 19:01:51 +00:00
renew Bug 7088: Allow renew on hold items with due date 2019-05-09 14:40:49 +00:00
report Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-10-15 13:45:42 +00:00
split_callnumbers Bug 22388: Add missing +x flag to split_callnumbers 2019-02-21 15:54:20 +00:00