Alex Buckley
7b66b90fe7
If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=<ordernumber>; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell <instancename> prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| acqui-home.pl | ||
| add_user_search.pl | ||
| addorder.pl | ||
| addorderiso2709.pl | ||
| ajax-getauthvaluedropbox.pl | ||
| basket.pl | ||
| basketgroup.pl | ||
| basketheader.pl | ||
| booksellers.pl | ||
| cancelorder.pl | ||
| check_budget_total.pl | ||
| check_uniqueness.pl | ||
| duplicate_orders.pl | ||
| edi_ean.pl | ||
| edifactmsgs.pl | ||
| edimsg.pl | ||
| finishreceive.pl | ||
| histsearch.pl | ||
| invoice-files.pl | ||
| invoice.pl | ||
| invoices.pl | ||
| lateorders-export.pl | ||
| lateorders.pl | ||
| modordernotes.pl | ||
| neworderempty.pl | ||
| newordersubscription.pl | ||
| newordersuggestion.pl | ||
| ordered.pl | ||
| orderreceive.pl | ||
| parcel.pl | ||
| parcels.pl | ||
| showorder.pl | ||
| spent.pl | ||
| supplier.pl | ||
| transferorder.pl | ||
| uncertainprice.pl | ||
| updatesupplier.pl | ||
| z3950_search.pl | ||