066848a8f0
Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It works as expected. All tests in Koha.t passed. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> |
||
|---|---|---|
| .. | ||
| Acquisition | ||
| Budgets | ||
| data/db_schemas | ||
| db_dependent | ||
| lib | ||
| optional | ||
| searchengine | ||
| 00-checkdatabase-version.t | ||
| 00-deprecated.t | ||
| 00-load.t | ||
| 00-merge-conflict-markers.t | ||
| 00-testcritic.t | ||
| 00-valid-xml.t | ||
| AuthoritiesMarc_MARC21.t | ||
| AuthoritiesMarc_UNIMARC.t | ||
| Barcodes_annual.t | ||
| Barcodes_EAN13.t | ||
| Barcodes_hbyymmincr.t | ||
| Barcodes_incremental.t | ||
| Barcodes_PrinterConfig.t | ||
| Barcodes_ValueBuilder.t | ||
| Bookseller.t | ||
| Boolean.t | ||
| Branch.t | ||
| Breeding.t | ||
| Budgets.t | ||
| Cache.t | ||
| Calendar.t | ||
| Category.t | ||
| Charset.t | ||
| Circulation_barcodedecode.t | ||
| ClassSortRoutine.t | ||
| ClassSortRoutine_Dewey.t | ||
| ClassSortRoutine_Generic.t | ||
| ClassSortRoutine_LCC.t | ||
| ClassSource.t | ||
| Contract.t | ||
| Creators.t | ||
| Dates.t | ||
| DateUtils.t | ||
| Debug.t | ||
| dummy.t | ||
| External_Syndetics.t | ||
| Form_MessagingPreferences.t | ||
| Heading.t | ||
| ILSDI_Services.t | ||
| ILSDI_Utility.t | ||
| Images.t | ||
| ImportBatch.t | ||
| Input.t | ||
| Installer_PerlDependencies.t | ||
| Installer_PerlModules.t | ||
| Installer_pm.t | ||
| ItemCirculationAlertPreference.t | ||
| ItemType.t | ||
| Koha.t | ||
| Labels.t | ||
| Labels_split_ccn.t | ||
| Labels_split_ddcn.t | ||
| Labels_split_lccn.t | ||
| Languages.t | ||
| Letters.t | ||
| Log.t | ||
| Maintainance.t | ||
| Makefile | ||
| Matcher.t | ||
| Members_Attributes.t | ||
| Members_AttributeTypes.t | ||
| Members_Messaging.t | ||
| Message.t | ||
| NewsChannels.t | ||
| Output.t | ||
| Output_JSONStream.t | ||
| Overdues.t | ||
| Patroncards.t | ||
| Patroncards_Batch.t | ||
| Patroncards_Layout.t | ||
| Patroncards_Lib.t | ||
| Patroncards_Patroncard.t | ||
| Patroncards_Profile.t | ||
| Patroncards_Template.t | ||
| perlcriticrc | ||
| Print.t | ||
| RecordProcessor.t | ||
| Review.t | ||
| rewrite-config-test.PL | ||
| Ris.t | ||
| RotatingCollections.t | ||
| Scheduler.t | ||
| Scrubber.t | ||
| Search_PazPar2.t | ||
| SIP_Sip.t | ||
| smolder_smoke_signal | ||
| SMS.t | ||
| SocialData.t | ||
| Stats.t | ||
| SuggestionEngine.t | ||
| SuggestionEngine_AuthorityFile.t | ||
| TmplToken.t | ||
| Utils.t | ||
| VirtualShelves_Merge.t | ||
| XSLT.t | ||
| Z3950.t | ||