Jonathan Druart
b64e6be1c4
From C4::Koha::GetAuthorisedValues
# TODO: the "selected" feature should be replaced by a utility function
# somewhere else, it doesn't belong in here. For starters it makes
# caching much more complicated. Or just let the UI logic handle it, it's
# what it's for.
Indeed, it's not a job for a subroutine, the template should take care of that.
Note that a perf gain could be won with this patch \o/
Test plan:
- Edit an itemtype and check the value of the "Search category" dropdown list
- Edit a patron attribute type and check the value of the "Class" dropdown list
- Detail for a catalogue record, the Status column should be correctly
populated if items are damaged and/or lost
- Item details for a catalogue record, the lost, damaged and withdrawn
value should be correctly displayed
- Edit a patron, the "street type" should be correctly selected
- Create a patron attribute type linked to an authorised value list.
- Edit a patron, set a value for this attribute, edit it again. The
correct value should be selected.
- Search for subscriptions. The 'Location' dropdown list should behave
correctly (select the entry you have choosen before, etc.)
- Edit a subscription, the location dropdown list should select the
correct value.
- Edit and view a suggestion with a 'reason for suggestion' set (you
should have at least 1 OPAC_SUG AV defined)
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
31 lines
1 KiB
HTML
31 lines
1 KiB
HTML
[% USE AuthorisedValues %]
|
|
[%#
|
|
Parameters:
|
|
name: the name of the select element
|
|
category: the authorised value category
|
|
default: the default authorised value to select
|
|
class: the CSS class of the select element
|
|
size: the size to use for the input (generated if the authorised value category does not exist).
|
|
all: add a "All" entry
|
|
%]
|
|
|
|
[% SET avs = AuthorisedValues.GetAuthValueDropbox( category, default ) %]
|
|
[% DEFAULT
|
|
class = ''
|
|
size = 20
|
|
%]
|
|
|
|
[% IF avs %]
|
|
<select id="[% name %]" name="[% name %]" class="[% class %]" >
|
|
[% IF all %]<option value="All">All</option>[% END %]
|
|
[% FOR av IN avs %]
|
|
[% IF av.default %]
|
|
<option value="[% av.value %]" selected="selected">[% av.label | html_entity %]</option>
|
|
[% ELSE %]
|
|
<option value="[% av.value %]">[% av.label | html_entity %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
[% ELSE %]
|
|
<input type="text" id="[% name %]" name="[% name %]" size="[% size %]" value="[% default | html_entity %]" class="[% class %]" />
|
|
[% END %]
|