Koha/C4/SIP/ILS/Transaction/Renew.pm
Nick Clemens 72750cf3b7 Bug 15494: Update display of renewal errors
To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-07 21:39:38 +00:00

68 lines
1.8 KiB
Perl

#
# Status of a Renew Transaction
#
package C4::SIP::ILS::Transaction::Renew;
use warnings;
use strict;
use C4::Circulation;
use Koha::Patrons;
use Koha::DateUtils;
use parent qw(C4::SIP::ILS::Transaction);
my %fields = (
renewal_ok => 0,
);
sub new {
my $class = shift;
my $self = $class->SUPER::new();
foreach my $element (keys %fields) {
$self->{_permitted}->{$element} = $fields{$element};
}
@{$self}{keys %fields} = values %fields; # overkill?
return bless $self, $class;
}
sub do_renew_for {
my $self = shift;
my $borrower = shift;
my ($renewokay,$renewerror) = CanBookBeRenewed($borrower->{borrowernumber},$self->{item}->{itemnumber});
if ($renewokay) { # ok so far check charges
my ($fee, undef) = GetIssuingCharges($self->{item}->{itemnumber}, $self->{patron}->{borrowernumber});
if ($fee > 0) {
$self->{sip_fee_type} = '06';
$self->{fee_amount} = sprintf '%.2f',$fee;
if ($self->{fee_ack} eq 'N') {
$renewokay = 0;
}
}
}
if ($renewokay){
my $issue = AddIssue( $borrower, $self->{item}->id, undef, 0 );
$self->{due} = $self->duedatefromissue($issue, $self->{item}->{itemnumber});
$self->renewal_ok(1);
} else {
$renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;
$renewerror=~s/too_many/Item has reached maximum renewals/;
$renewerror=~s/item_denied_renewal/Item renewal is not allowed/;
$self->screen_msg($renewerror);
$self->renewal_ok(0);
}
$self->ok(1);
return;
}
sub do_renew {
my $self = shift;
my $patron = Koha::Patrons->find( { cardnumber => $self->{patron}->id } );
return $self->do_renew_for($patron->unblessed);
}
1;