b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
293 lines
12 KiB
Perl
293 lines
12 KiB
Perl
#!/usr/bin/perl
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 50;
|
|
|
|
use MARC::Record;
|
|
|
|
use C4::Biblio qw( AddBiblio );
|
|
use Koha::Database;
|
|
use Koha::Patrons;
|
|
use t::lib::Mocks;
|
|
use t::lib::TestBuilder;
|
|
use_ok('C4::Serials');
|
|
use_ok('C4::Budgets');
|
|
|
|
# Mock userenv
|
|
local $SIG{__WARN__} = sub { warn $_[0] unless $_[0] =~ /redefined/ };
|
|
my $userenv;
|
|
*C4::Context::userenv = \&Mock_userenv;
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
my $library1 = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $library2 = $builder->build({
|
|
source => 'Branch',
|
|
});
|
|
my $patron_category = $builder->build({ source => 'Category' });
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $record = MARC::Record->new();
|
|
$record->append_fields(
|
|
MARC::Field->new( '952', '0', '0', a => $library1->{branchcode}, b => $library1->{branchcode} )
|
|
);
|
|
my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio($record, '');
|
|
|
|
my $my_branch = $library1->{branchcode};
|
|
my $another_branch = $library2->{branchcode};
|
|
my $bpid = AddBudgetPeriod({
|
|
budget_period_startdate => '2015-01-01',
|
|
budget_period_enddate => '2015-12-31',
|
|
budget_period_description => "budget desc"
|
|
});
|
|
|
|
my $budget_id = AddBudget({
|
|
budget_code => "ABCD",
|
|
budget_amount => "123.132",
|
|
budget_name => "Périodiques",
|
|
budget_notes => "This is a note",
|
|
budget_period_id => $bpid
|
|
});
|
|
|
|
my $subscriptionid_from_my_branch = NewSubscription(
|
|
undef, $my_branch, undef, undef, $budget_id, $biblionumber,
|
|
'2013-01-01', undef, undef, undef, undef,
|
|
undef, undef, undef, undef, undef, undef,
|
|
1, "notes",undef, '2013-01-01', undef, undef,
|
|
undef, undef, 0, "intnotes", 0,
|
|
undef, undef, 0, undef, '2013-12-31', 0
|
|
);
|
|
die unless $subscriptionid_from_my_branch;
|
|
|
|
my $subscriptionid_from_another_branch = NewSubscription(
|
|
undef, $another_branch, undef, undef, $budget_id, $biblionumber,
|
|
'2013-01-01', undef, undef, undef, undef,
|
|
undef, undef, undef, undef, undef, undef,
|
|
1, "notes",undef, '2013-01-01', undef, undef,
|
|
undef, undef, 0, "intnotes", 0,
|
|
undef, undef, 0, undef, '2013-12-31', 0
|
|
);
|
|
|
|
|
|
my $subscription_from_my_branch = GetSubscription( $subscriptionid_from_my_branch );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 0, "cannot edit a subscription without userenv set");
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 0, "cannot edit a subscription without userenv set");
|
|
|
|
my $userid = 'my_userid';
|
|
my $borrowernumber = Koha::Patron->new({
|
|
firstname => 'my fistname',
|
|
surname => 'my surname',
|
|
categorycode => $patron_category->{categorycode},
|
|
branchcode => $my_branch,
|
|
userid => $userid,
|
|
})->store->borrowernumber;
|
|
|
|
$userenv = { flags => 1, id => $borrowernumber, branch => '' };
|
|
|
|
# Can edit a subscription
|
|
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1, "User can edit a subscription with an empty branchcode");
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 1, "User can edit a subscription with an empty branchcode");
|
|
|
|
my $subscription_from_another_branch = GetSubscription( $subscriptionid_from_another_branch );
|
|
|
|
$userenv->{id} = $userid;
|
|
$userenv->{branch} = $my_branch;
|
|
|
|
# Branches are independent
|
|
t::lib::Mocks::mock_preference( "IndependentBranches", 1 );
|
|
set_flags( 'superlibrarian', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superlibrarian can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superlibrarian can edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superlibrarian can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superlibrarian can show a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superlibrarian can claim a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superlibrarian can claim a subscription from another branch"
|
|
);
|
|
|
|
|
|
set_flags( 'superserials', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superserials can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superserials can edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superserials can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superserials can show a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, superserials can claim a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_another_branch), 1,
|
|
"With IndependentBranches, superserials can claim a subscription from another branch"
|
|
);
|
|
|
|
|
|
|
|
set_flags( 'edit_subscription', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, edit_subscription can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, edit_subscription cannot edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, show_subscription can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, show_subscription cannot show a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 0,
|
|
"With IndependentBranches, claim_subscription cannot claim a subscription from his branch with the edit_subscription permission"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, claim_subscription cannot claim a subscription from another branch"
|
|
);
|
|
|
|
|
|
set_flags( 'renew_subscription', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 0,
|
|
"With IndependentBranches, renew_subscription cannot edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, renew_subscription cannot edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, renew_subscription can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, renew_subscription cannot show a subscription from another branch"
|
|
);
|
|
|
|
set_flags( 'claim_serials', $borrowernumber );
|
|
is( C4::Serials::can_claim_subscription($subscription_from_my_branch), 1,
|
|
"With IndependentBranches, claim_subscription can claim a subscription from his branch with the edit_subscription permission"
|
|
);
|
|
is( C4::Serials::can_claim_subscription($subscription_from_another_branch), 0,
|
|
"With IndependentBranches, claim_subscription cannot claim a subscription from another branch"
|
|
);
|
|
|
|
# Branches are not independent
|
|
t::lib::Mocks::mock_preference( "IndependentBranches", 0 );
|
|
set_flags( 'superlibrarian', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, superlibrarian can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, superlibrarian can edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, superlibrarian can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, superlibrarian can show a subscription from another branch"
|
|
);
|
|
|
|
set_flags( 'superserials', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, superserials can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, superserials can edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, superserials can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, superserials can show a subscription from another branch"
|
|
);
|
|
|
|
set_flags( 'edit_subscription', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, edit_subscription can edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, edit_subscription can edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, show_subscription can show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, show_subscription can show a subscription from another branch"
|
|
);
|
|
|
|
set_flags( 'renew_subscription', $borrowernumber );
|
|
is( C4::Serials::can_edit_subscription($subscription_from_my_branch), 0,
|
|
"Without IndependentBranches, renew_subscription cannot edit a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_edit_subscription($subscription_from_another_branch), 0,
|
|
"Without IndependentBranches, renew_subscription cannot edit a subscription from another branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_my_branch), 1,
|
|
"Without IndependentBranches, renew_subscription cannot show a subscription from his branch"
|
|
);
|
|
is( C4::Serials::can_show_subscription($subscription_from_another_branch), 1,
|
|
"Without IndependentBranches, renew_subscription cannot show a subscription from another branch"
|
|
);
|
|
|
|
# GetPreviousSerialid
|
|
my $serialid1 = NewIssue( 1, $subscriptionid_from_my_branch, $biblionumber, 2 );
|
|
my $serialid2 = NewIssue( 2, $subscriptionid_from_my_branch, $biblionumber, 2 );
|
|
my $serialid3 = NewIssue( 3, $subscriptionid_from_my_branch, $biblionumber, 2 );
|
|
is( GetPreviousSerialid( $subscriptionid_from_my_branch ), $serialid2, "get previous serialid without parameter");
|
|
is( GetPreviousSerialid( $subscriptionid_from_my_branch, 1 ), $serialid2, "get previous serialid with 1" );
|
|
is( GetPreviousSerialid( $subscriptionid_from_my_branch, 2 ), $serialid1, "get previous serialid with 2" );
|
|
is( GetPreviousSerialid( $subscriptionid_from_my_branch, 3 ), undef, "get previous serialid with 3, does not exist" );
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
# C4::Context->userenv
|
|
sub Mock_userenv {
|
|
return $userenv;
|
|
}
|
|
|
|
sub set_flags {
|
|
my ( $flags, $borrowernumber ) = @_;
|
|
my $superlibrarian_flags = 1;
|
|
if ( $flags eq 'superlibrarian' ) {
|
|
$dbh->do(
|
|
q|
|
|
UPDATE borrowers SET flags=? WHERE borrowernumber=?
|
|
|, {}, $superlibrarian_flags, $borrowernumber
|
|
);
|
|
$userenv->{flags} = $superlibrarian_flags;
|
|
}
|
|
else {
|
|
$dbh->do(
|
|
q|
|
|
UPDATE borrowers SET flags=? WHERE borrowernumber=?
|
|
|, {}, 0, $borrowernumber
|
|
);
|
|
$userenv->{flags} = 0;
|
|
my ( $module_bit, $code ) = ( '15', $flags );
|
|
$dbh->do(
|
|
q|
|
|
DELETE FROM user_permissions where borrowernumber=?
|
|
|, {}, $borrowernumber
|
|
);
|
|
|
|
$dbh->do(
|
|
q|
|
|
INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES ( ?, ?, ? )
|
|
|, {}, $borrowernumber, $module_bit, $code
|
|
);
|
|
}
|
|
}
|