Nick Clemens
814789f8cb
The code currently uses itemnumber to fetch old_issues for notices. This doesn't seem to be used in any current notices except the CHECKINSLIP: SELECTY letter.code,content FROM letter WHERE content LIKE 'old\\_%'\G For issues we use itemnumber, however, issues has a constraint to limit issues for an itemnumber to 1 Old issues has no such constraint, we try to rectify this in the old code by adding 'ORDER BY returndate DESC LIMIT 1" As the code is not used by default and buggy I think we can make a change to using 'issue_id' as the key and announcing the change - it prevents leaky data To test: 1. Check something out to patron A. Check it in. 2. Check something out to patron B. Check it in. 3. Check something out to patron C. Check it in and print the check-in slip. (Leave the checkin paghe open) 4. You will see the checkin repeat itself 3 times, one for each line in old_issues. 5. Apply patch and restart_all 6. Click the 'Print checkin slip' button again 7. You see a single checkin 8. Checkout a different item to patron A. Check it in and print the check-in slip 9. See the correct checkins Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
113 lines
3.7 KiB
Perl
Executable file
113 lines
3.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Copyright 2010 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
=head1 moremember.pl
|
|
|
|
script to do a borrower enquiry/bring up borrower details etc
|
|
Displays all the details about a borrower
|
|
written 20/12/99 by chris@katipo.co.nz
|
|
last modified 21/1/2000 by chris@katipo.co.nz
|
|
modified 31/1/2001 by chris@katipo.co.nz
|
|
to not allow items on request to be renewed
|
|
|
|
needs html removed and to use the C4::Output more, but its tricky
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth qw( get_session get_template_and_user );
|
|
use C4::Output qw( output_and_exit_if_error output_and_exit output_html_with_http_headers );
|
|
use C4::Members qw( IssueSlip );
|
|
|
|
my $input = CGI->new;
|
|
my $sessionID = $input->cookie("CGISESSID");
|
|
my $session = get_session($sessionID);
|
|
|
|
my $print = $input->param('print');
|
|
my $error = $input->param('error');
|
|
|
|
# circ staff who process checkouts but can't edit
|
|
# patrons still need to be able to print receipts
|
|
my $flagsrequired = { circulate => "circulate_remaining_permissions" };
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "circ/printslip.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
flagsrequired => $flagsrequired,
|
|
}
|
|
);
|
|
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
|
|
my $logged_in_user = Koha::Patrons->find( $loggedinuser );
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
|
|
|
|
my $branch=C4::Context->userenv->{'branch'};
|
|
my ($slip, $is_html);
|
|
if ( $print eq 'checkinslip' ) {
|
|
my $checkinslip_branch = $session->param('branch') ? $session->param('branch') : $branch;
|
|
|
|
# get today's checkins
|
|
my @issue_ids = $patron->old_checkouts->search( { branchcode => $checkinslip_branch } )
|
|
->filter_by_todays_checkins->get_column('issue_id');
|
|
|
|
my %loops = (
|
|
old_issues => \@issue_ids,
|
|
);
|
|
|
|
my $letter = C4::Letters::GetPreparedLetter(
|
|
module => 'circulation',
|
|
letter_code => 'CHECKINSLIP',
|
|
branchcode => $checkinslip_branch,
|
|
lang => $patron->lang,
|
|
tables => {
|
|
branches => $checkinslip_branch,
|
|
borrowers => $borrowernumber,
|
|
},
|
|
loops => \%loops,
|
|
message_transport_type => 'print'
|
|
);
|
|
|
|
$slip = $letter->{content};
|
|
$is_html = $letter->{is_html};
|
|
|
|
} elsif (my $letter = IssueSlip ($session->param('branch') || $branch, $borrowernumber, $print eq "qslip")) {
|
|
$slip = $letter->{content};
|
|
$is_html = $letter->{is_html};
|
|
}
|
|
|
|
$template->param(
|
|
slip => $slip,
|
|
plain => !$is_html,
|
|
borrowernumber => $borrowernumber,
|
|
caller => 'members',
|
|
stylesheet => C4::Context->preference("SlipCSS"),
|
|
error => $error,
|
|
);
|
|
|
|
$template->param( IntranetSlipPrinterJS => C4::Context->preference('IntranetSlipPrinterJS' ) );
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|