Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi 74ac5baba5 Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method
The plugins handling code expects plugins implementing an 'uninstall' method for
cleanup purposes. It executes this method, and then moves on with removing the
configuration entries in the storage, and the plugin itself.

But the 'plugins-home.tt' template makes the tool display the 'Uninstall'
link in the dropdown ONLY when the plugin has the 'uninstall' method.

This patch fixes the issue.

To reproduce:
- Install the KitchenSink plugin [1]
=> SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option
- Edit the code for the plugin:
  $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm
- Remove the uninstall sub
- Restart everything:
  $ restart_all
- Reload the browser
=> FAIL: There's no 'Uninstall' option in the actions dropdown.
- Apply this patch
- Restart everything
  $ restart_all
- Reload the browser
=> SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option
- Sign off :-D

[1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-03-26 17:01:11 -03:00
acqui
admin Bug 4078: Add the checkbox to the UI 2018-03-23 11:45:38 -03:00
api/v1
authorities Bug 20430: (See also bug 19436) Button display depends on wrong server count 2018-03-19 13:55:08 -03:00
basket
C4 Bug 20067: Fix other checks for linked authorised value categories 2018-03-26 17:01:10 -03:00
catalogue Bug 20067: Fix other checks for linked authorised value categories 2018-03-26 17:01:10 -03:00
cataloguing Bug 18593: Move suggestions when bibliographic records are merged 2018-03-26 17:01:10 -03:00
circ Bug 20067: Fix other checks for linked authorised value categories 2018-03-26 17:01:10 -03:00
clubs
course_reserves
debian Bug 20275: Add comment to let user know they can define multiple plugindirs 2018-03-23 11:45:38 -03:00
docs Bug 7143: Update about page for new dev - Maksim Sen 2018-03-19 15:38:38 -03:00
errors
etc Bug 20275: Add comment to let user know they can define multiple plugindirs 2018-03-23 11:45:38 -03:00
ill
installer Bug 20299: Koha is a gift 2018-03-26 17:01:10 -03:00
Koha Bug 19929: (QA follow-up) Fix POD 2018-03-23 11:45:38 -03:00
koha-tmpl Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method 2018-03-26 17:01:11 -03:00
labels
members Bug 19933: Move instantiation of in deletemem.pl 2018-03-23 11:45:38 -03:00
misc Bug 19933: Remove patronflags - easy ones 2018-03-23 11:45:38 -03:00
offline_circ
opac Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required 2018-03-23 11:45:37 -03:00
OpenILS
patron_lists
patroncards
plugins
reports
reserve Bug 18789: (follow-up) Fix place hold page 2018-03-26 17:00:25 -03:00
reviews
rotating_collections
serials Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem 2018-03-23 11:45:38 -03:00
services
skel
suggestion
svc
t Bug 18570: Follow up to fix test noise 2018-03-26 11:47:27 -03:00
tags
test
tmp/modified_authorities
tools Bug 20067: Fix other checks for linked authorised value categories 2018-03-26 17:01:10 -03:00
virtualshelves
xt Bug 20219: Remove t/smolder_smoke_signal 2018-03-19 13:55:47 -03:00
.editorconfig
.htaccess
.mailmap
about.pl
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl
INSTALL
install-CPAN.pl
Koha.pm Bug 20264: DBRev 17.12.00.023 2018-03-23 11:45:38 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
README
README.md
README.robots
rewrite-config.PL

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo