Main Koha release repository https://koha-community.org
Find a file
Nick Clemens 74b205649b
Bug 34639: Use coderef for releationship
This patch switches from a simple relationship to a custom join as
illustrated in the DBIx::Class docs

Reference:
https://metacpan.org/pod/DBIx::Class::Relationship::Base#Custom-join-conditions

This does not include an order_by, so I am not sure if it is sufficient

To test:
1 - On command line:
    export DBIC_TRACE=1;
2 - Save simple script:
use Modern::Perl;
use Koha::Items;

my $items = Koha::Items->search( {'me.itemnumber'=>27}, {prefetch => 'current_branchtransfers'} );
my $item = $items->next;

warn $item->_result->current_branchtransfers->count();
warn $item->get_transfer();
3 - run it
4 - Note that the query doesn't include conditions on the transfers
5 - Apply patch
6 - Repeat
7 - Note that query is correct

Test in staf client:
1. Add an item to library A
2. Go to Circulation -> Transfer
3. Transfer the item from library A to another library B
4. Set your currently logged in library to library B
5. Check-in the item
6. Observe message "Item received from A"
7. View the bibliographic record of the item (catalogue/detail.pl)
8. Observe item in "In transit from A to B since xx/xx/xxxx Available"
9. Apply patch
10. Restart all
11. Reload details - item no longer in transit

Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-09-08 11:55:01 -03:00
acqui Bug 34445: Set default budget in addorderiso2709.pl 2023-08-30 10:07:05 -03:00
admin Bug 34616: Fix showing default server info on edit SMTP server page 2023-09-01 11:07:30 -03:00
api Bug 34313: Add patron information in pass validation response 2023-08-29 14:59:02 -03:00
authorities
basket
bin
C4 Bug 34666: Combine queries in _Findgroupreserve 2023-09-08 11:54:53 -03:00
catalogue Bug 34441: Fixed Typo "Paramater" 2023-09-01 11:23:21 -03:00
cataloguing Bug 34288: Allow access to the cataloguing module with tools permission 2023-07-18 12:46:53 -03:00
circ Bug 28966: Prefetch patron data for holds queue viewer 2023-07-25 16:25:38 -03:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves
debian Bug 32911: (follow-up) Remove partner_code 2023-09-01 11:43:42 -03:00
docs
erm
errors
etc Bug 32911: (follow-up) Remove partner_code 2023-09-01 11:43:42 -03:00
ill Bug 34598: Improve handling of not found ILL request 2023-08-30 09:02:39 -03:00
installer Bug 34685: Make updatedatabase.pl propagate the error 2023-09-06 15:05:21 -03:00
Koha Bug 34639: Use coderef for releationship 2023-09-08 11:55:01 -03:00
koha-tmpl Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header 2023-09-08 11:55:00 -03:00
labels
lib/CGI/Session/Serialize
members Bug 22990: Add CSRF protection to boraccount, pay and suggestion 2023-08-07 21:00:01 -03:00
misc Bug 28995: Update aliases 2023-09-08 11:54:55 -03:00
offline_circ Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
opac Bug 34694: Only check for IsAvailableForItemLevelRequest if is authenticated 2023-09-05 11:52:27 -03:00
patron_lists
patroncards
plugins
pos Bug 34331: Use register from userenv if parameter not passed 2023-08-29 14:37:16 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 29664: (QA follow-up) Typo transacton 2023-07-03 14:51:36 -03:00
reserve Bug 34634: Show expirationdate of expired holds on reserve/request.pl 2023-09-01 12:08:37 -03:00
reviews
rotating_collections
serials Bug 33039: Add ability to specify a template for serial subscription "Published on (text)" field 2023-07-14 08:59:43 -03:00
services
skel
suggestion Bug 34601: Fix edit/delete links on suggestion.tt 2023-08-29 14:37:10 -03:00
svc Bug 34533: jsdiff library missing from guided reports page 2023-08-29 14:37:13 -03:00
t Bug 34639: Add tests 2023-09-08 11:55:01 -03:00
tags
tools Bug 21083: Remove all attributes 2023-09-05 14:46:07 -03:00
virtualshelves Bug 34650: Remove unnecessary CSRF check on edit_form 2023-09-01 11:07:36 -03:00
xt
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference 2023-09-01 11:43:39 -03:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-07-25 08:25:41 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 34584: DBRev 23.06.00.016 2023-09-01 11:43:38 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 34319: Remove cypress.json from Makefile.PL 2023-09-06 09:57:01 -03:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo