Koha/C4
Fridolyn SOMERS 755decfd89 Bug 9392: confirmation does not appear for negative notforloan items issues
When checking-out an item marked "not for loan" with a positive value,
you get a message to forbid or confirm issue (depending on
AllowNotForLoanOverride syspref).  For an item with a negative value
(usually during acquisition process), the issue is made without forbid
or confirm message.

This patch simply changes the test notforloan > 0 into notforloan != 0.

Test plan :
- Checkout an item with items.notforloan = 0
=> The item is issued without message
- Checkout an item with items.notforloan > 0
=> A message forbids or asks confirmation to override
- Checkout an item with items.notforloan < 0 (e.g., on order)
=> A message forbids or asks confirmation to override

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked with AllowNotForLoanOverride on and off.
All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-02-08 21:38:49 -05:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
Creators
External
Form
Heading
ILSDI Bug 9019: Return item fields in ILS-DI GetRecords 2012-12-11 08:33:04 -05:00
Installer Revert "Bug 7167: New version for updatedatabase" 2012-12-27 14:02:56 -05:00
Labels
Linker
Members Bug 7919: Fix unit test (Members_AttributeTypes.t) 2012-12-07 18:26:37 -05:00
OAI
Output
Patroncards
Reports
Search
SIP Bug 9343: handles the new format of Debarred 2013-01-22 20:01:06 -05:00
Utils
VirtualShelves Bug 9174: Fix itemtype image display in OPAC lists 2013-01-31 10:59:04 -05:00
Accounts.pm Bug 9122: fix the problem when writing-off a fine 2012-11-23 09:09:53 -05:00
Acquisition.pm Bug 9503 Correct name of parameter passed to parcel.pl 2013-02-04 07:45:57 -05:00
Auth.pm Merge branch 'bug_9102' into 3.12-master 2013-02-01 10:50:27 -05:00
Auth_cas_servers.yaml.orig
Auth_with_cas.pm
Auth_with_ldap.pm Bug 8919 - ExtendedPatronAttributes not populated from LDAP 2012-11-08 12:42:52 -05:00
AuthoritiesMarc.pm Bug 9123: Authorities search ordered by authid does not work 2012-12-02 16:28:12 -05:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 9147: OPAC hidden fields are not hidden in ISBD view 2013-01-17 21:12:29 -05:00
Bookseller.pm Bug 8164: Replace IFNULL with COALESCE 2012-11-28 19:08:29 -05:00
Boolean.pm
Branch.pm Follow-up Bug 5634: Ordering branches should be case independent 2012-12-21 07:42:18 -05:00
Breeding.pm Bug 9105: Second housekeeping followup 2012-12-22 16:16:59 -05:00
Budgets.pm Bug 7919: Followup: Fix plural and GetAuthvalueDropbox 2012-12-05 10:10:58 -05:00
Calendar.pm
Category.pm Bug 7919: FIX the "all" categories method 2013-01-02 16:50:52 -05:00
Charset.pm
Circulation.pm Bug 9392: confirmation does not appear for negative notforloan items issues 2013-02-08 21:38:49 -05:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Revert "Bug 7167: Set final updatedatabase.pl version" 2012-12-27 14:02:50 -05:00
Contract.pm
Creators.pm
Csv.pm
Dates.pm
Debug.pm
Heading.pm
HoldsQueue.pm Bug 8890: C4/HoldsQueue requires DB 2012-10-24 17:52:36 +02:00
HTML5Media.pm Bug 8377: Followup move style in a css file and do not pass template to a pm 2012-12-27 09:28:00 -05:00
Images.pm Bug 8710 - Don't show the images tab in the OPAC if the record has no local images 2012-11-28 18:54:40 -05:00
ImportBatch.pm Bug 7368: Update GetXmlBiblio documentation 2012-12-27 10:14:19 -05:00
ImportExportFramework.pm
Input.pm Bug 7919 : Display of values depending on the connexion library 2012-12-05 10:10:57 -05:00
Installer.pm Revert "Bug 7167: New version for updatedatabase" 2012-12-27 14:02:56 -05:00
ItemCirculationAlertPreference.pm
Items.pm Bug 9116: Remove some useless tmp variables 2013-01-21 08:55:34 -05:00
ItemType.pm
Koha.pm Bug 9494: update default LOC z39.50 target settings 2013-01-31 11:11:16 -05:00
Labels.pm
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-20 14:39:56 -05:00
Letters.pm Bug 9348 - Format dates in HOLD notices consistently 2013-01-18 13:45:59 -05:00
Linker.pm
Log.pm Bug 7067 - OPAC Borrower Self Registration 2012-12-14 08:08:59 -05:00
Maintainance.pm
Matcher.pm
Members.pm Bug 7243: Rewording and renaming 2013-01-24 09:17:12 -05:00
Message.pm
NewsChannels.pm
Output.pm
Overdues.pm Bug 8939 : Fines being charged during the grace period 2012-10-26 17:26:07 +02:00
Patroncards.pm
Print.pm
Ratings.pm
Record.pm
Reports.pm
Reserves.pm Bug 8559 - conflicting item statuses - QA Followup 2012-11-28 17:09:32 -05:00
Review.pm
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 9183: Refactor ZOOM event loop 2012-12-27 10:09:07 -05:00
Serials.pm Bug 8443: Suggestions publication year and copyright date (follow-up 1) Comments corrections 2013-01-15 22:10:59 -05:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
SQLHelper.pm
Stats.pm
Suggestions.pm Bug 8443: Suggestions publication year and copyright date (follow-up 2) Cosmetic changes and perltidy formatting 2013-01-15 22:10:59 -05:00
Tags.pm Bug 9136: C4::Tags not Plack-compatible 2012-12-22 15:47:48 -05:00
Templates.pm Bug 9102 : Followup Set HttpOnly on the CGISESSID cookie 2013-02-01 10:50:12 -05:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UploadedFile.pm
Utils.pm
VirtualShelves.pm Bug 8032: Sort lists by call number 2012-11-30 07:28:37 -05:00
XISBN.pm
XSLT.pm Bug 8947: [SIGNED-OFF] XSLT fallback logic backwards 2012-10-26 17:41:08 +02:00
Z3950.pm