Kyle M Hall
9b10f69ee3
We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. Test Plan: 1) Enable AllowItemsOnHoldCheckoutSCO 2) Place a hold on an item 3) Attempt to check that item out to another patron 4) Note the checkout is blocked 5) Apply this patch 6) Restart all the things! 7) Attempt the checkout again 8) The checkout now succeeds! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> |
||
|---|---|---|
| .. | ||
| AuthoritiesMarc | ||
| Barcodes | ||
| ClassSortRoutine | ||
| ClassSplitRoutine | ||
| Creators | ||
| External | ||
| Form | ||
| Heading | ||
| ILSDI | ||
| Installer | ||
| Labels | ||
| Linker | ||
| Members | ||
| OAI | ||
| Output | ||
| Patroncards | ||
| Reports | ||
| Search | ||
| Serials | ||
| SIP | ||
| Utils | ||
| Accounts.pm | ||
| Acquisition.pm | ||
| Auth.pm | ||
| Auth_cas_servers.yaml.sample | ||
| Auth_with_cas.pm | ||
| Auth_with_ldap.pm | ||
| Auth_with_shibboleth.pm | ||
| AuthoritiesMarc.pm | ||
| Barcodes.pm | ||
| Biblio.pm | ||
| Breeding.pm | ||
| Budgets.pm | ||
| Calendar.pm | ||
| Charset.pm | ||
| Circulation.pm | ||
| ClassSortRoutine.pm | ||
| ClassSource.pm | ||
| ClassSplitRoutine.pm | ||
| Context.pm | ||
| Contract.pm | ||
| CourseReserves.pm | ||
| Creators.pm | ||
| Heading.pm | ||
| HoldsQueue.pm | ||
| HTML5Media.pm | ||
| ImportBatch.pm | ||
| ImportExportFramework.pm | ||
| InstallAuth.pm | ||
| Installer.pm | ||
| ItemCirculationAlertPreference.pm | ||
| Items.pm | ||
| Koha.pm | ||
| Labels.pm | ||
| Languages.pm | ||
| Letters.pm | ||
| Linker.pm | ||
| Log.pm | ||
| MarcModificationTemplates.pm | ||
| Matcher.pm | ||
| Members.pm | ||
| Message.pm | ||
| Output.pm | ||
| Overdues.pm | ||
| Patroncards.pm | ||
| Record.pm | ||
| Reports.pm | ||
| Reserves.pm | ||
| Ris.pm | ||
| RotatingCollections.pm | ||
| Scheduler.pm | ||
| Scrubber.pm | ||
| Search.pm | ||
| Serials.pm | ||
| Service.pm | ||
| ShelfBrowser.pm | ||
| SMS.pm | ||
| SocialData.pm | ||
| Stats.pm | ||
| Suggestions.pm | ||
| Tags.pm | ||
| Templates.pm | ||
| TmplToken.pm | ||
| TmplTokenType.pm | ||
| TTParser.pm | ||
| UsageStats.pm | ||
| XISBN.pm | ||
| XSLT.pm | ||