Nick Clemens d7afd1ca30 Bug 30324: Don't use default rule if we have a parent rule ... Currenty, if we find only a defult rule for a checkout we are ignoring the parent rule. We should not use the default if there is a parent rule To test: 1: have an itype BK 2: create an itype BK2, set BK as the parent to BK2 3: create a circ rule for All Patrons, item type BK (displays as "Books (All)" in the circ rules interface), setting total checkouts to 1 4: do not create any rule specifically for the BK2 itype 5: have some BK items and some BK2 items 6: check a BK item out to a patron 7: check a BK2 item out to the same patron, observe you are not blocked from doing so 8: try to check out a second BK2 item to the same patron, get message "Too many checked out. 1 checked out, only 1 are allowed." 9: try to check out a second BK item to the same patrons, get message "Too many checked out. 2 checked out, only 1 are allowed." 10: return both items 11: check a BK2 item out to your patron 12: try to check a BK item out to your patron, get message "Too many checked out. 1 checked out, only 1 are allowed." 13: Apply patch 14: Repeat 7, you are now blocked 15: Other results should be the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>		2024-04-29 09:35:32 +02:00
..
AuthoritiesMarc
Barcodes	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
ClassSortRoutine
ClassSplitRoutine
Creators	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
External
Form	Bug 30318: Don't reset messaging preferences when form is empty	2024-04-26 08:52:51 +02:00
Heading	Bug 21828: build $bib_heading_fields only once per invocation	2023-09-22 12:57:46 -03:00
ILSDI	Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron	2024-02-02 17:31:46 +01:00
Installer
Labels	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
Linker	Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch	2022-10-03 10:00:04 -03:00
Members	Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name	2023-10-11 10:31:46 -03:00
OAI
Output
Patroncards	Bug 34532: Silence warns in Patroncard.pm	2023-09-15 11:57:08 -03:00
Reports	Bug 35746: add multiselect to report dropdowns	2024-04-26 18:06:19 +02:00
Search	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
Serials
SIP	Bug 36386: Pass user and group to Net::Server	2024-04-18 16:51:16 +02:00
Utils/DataTables	Bug 34913: Fix perlcritic for VirtualShelves.pm	2024-01-29 12:24:54 +01:00
Accounts.pm	Bug 29184: Fix warn about undefined replacecost	2022-09-08 10:50:30 -07:00
Acquisition.pm	Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template	2023-10-20 16:31:15 -03:00
Auth.pm	Bug 23102: 404 errors on page causes SCI user to be logged out	2024-04-12 12:12:30 +02:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm	Bug 34893: (QA follow-up) Tidy code for qa script	2024-02-02 17:31:47 +01:00
Auth_with_ldap.pm	Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron	2024-02-02 17:31:46 +01:00
Auth_with_shibboleth.pm	Bug 34893: ILS-DI can return the wrong patron for AuthenticatePatron	2024-02-02 17:31:46 +01:00
AuthoritiesMarc.pm	Bug 29522: [alternate] Skip relinking bibliographic records when merging authorities	2024-03-15 15:39:15 +01:00
Barcodes.pm
Biblio.pm	Bug 31791: (follow-up) Tidy AddBiblio	2024-04-26 20:15:39 +02:00
Breeding.pm	Bug 28166: (QA follow-up) Fix and tidy tests and code	2023-10-23 11:33:50 -03:00
Budgets.pm	Bug 31631: Optionally use tax-exclusive values for calculating fund values	2023-10-18 15:41:35 -03:00
Calendar.pm	Bug 32048: Added clear cache routine to delete_holiday_range_repeatable	2023-09-18 15:31:50 -03:00
Charset.pm
Circulation.pm	Bug 30324: Don't use default rule if we have a parent rule	2024-04-29 09:35:32 +02:00
ClassSortRoutine.pm
ClassSource.pm
ClassSplitRoutine.pm
Context.pm	Bug 33431: Make C4::Circulation use C4::Context->yaml_preference	2024-03-18 11:03:37 +01:00
Contract.pm
CourseReserves.pm	Bug 30016: Remove GetOpenIssue subroutine	2022-08-31 08:50:37 -03:00
Creators.pm
Heading.pm	Bug 33557: Add LinkerConsiderThesaurus system preference	2023-05-10 15:26:26 -03:00
HoldsQueue.pm	Bug 35826: Make copy of cost matrix when substituting inf	2024-04-26 18:06:18 +02:00
HTML5Media.pm
ImportBatch.pm	Bug 35438: Remove skip_intermediate_commit parameter	2024-01-16 12:06:08 +01:00
ImportExportFramework.pm
InstallAuth.pm	Bug 36102: Fix expired session on the login page of the installer (?)	2024-03-01 11:00:35 +01:00
Installer.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-06 12:24:12 -03:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 32029: Automatic item modifications by age add biblio table	2024-01-26 15:13:50 +01:00
Koha.pm	Bug 35833: Fix warnings from C4/Koha	2024-01-29 12:24:58 +01:00
Labels.pm
Languages.pm	Bug 32775: (QA follow-up) Fix tab and indenting issues	2023-05-15 18:23:54 -03:00
Letters.pm	Bug 35581: Koha::Illrequest -> Koha::ILL::Request	2024-04-22 08:57:45 +02:00
Linker.pm
Log.pm	Bug 32057: (QA follow-up) Remove pretty flag	2023-03-14 08:49:34 -03:00
MarcModificationTemplates.pm
Matcher.pm	Bug 26611: Make authority record matching use required match checks	2023-05-24 11:21:31 -03:00
Members.pm	Bug 26170: Add protected status for patrons	2023-11-01 17:23:06 -03:00
Message.pm	Bug 18398: (follow-up) Update POD & Unit tests	2023-03-31 13:13:35 +02:00
Output.pm	Bug 34478: Remove check_csrf from pl files	2024-03-01 10:56:01 +01:00
Overdues.pm	Bug 34279: Don't enforce overduefinescap unless it is greater than 0	2023-07-19 13:00:41 -03:00
Patroncards.pm
Record.pm	Bug 33431: Make C4::Record use C4::Context->yaml_preference	2024-03-18 11:03:38 +01:00
Reports.pm
Reserves.pm	Bug 35491: Add logging to RevertWaitingStatus	2023-12-19 13:42:13 +01:00
Ris.pm	Bug 33431: Fix remaining cases	2024-03-18 11:03:39 +01:00
RotatingCollections.pm	Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines	2023-05-12 12:40:21 -03:00
Scheduler.pm
Scrubber.pm	Bug 36328: (QA follow-up) Expand tests and reorder elements to clarify differences	2024-04-22 12:39:20 +02:00
Search.pm	Bug 35833: Silence few warnings from searching	2024-01-29 12:24:58 +01:00
Serials.pm	Bug 31846: (QA follow-up) Tidy code to make qa script happy	2023-10-25 10:35:28 -03:00
Service.pm
ShelfBrowser.pm
SMS.pm	Bug 36051: (QA follow-up): Use yaml_preference	2024-04-12 11:26:12 +02:00
SocialData.pm	Bug 33833: Add two FIXMEs to SocialData::get_report	2023-09-05 14:35:35 -03:00
Stats.pm	Bug 33608: (QA follow-up) Remove ->insert method	2023-10-25 11:07:59 -03:00
Suggestions.pm	Bug 33236: (follow-up) Remove export of NewSuggestion	2023-06-06 10:08:36 -03:00
Tags.pm	Bug 31517: (QA follow-up) Fix indentation	2022-11-04 19:30:56 -03:00
Templates.pm	Bug 35070: Tidy	2024-01-04 16:51:45 +01:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm	Bug 33961: Remove built-in offline circ tool	2023-06-12 16:53:25 -03:00
XISBN.pm
XSLT.pm	Bug 33217: Tidy	2023-11-08 17:52:42 -03:00