Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Nick Clemens 8ceba54c8d Bug 21742: Fix YouTube variable propagation 
The loop to find all media has an $isyoutube variable. This was declared
outside the loop and never reset. Once a YouTube video was encountered
all subsequent videos were considered as YouTube. This patch reduces the
scope of the variable and resets per loop.

To test:
1 - Enable HTML5Media and HTML5MediaYouTube
2 - Add 856$u to record for a youtube vido and a pdf (sample record
        attached to bug)
3 - View the record, the Play media tab has two video boxes
4 - Play the second, it fails
5 - Apply patch
6 - View record, Play media should include only one video link

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-01 18:59:33 +00:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
Creators Bug 15766: Fix incorrect GROUP BY 2018-10-24 17:15:36 +00:00
External Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting 2018-10-02 00:03:03 +00:00
Form
Heading
ILSDI Bug 21681: Improve the account lines fetch 2018-10-31 13:52:08 +00:00
Installer Bug 18959: Text::CSV::Unicode missing from dependencies 2018-10-19 16:37:21 +00:00
Labels
Linker
Members Bug 20444: Remove sub GetAttributes 2018-05-03 13:26:49 -03:00
OAI
Output
Patroncards Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts 2018-07-12 12:39:34 +00:00
Reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
Search
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
SIP Bug 21486: Only fetch the items' barcodes 2018-10-24 12:40:18 +00:00
Utils Bug 20455: Fix sort patrons by date expired 2018-03-28 15:25:46 -03:00
Accounts.pm Bug 21681: Remove C4::Accounts::getcharges 2018-10-31 13:52:07 +00:00
Acquisition.pm Bug 18720: Use exception instead of die in GetBasketAsCsv 2018-10-31 13:47:17 +00:00
Auth.pm Bug 11897: 'superlibrarian' has 'stockrotation' perms 2018-10-09 15:46:07 +00:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 19160: Add POD 2018-03-23 11:45:38 -03:00
Auth_with_ldap.pm Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
Auth_with_shibboleth.pm Bug 19625: Enable Shibboleth auto-provisioning for Plack 2018-10-09 15:02:50 +00:00
AuthoritiesMarc.pm Bug 21581: (QA follow-up) Update comment according to code in SearchAuthorities 2018-10-31 13:17:48 +00:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio 2018-10-15 13:11:53 +00:00
Bookseller.pm
Boolean.pm
Breeding.pm Bug 12747: (QA follow-up) Treat 010 according to marcflavour 2018-10-01 13:56:26 +00:00
Budgets.pm Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY 2018-10-18 14:17:49 +00:00
Calendar.pm
Charset.pm
Circulation.pm Bug 13098: Make _FixAccountForLostAndReturned refund the right thing 2018-10-31 13:13:37 +00:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Bug 14302: (follow-up) Remove traces in C4::Search and C4::Context 2018-08-31 11:24:22 +00:00
Contract.pm
CourseReserves.pm Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
Creators.pm
Debug.pm
Heading.pm
HoldsQueue.pm
HTML5Media.pm Bug 21742: Fix YouTube variable propagation 2018-11-01 18:59:33 +00:00
Images.pm
ImportBatch.pm Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls 2018-08-30 13:40:35 +00:00
ImportExportFramework.pm
InstallAuth.pm Bug 21137: Replace USER_INFO with logged_in_user 2018-08-14 12:43:10 +00:00
Installer.pm Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process 2018-10-26 17:09:59 +00:00
ItemCirculationAlertPreference.pm
Items.pm Bug 20592: Return early in ModItem if nothing to update 2018-10-19 17:27:36 +00:00
Koha.pm Bug 18322: Add a facet for ccode fields to Zebra 2018-07-18 17:42:48 +00:00
Labels.pm
Languages.pm Bug 20115: Set the languages order with the pref values 2018-04-04 15:45:43 -03:00
Letters.pm Bug 15971: Add biblioitems to available fields for serial claim notices and fix notices editor display 2018-10-01 13:56:34 +00:00
Linker.pm
Log.pm
MarcModificationTemplates.pm Bug 13560: Add an 'Add' option for marc modification templates 2018-07-19 17:22:18 +00:00
Matcher.pm Bug 18584: Removed white space in C4/Matcher.pm 2018-10-03 17:50:17 +00:00
Members.pm Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
Message.pm Bug 19743: Update header and footer on each item for checkin / checkout / renewal notices 2018-08-14 11:55:07 +00:00
NewsChannels.pm
Output.pm Bug 20661: (QA follow-up) Add POD for output_and_exit 2018-08-10 12:23:03 +00:00
Overdues.pm Bug 21196: Use replacement cost from the item type if not set at item level 2018-09-26 16:00:30 +00:00
Patroncards.pm
Print.pm
Record.pm Bug 20272: Changes for Breeding.pm and Record.pm 2018-07-02 12:12:49 +00:00
Reports.pm
Reserves.pm Bug 15486: (follow-up) Default to unlimited 2018-10-24 13:24:06 +00:00
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 20151: always use current language for stemming 2018-10-09 15:02:47 +00:00
Serials.pm Bug 20351: Shortcut serials scripts if a blocking error appeared 2018-10-17 14:25:30 +00:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
Stats.pm Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
Suggestions.pm Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan 2018-02-26 13:24:45 -03:00
Tags.pm
Templates.pm Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
XISBN.pm Bug 21235: Remove table services_throttle 2018-09-07 15:09:39 +00:00
XSLT.pm