38503e18a3
This patch improves the public catalog MARC view display of records that contain subfields that are not defined in the framework used by the bib record. To test: (RM note: it may be easier to find or create a MARC record that contains a subfield not present in the default framework, then load it, rather than fiddle with the MARC frameworks in your test database.) BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the staff client URL similar to: /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page where ##### is the biblionumber. 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Clear your opac error log. 15) Refresh OPAC tab. The tag subfields are split. 16) There are opac-MARCdetail.pl warnings. 17) Apply patch 18) Clear your opac error log. 19) Refresh OPAC tab. The tag subfields are no longer split strangely. 20) There are no opac-MARCdetail.pl warnings. RESTORE YOUR DATABASE. This also silences a series of warnings triggered by catching undef hash references. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
353 lines
12 KiB
Perl
Executable file
353 lines
12 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright (C) 2000-2002 Katipo Communications
|
|
# Parts Copyright (C) 2010 BibLibre
|
|
# Parts Copyright (C) 2013 Mark Tompsett
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
=head1 NAME
|
|
|
|
opac-MARCdetail.pl : script to show a biblio in MARC format
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
=cut
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This script needs a biblionumber as parameter
|
|
|
|
It shows the biblio in a (nice) MARC format depending on MARC
|
|
parameters tables.
|
|
|
|
The template is in <templates_dir>/catalogue/MARCdetail.tmpl.
|
|
this template must be divided into 11 "tabs".
|
|
|
|
The first 10 tabs present the biblio, the 11th one presents
|
|
the items attached to the biblio
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use CGI;
|
|
use MARC::Record;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Acquisition;
|
|
use C4::Koha;
|
|
use List::MoreUtils qw/any/;
|
|
|
|
my $query = new CGI;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $biblionumber = $query->param('biblionumber');
|
|
if ( ! $biblionumber ) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
|
|
my @all_items = GetItemsInfo($biblionumber);
|
|
my @items2hide;
|
|
if (scalar @all_items >= 1) {
|
|
push @items2hide, GetHiddenItemnumbers(@all_items);
|
|
|
|
if (scalar @items2hide == scalar @all_items ) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
}
|
|
|
|
my $itemtype = &GetFrameworkCode($biblionumber);
|
|
my $tagslib = &GetMarcStructure( 0, $itemtype );
|
|
my ($tag_itemnumber,$subtag_itemnumber) = &GetMarcFromKohaField('items.itemnumber',$itemtype);
|
|
my $biblio = GetBiblioData($biblionumber);
|
|
$biblionumber = $biblio->{biblionumber};
|
|
my $record = GetMarcBiblio($biblionumber, 1);
|
|
if ( ! $record ) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
# open template
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-MARCdetail.tmpl",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
$template->param(
|
|
bibliotitle => $biblio->{title},
|
|
);
|
|
|
|
# get biblionumbers stored in the cart
|
|
my @cart_list;
|
|
|
|
if($query->cookie("bib_list")){
|
|
my $cart_list = $query->cookie("bib_list");
|
|
@cart_list = split(/\//, $cart_list);
|
|
if ( grep {$_ eq $biblionumber} @cart_list) {
|
|
$template->param( incart => 1 );
|
|
}
|
|
}
|
|
|
|
$template->param( 'AllowOnShelfHolds' => C4::Context->preference('AllowOnShelfHolds') );
|
|
$template->param( 'ItemsIssued' => CountItemsIssued( $biblionumber ) );
|
|
|
|
# adding the $RequestOnOpac param
|
|
my $RequestOnOpac;
|
|
if (C4::Context->preference("RequestOnOpac")) {
|
|
$RequestOnOpac = 1;
|
|
}
|
|
|
|
# fill arrays
|
|
my @loop_data = ();
|
|
my $tag;
|
|
|
|
# loop through each tab 0 through 9
|
|
for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) {
|
|
|
|
# loop through each tag
|
|
my @loop_data = ();
|
|
my @subfields_data;
|
|
|
|
# deal with leader
|
|
unless ( $tagslib->{'000'}->{'@'}->{tab} ne $tabloop
|
|
or $tagslib->{'000'}->{'@'}->{hidden} > 0 )
|
|
{
|
|
my %subfield_data;
|
|
$subfield_data{marc_lib} = $tagslib->{'000'}->{'@'}->{lib};
|
|
$subfield_data{marc_value} = $record->leader();
|
|
$subfield_data{marc_subfield} = '@';
|
|
$subfield_data{marc_tag} = '000';
|
|
push( @subfields_data, \%subfield_data );
|
|
my %tag_data;
|
|
$tag_data{tag} = '000 -' . $tagslib->{'000'}->{lib};
|
|
my @tmp = @subfields_data;
|
|
$tag_data{subfield} = \@tmp;
|
|
push( @loop_data, \%tag_data );
|
|
undef @subfields_data;
|
|
}
|
|
my @fields = $record->fields();
|
|
for ( my $x_i = 0 ; $x_i <= $#fields ; $x_i++ ) {
|
|
|
|
# if tag <10, there's no subfield, use the "@" trick
|
|
if ( $fields[$x_i]->tag() < 10 ) {
|
|
next
|
|
if (
|
|
$tagslib->{ $fields[$x_i]->tag() }->{'@'}->{tab} ne $tabloop );
|
|
next if ( $tagslib->{ $fields[$x_i]->tag() }->{'@'}->{hidden} > 0 );
|
|
my %subfield_data;
|
|
$subfield_data{marc_lib} =
|
|
$tagslib->{ $fields[$x_i]->tag() }->{'@'}->{lib};
|
|
$subfield_data{marc_value} = $fields[$x_i]->data();
|
|
$subfield_data{marc_subfield} = '@';
|
|
$subfield_data{marc_tag} = $fields[$x_i]->tag();
|
|
push( @subfields_data, \%subfield_data );
|
|
}
|
|
else {
|
|
my @subf = $fields[$x_i]->subfields;
|
|
my $previous = '';
|
|
# loop through each subfield
|
|
for my $i ( 0 .. $#subf ) {
|
|
$subf[$i][0] = "@" unless defined($subf[$i][0]);
|
|
my $sf_def = $tagslib->{ $fields[$x_i]->tag() };
|
|
$sf_def = $sf_def->{ $subf[$i][0] } if defined($sf_def);
|
|
my ($tab,$hidden,$lib);
|
|
$tab = $sf_def->{tab} if defined($sf_def);
|
|
$tab = $tab // int($fields[$x_i]->tag()/100);
|
|
$hidden = $sf_def->{hidden} if defined($sf_def);
|
|
$hidden = $hidden // 0;
|
|
next if ( $tab != $tabloop );
|
|
next if ( $hidden > 0 );
|
|
my %subfield_data;
|
|
$lib = $sf_def->{lib} if defined($sf_def);
|
|
$lib = $lib // '--';
|
|
$subfield_data{marc_lib} = ($lib eq $previous) ? '--' : $lib;
|
|
$previous = $lib;
|
|
$subfield_data{link} = $sf_def->{link};
|
|
$subf[$i][1] =~ s/\n/<br\/>/g;
|
|
if ( $sf_def->{isurl} ) {
|
|
$subfield_data{marc_value} = "<a href=\"$subf[$i][1]\">$subf[$i][1]</a>";
|
|
}
|
|
elsif ( defined($sf_def->{kohafield}) && $sf_def->{kohafield} eq "biblioitems.isbn" ) {
|
|
$subfield_data{marc_value} = $subf[$i][1];
|
|
}
|
|
else {
|
|
if ( $sf_def->{authtypecode} ) {
|
|
$subfield_data{authority} = $fields[$x_i]->subfield(9);
|
|
}
|
|
$subfield_data{marc_value} = GetAuthorisedValueDesc( $fields[$x_i]->tag(),
|
|
$subf[$i][0], $subf[$i][1], '', $tagslib, '', 'opac' );
|
|
}
|
|
$subfield_data{marc_subfield} = $subf[$i][0];
|
|
$subfield_data{marc_tag} = $fields[$x_i]->tag();
|
|
push( @subfields_data, \%subfield_data );
|
|
}
|
|
}
|
|
if ( $#subfields_data >= 0 ) {
|
|
my %tag_data;
|
|
if ( ( $fields[$x_i]->tag() eq $fields[ $x_i - 1 ]->tag() )
|
|
&& ( C4::Context->preference('LabelMARCView') eq 'economical' )
|
|
)
|
|
{
|
|
$tag_data{tag} = "";
|
|
}
|
|
else {
|
|
if ( C4::Context->preference('hide_marc') ) {
|
|
$tag_data{tag} = $tagslib->{ $fields[$x_i]->tag() }->{lib};
|
|
}
|
|
else {
|
|
my $sf_def = $tagslib->{ $fields[$x_i]->tag() };
|
|
my $lib;
|
|
$lib = $sf_def->{lib} if defined($sf_def);
|
|
$lib = $lib // '';
|
|
$tag_data{tag} = $fields[$x_i]->tag() . ' '
|
|
. C4::Koha::display_marc_indicators($fields[$x_i])
|
|
. " - $lib";
|
|
}
|
|
}
|
|
my @tmp = @subfields_data;
|
|
$tag_data{subfield} = \@tmp;
|
|
push( @loop_data, \%tag_data );
|
|
undef @subfields_data;
|
|
}
|
|
}
|
|
$template->param( "tab" . $tabloop . "XX" => \@loop_data );
|
|
}
|
|
|
|
|
|
# now, build item tab !
|
|
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
|
|
# loop through each tag
|
|
# warning : we may have differents number of columns in each row. Thus, we first build a hash, complete it if necessary
|
|
# then construct template.
|
|
my @fields = $record->fields();
|
|
my %witness
|
|
; #---- stores the list of subfields used at least once, with the "meaning" of the code
|
|
my @big_array;
|
|
foreach my $field (@fields) {
|
|
next if ( $field->tag() < 10 );
|
|
next if ( ( $field->tag() eq $tag_itemnumber ) &&
|
|
( any { $field->subfield($subtag_itemnumber) eq $_ }
|
|
@items2hide) );
|
|
my @subf = $field->subfields;
|
|
my %this_row;
|
|
|
|
# loop through each subfield
|
|
for my $i ( 0 .. $#subf ) {
|
|
my $sf_def = $tagslib->{ $field->tag() }->{ $subf[$i][0] };
|
|
next if ( ($sf_def->{tab}||0) != 10 );
|
|
next if ( ($sf_def->{hidden}||0) > 0 );
|
|
$witness{ $subf[$i][0] } = $sf_def->{lib};
|
|
|
|
if ( $sf_def->{isurl} ) {
|
|
$this_row{ $subf[$i][0] } = "<a href=\"$subf[$i][1]\">$subf[$i][1]</a>";
|
|
}
|
|
elsif ( $sf_def->{kohafield} eq "biblioitems.isbn" ) {
|
|
$this_row{ $subf[$i][0] } = $subf[$i][1];
|
|
}
|
|
else {
|
|
$this_row{ $subf[$i][0] } = GetAuthorisedValueDesc( $field->tag(), $subf[$i][0],
|
|
$subf[$i][1], '', $tagslib, '', 'opac' );
|
|
}
|
|
}
|
|
if (%this_row) {
|
|
push( @big_array, \%this_row );
|
|
}
|
|
}
|
|
my ( $holdingbrtagf, $holdingbrtagsubf ) =
|
|
&GetMarcFromKohaField( "items.holdingbranch", $itemtype );
|
|
@big_array =
|
|
sort { ($a->{$holdingbrtagsubf}||'') cmp ($b->{$holdingbrtagsubf}||'') } @big_array;
|
|
|
|
#fill big_row with missing datas
|
|
foreach my $subfield_code ( keys(%witness) ) {
|
|
for ( my $i = 0 ; $i <= $#big_array ; $i++ ) {
|
|
$big_array[$i]{$subfield_code} = " "
|
|
unless ( $big_array[$i]{$subfield_code} );
|
|
}
|
|
}
|
|
|
|
# now, construct template !
|
|
my @item_value_loop;
|
|
my @header_value_loop;
|
|
for ( my $i = 0 ; $i <= $#big_array ; $i++ ) {
|
|
my $items_data;
|
|
foreach my $subfield_code ( keys(%witness) ) {
|
|
$items_data .= "<td>" . $big_array[$i]{$subfield_code} . "</td>";
|
|
}
|
|
my %row_data;
|
|
$row_data{item_value} = $items_data;
|
|
push( @item_value_loop, \%row_data );
|
|
}
|
|
|
|
foreach my $subfield_code ( keys(%witness) ) {
|
|
my %header_value;
|
|
$header_value{header_value} = $witness{$subfield_code};
|
|
push( @header_value_loop, \%header_value );
|
|
}
|
|
|
|
if(C4::Context->preference("ISBD")) {
|
|
$template->param(ISBD => 1);
|
|
}
|
|
|
|
#Export options
|
|
my $OpacExportOptions=C4::Context->preference("OpacExportOptions");
|
|
my @export_options = split(/\|/,$OpacExportOptions);
|
|
$template->{VARS}->{'export_options'} = \@export_options;
|
|
|
|
#Search for title in links
|
|
my $marcflavour = C4::Context->preference("marcflavour");
|
|
my $dat = TransformMarcToKoha( $dbh, $record );
|
|
my $isbn = GetNormalizedISBN(undef,$record,$marcflavour);
|
|
my $marccontrolnumber = GetMarcControlnumber ($record, $marcflavour);
|
|
my $marcissns = GetMarcISSN( $record, $marcflavour );
|
|
my $issn = $marcissns->[0] || '';
|
|
|
|
if (my $search_for_title = C4::Context->preference('OPACSearchForTitleIn')){
|
|
$dat->{title} =~ s/\/+$//; # remove trailing slash
|
|
$dat->{title} =~ s/\s+$//; # remove trailing space
|
|
$search_for_title = parametrized_url(
|
|
$search_for_title,
|
|
{
|
|
TITLE => $dat->{title},
|
|
AUTHOR => $dat->{author},
|
|
ISBN => $isbn,
|
|
ISSN => $issn,
|
|
CONTROLNUMBER => $marccontrolnumber,
|
|
BIBLIONUMBER => $biblionumber,
|
|
}
|
|
);
|
|
$template->param('OPACSearchForTitleIn' => $search_for_title);
|
|
}
|
|
|
|
$template->param(
|
|
item_loop => \@item_value_loop,
|
|
item_header_loop => \@header_value_loop,
|
|
biblionumber => $biblionumber,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|