Koha-community/Koha: Main Koha release repository - Koha - Koha: The world's first free and open source library system

Main Koha release repository https://koha-community.org

History

Jonathan Druart 40096821f3 Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. == Test plan == 1. Add some content to HOLD_SLIP notice, e.g. <h2>[% branch.branchname %]</h2> <div>[% biblio.author %]<br>[% biblio.title %]<br>[% item.barcode %] <ul><li> Reserve ID: [% hold.reserve_id %]</li> <li>Expiration date: [% hold.expirationdate %]</li></ul> 2. Add 2 holds for 1 patron to a single record 3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2 4. Check in one of the items from the record and print the slip 5. Note that the reserve ID on the slip is 2 and the expiration date is blank 6. Repeated check ins do not change this 7. Check in a second item from the record 8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in 9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in 10. Apply patch 11. cancel the holds to come back to a clean state (and maybe ensure items aren't in transit) 12. redo the test and see the following differences 13. 1st checkin: 1. expiration date ok 2. the reserve ID is the one of the first hold 14. 2nd checkin: 1. expiration date ok 2. the reserve ID is the one of the second hold Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (cherry picked from commit `d864c5640a`) Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>		4 years ago
..
add_message.pl	Bug 18403: Update permissions - borrowers => 1\|* becomes borrowers => 'edit_borrowers'	6 years ago
article-request-slip.pl	Bug 20851: Add module to circ/article-request-slip.pl	6 years ago
article-requests.pl	Bug 14610 - Add and update scripts	8 years ago
bookcount.pl	Bug 20661: Shortcut circ scripts if a blocking error appeared	6 years ago
branchoverdues.pl	Bug 11529: Use new biblio fields whenever possible	5 years ago
branchtransfers.pl	Bug 24839: Return hold info to transfer script and set borrowernumber	4 years ago
checkout-notes.pl	Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage	5 years ago
circulation-home.pl	Bug 17698: (follow-up) Fixing things in Comment 57	6 years ago
circulation.pl	Bug 24612: Make hold-transfer-slip take reserve_id	4 years ago
del_message.pl	Bug 18403: Update permissions - borrowers => 1\|* becomes borrowers => 'edit_borrowers'	6 years ago
hold-transfer-slip.pl	Bug 24612: Make hold-transfer-slip take reserve_id	4 years ago
offline-mf.pl	Bug 11944: use CGI( -utf8 ) everywhere	9 years ago
offline.pl	Bug 11944: use CGI( -utf8 ) everywhere	9 years ago
on-site_checkouts.pl	Bug 17698: Do not send pending_checkout_notes from all circ scripts	6 years ago
overdue.pl	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	4 years ago
pendingreserves.pl	Bug 23484: (follow-up) add parenthesis in JOIN	5 years ago
renew.pl	Bug 23551: Fix AddRenewal call in circ/renew.pl	5 years ago
request-article.pl	Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar	6 years ago
reserveratios.pl	Bug 15422: Consider partial copies needed as whole numbers	5 years ago
returns.pl	Bug 24612: Make hold-transfer-slip take reserve_id	4 years ago
selectbranchprinter.pl	Bug 21056: Add another flush later	6 years ago
transfer-slip.pl	Bug 19997: use Modern::Perl in Circulation perl scripts	6 years ago
transferstoreceive.pl	Bug 11529: Add templates for biblio title display. Unify display.	5 years ago
view_holdsqueue.pl	Bug 17698: Do not send pending_checkout_notes from all circ scripts	6 years ago
waitingreserves.pl	Bug 21628: Simplify holds awating pickup report	6 years ago
ypattrodue-attr-search-authvalue.pl	Bug 19997: use Modern::Perl in Circulation perl scripts	6 years ago
ysearch.pl	Bug 24750: Instructor Search Results	4 years ago