Koha/reserve
Jonathan Druart 45852c950e
Bug 30860: Cache CanItemBeReserved return value
This patch caches the return value of CanItemBeReserved that could
be then returned *on
demand*
We don't want to introduce side-effects hard to catch from this simple
change, so let's return the cache value only from the 2 scripts we are
dealing with.

This patch requests all item values from CanBookBeReserved on request.pl

Before this we either:
- Looped every item to find out that book could not be reserved
- Looped until we found an item that could be reserved, then looped all items to get statuses

In the worst case we avoid double processing a single item, in the best case we avoid double
processing all items (if only last on record is holdable)

To test:
1 - Find a record in staff client with several items
2 - Set AllowHoldsOnDamagedItems  to 'Dont allow'
3 - Add a damaged item to record
4 - Set a hold rule to only allow holds form homebranch and ensure record has items from other branches
5 - Setup things to prevent more items from being held
6 - Attempt hold for patron
7 - Note item statuses
8 - Apply patch
9 - Confirm statuses are as they were before

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-06-23 10:01:07 -03:00
..
modrequest.pl Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
modrequest_suspendall.pl Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
placerequest.pl Bug 24860: Add ability to select an item group when placing a hold 2022-11-04 19:39:55 -03:00
request.pl Bug 30860: Cache CanItemBeReserved return value 2023-06-23 10:01:07 -03:00