Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Mark Tompsett 78d6d794fe Bug 10900 - Incorrect calling conventions accessing C4::Context 
There were multiple calling conventions for C4::Context's
set_userenv routine. So the following commands were used to
find discrepancies:
    grep "::set_userenv" `find .`
    grep "\->set_userenv" `find .`

The first grep demonstrated that the smaller change is from
:: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and
t/db_dependent/Circulation.t would need to be modified. This
patch corrects C4::Context's set_userenv routine to be object
call based (use ->) by using a shift to ignore the first
parameter, and modify the three files found with :: calls.

As the result of trying to roll a distribution,
t/Circulation_barcodedecode.t was discovered to be faulty. The
cause being incorrect parameters! This was hidden when there
was no shift in the set_userenv routine. However, with its
correction, the test broke.

This led me to read the POD documentation for the function
set_userenv in C4::Context and realize it was outdated as
well. It has been revised to match the current version of
the function.

Then intentionally bad parameters passed to the set_userenv
routine in C4::Context were hunted down. The biggest problems
were missing surnames or branch names.

Rebase required because of shibboleth change in C4/Context.pm

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-02-09 17:00:13 -03:00
..
Acquisition Bug 13333: Fix Display basket group for already received orders 2015-02-05 14:51:34 -03:00
Circulation Bug 13297 - Shelving location PROC does not work according to manual 2014-11-23 10:11:28 -03:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
Holds Bug 11126: (RM followup) remove diags from tests 2014-11-04 18:59:42 -03:00
Koha Bug 11425: Add unit tests 2014-11-04 19:10:28 -03:00
Labels
LDAP
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 12457: Allow UT on a non empty database 2014-07-30 09:50:35 -03:00
Record
Reports
Search
Serials Bug 12896: (QA followup) use C4::Bookseller in t/db_dependent/Serials/Claims.t 2015-01-04 10:54:46 -03:00
Utils Bug 12833: Patron search should search on extended attributes 2014-09-09 10:08:59 -03:00
www Bug 13579: Prefer like instead of ok to match a regex 2015-01-14 12:24:29 -03:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t
Accounts.t
Acquisition.t Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller 2014-12-31 14:15:58 -03:00
Amazon.t
Auth.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Auth_with_cas.t Bug 12398: (followup) tidy unit tests 2014-08-01 10:13:45 -03:00
Auth_with_ldap.t Bug 12831: (RM followup) regression test 2014-11-27 14:45:11 -03:00
AuthoritiesMarc.t Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary() 2014-05-05 04:18:22 +00:00
BackgroundJob.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
Barcodes.t
Biblio.t Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN 2014-09-01 10:42:08 -03:00
Bookseller.t Bug 12896: Remove 2 occurrences in comments 2014-12-31 14:16:05 -03:00
Borrower_Debarments.t
Borrower_Files.t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-11 16:16:11 -03:00
Branch.t Bug 9530: Follow-up - Fix t/db_dependent/Branch.t 2014-10-28 09:26:03 -03:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 12958: Set a fund owner to a fund hierarchy 2014-10-31 16:18:49 -03:00
Category.t
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
check_sysprefs.t
Circulation.t Bug 10900 - Incorrect calling conventions accessing C4::Context 2015-02-09 17:00:13 -03:00
Circulation_Branch.t
Circulation_issue.t
Circulation_Issuingrule.t Bug 11577 : Fixing a tiny copy/paste issue 2014-09-17 19:23:37 -03:00
Circulation_issuingrules.t
Circulation_OfflineOperation.t
Circulation_transfers.t
ClassSource.t
ColumnsSettings.t Bug 10212: Columns configuration for tables - Unit tests 2014-08-26 09:28:18 -03:00
Context.t Bug 12808: remove useless diags from t/db_dependent/Context.t 2014-08-26 10:30:53 -03:00
Contract.t Bug 12487: SQLHelper replacement - C4::Contract 2014-07-30 10:44:11 -03:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t
default_search_class.pl Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
External_BakerTaylor.t
Heading_MARC21.t
Holds.t Bug 13075: (followup) remove remaining warnings 2014-11-14 09:35:50 -03:00
HoldsQueue.t
Holidays.t Bug 13451: Holidays.t assumes default data 2014-12-17 19:24:50 -03:00
ILSDI_Services.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
ImportBatch.t Bug 11876 [Unit test] Add a diff view to staged MARC Records 2014-10-31 14:25:18 -03:00
Installer.t
Items.t Bug 13562: Fix item search on item MARC subfields 2015-02-09 10:28:09 -03:00
Items_DelItem.t Bug 12583: (followup) rename new test file 2014-07-26 10:17:09 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 13453: Koha.t daily quote tests assume sample data 2014-12-28 19:52:51 -03:00
Koha_Authority.t
Koha_borrower_modifications.t Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
Koha_Database.t
Koha_Misc_Files.t
Koha_template_plugin_Branches.t
Koha_template_plugin_KohaDates.t
Languages.t
Letters.t Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller 2014-12-31 14:15:58 -03:00
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Members.t Bug 12868: Improving t/db_dependent/Member.t 2015-01-10 16:16:51 -03:00
Members_Attributes.t
Members_columns.t
MungeMarcPrice.t
NewsChannels.t
Overdues.t Bug 9180: All branches should be returned if a default rule exists 2014-08-19 09:29:51 -03:00
PatronLists.t
Plugins.t
QueryParser.t Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
Ratings.t Bug 12609: Add some unit tests for C4::Ratings 2014-09-17 22:08:57 -03:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reports_Guided.t Bug 11672: (followup) warnings tested 2014-09-23 15:32:28 -03:00
ReportsGuided.t Bug 13141: (QA Followup) Update number of unit tests 2014-10-31 13:15:06 -03:00
Reserves.t Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. 2014-11-12 11:23:41 -03:00
rollingloans.t
RotatingCollections.t Bug 8836: (RM followup) unit tests should use the new API 2014-11-07 11:09:14 -03:00
Search.t Bug 13088: (RM followup) add missing pref mock 2014-10-28 12:07:46 -03:00
Search_SearchHistory.t
Serials.t Bug 12850: C4::Serials::GetLateIssues can be removed 2015-01-14 21:32:03 -03:00
Serials_2.t Bug 5342: Serial claiming improvements: add a counter 2014-10-28 10:07:37 -03:00
Service.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
ShelfBrowser.t
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
SQLHelper.t Bug 11425: (followup) fix number of tests 2014-11-04 19:20:34 -03:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 13007: Special case budgetid == '' 2015-02-09 15:49:57 -03:00
sysprefs.t
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 12918: fix failing test case 2014-09-15 10:53:00 -03:00
UploadedFile.t
VirtualShelves.t
VirtualShelves_Page.t
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2014-08-20 12:29:27 -03:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
zebra_config.pl Bug 12651: DOM indexing is the default 2014-10-27 12:35:44 -03:00