78d6d794fe
There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |
||
---|---|---|
.. | ||
Acquisition | ||
Circulation | ||
data | ||
Holds | ||
Koha | ||
Labels | ||
LDAP | ||
Letters | ||
Members | ||
Record | ||
Reports | ||
Search | ||
Serials | ||
Utils | ||
www | ||
XSLT_Handler | ||
00-strict.t | ||
Accounts.t | ||
Acquisition.t | ||
Amazon.t | ||
Auth.t | ||
Auth_with_cas.t | ||
Auth_with_ldap.t | ||
AuthoritiesMarc.t | ||
BackgroundJob.t | ||
Barcodes.t | ||
Biblio.t | ||
Bookseller.t | ||
Borrower_Debarments.t | ||
Borrower_Files.t | ||
Branch.t | ||
Breeding.t | ||
Budgets.t | ||
Category.t | ||
Charset.t | ||
check_sysprefs.t | ||
Circulation.t | ||
Circulation_Branch.t | ||
Circulation_issue.t | ||
Circulation_Issuingrule.t | ||
Circulation_issuingrules.t | ||
Circulation_OfflineOperation.t | ||
Circulation_transfers.t | ||
ClassSource.t | ||
ColumnsSettings.t | ||
Context.t | ||
Contract.t | ||
CourseReserves.t | ||
Csv.t | ||
default_search_class.pl | ||
External_BakerTaylor.t | ||
Heading_MARC21.t | ||
Holds.t | ||
HoldsQueue.t | ||
Holidays.t | ||
ILSDI_Services.t | ||
ImportBatch.t | ||
Installer.t | ||
Items.t | ||
Items_DelItem.t | ||
KitchenSinkPlugin.kpz | ||
Koha.t | ||
Koha_Authority.t | ||
Koha_borrower_modifications.t | ||
Koha_Database.t | ||
Koha_Misc_Files.t | ||
Koha_template_plugin_Branches.t | ||
Koha_template_plugin_KohaDates.t | ||
Languages.t | ||
Letters.t | ||
Linker_FirstMatch.t | ||
Log.t | ||
MarcModificationTemplates.t | ||
Members.t | ||
Members_Attributes.t | ||
Members_columns.t | ||
MungeMarcPrice.t | ||
NewsChannels.t | ||
Overdues.t | ||
PatronLists.t | ||
Plugins.t | ||
QueryParser.t | ||
Ratings.t | ||
Record.t | ||
RecordProcessor_EmbedSeeFromHeadings.t | ||
Reports.t | ||
Reports_Guided.t | ||
ReportsGuided.t | ||
Reserves.t | ||
rollingloans.t | ||
RotatingCollections.t | ||
Search.t | ||
Search_SearchHistory.t | ||
Serials.t | ||
Serials_2.t | ||
Service.t | ||
ShelfBrowser.t | ||
SIP_ILS.t | ||
SQLHelper.t | ||
Stats.t | ||
SuggestionEngine_ExplodedTerms.t | ||
Suggestions.t | ||
sysprefs.t | ||
Tags.t | ||
Templates.t | ||
UploadedFile.t | ||
VirtualShelves.t | ||
VirtualShelves_Page.t | ||
XISBN.t | ||
XSLT_Handler.t | ||
zebra_config.pl |