Main Koha release repository
https://koha-community.org
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
376 lines
12 KiB
376 lines
12 KiB
#!/usr/bin/perl
|
|
|
|
# Copyright 2015 Koha Development team
|
|
#
|
|
# This file is part of Koha
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 10;
|
|
|
|
use C4::Circulation;
|
|
use Koha::Checkouts;
|
|
use Koha::Database;
|
|
use Koha::DateUtils qw( dt_from_string );
|
|
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
my $library = $builder->build( { source => 'Branch' } );
|
|
my $patron = $builder->build(
|
|
{ source => 'Borrower', value => { branchcode => $library->{branchcode} } }
|
|
);
|
|
my $item_1 = $builder->build_sample_item;
|
|
my $item_2 = $builder->build_sample_item;
|
|
my $nb_of_checkouts = Koha::Checkouts->search->count;
|
|
my $new_checkout_1 = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->{borrowernumber},
|
|
itemnumber => $item_1->itemnumber,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store;
|
|
my $new_checkout_2 = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->{borrowernumber},
|
|
itemnumber => $item_2->itemnumber,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store;
|
|
|
|
like( $new_checkout_1->issue_id, qr|^\d+$|,
|
|
'Adding a new checkout should have set the issue_id' );
|
|
is(
|
|
Koha::Checkouts->search->count,
|
|
$nb_of_checkouts + 2,
|
|
'The 2 checkouts should have been added'
|
|
);
|
|
|
|
my $retrieved_checkout_1 = Koha::Checkouts->find( $new_checkout_1->issue_id );
|
|
is(
|
|
$retrieved_checkout_1->itemnumber,
|
|
$new_checkout_1->itemnumber,
|
|
'Find a checkout by id should return the correct checkout'
|
|
);
|
|
|
|
subtest 'is_overdue' => sub {
|
|
plan tests => 6;
|
|
my $ten_days_ago = dt_from_string->add( days => -10 );
|
|
my $ten_days_later = dt_from_string->add( days => 10 );
|
|
my $yesterday = dt_from_string->add( days => -1 );
|
|
my $tomorrow = dt_from_string->add( days => 1 );
|
|
|
|
$retrieved_checkout_1->date_due($ten_days_ago)->store;
|
|
is( $retrieved_checkout_1->is_overdue,
|
|
1, 'The item should have been returned 10 days ago' );
|
|
|
|
$retrieved_checkout_1->date_due($ten_days_later)->store;
|
|
is( $retrieved_checkout_1->is_overdue, 0, 'The item is due in 10 days' );
|
|
|
|
$retrieved_checkout_1->date_due($tomorrow)->store;
|
|
is( $retrieved_checkout_1->is_overdue($ten_days_later),
|
|
1, 'The item should have been returned yesterday' );
|
|
|
|
$retrieved_checkout_1->date_due($yesterday)->store;
|
|
is( $retrieved_checkout_1->is_overdue($ten_days_ago),
|
|
0, 'Ten days ago the item due yesterday was not late' );
|
|
|
|
$retrieved_checkout_1->date_due($tomorrow)->store;
|
|
is( $retrieved_checkout_1->is_overdue($ten_days_later),
|
|
1, 'In Ten days, the item due tomorrow will be late' );
|
|
|
|
$retrieved_checkout_1->date_due($yesterday)->store;
|
|
is( $retrieved_checkout_1->is_overdue($ten_days_ago),
|
|
0, 'In Ten days, the item due yesterday will still be late' );
|
|
};
|
|
|
|
subtest 'item' => sub {
|
|
plan tests => 2;
|
|
my $item = $retrieved_checkout_1->item;
|
|
is( ref($item), 'Koha::Item',
|
|
'Koha::Checkout->item should return a Koha::Item' );
|
|
is( $item->itemnumber, $item_1->itemnumber,
|
|
'Koha::Checkout->item should return the correct item' );
|
|
};
|
|
|
|
subtest 'patron' => sub {
|
|
plan tests => 3;
|
|
my $patron = $builder->build_object(
|
|
{
|
|
class => 'Koha::Patrons',
|
|
value => { branchcode => $library->{branchcode} }
|
|
}
|
|
);
|
|
|
|
my $item = $builder->build_sample_item;
|
|
my $checkout = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $item->itemnumber,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store;
|
|
|
|
my $p = $checkout->patron;
|
|
is( ref($p), 'Koha::Patron',
|
|
'Koha::Checkout->patron should return a Koha::Patron' );
|
|
is( $p->borrowernumber, $patron->borrowernumber,
|
|
'Koha::Checkout->patron should return the correct patron' );
|
|
|
|
# Testing Koha::Old::Checkout->patron now
|
|
my $issue_id = $checkout->issue_id;
|
|
C4::Circulation::MarkIssueReturned( $p->borrowernumber,
|
|
$checkout->itemnumber );
|
|
$p->delete;
|
|
my $old_issue = Koha::Old::Checkouts->find($issue_id);
|
|
is( $old_issue->patron, undef,
|
|
'Koha::Checkout->patron should return undef if the patron record has been deleted'
|
|
);
|
|
};
|
|
|
|
$retrieved_checkout_1->delete;
|
|
is(
|
|
Koha::Checkouts->search->count,
|
|
$nb_of_checkouts + 1,
|
|
'Delete should have deleted the checkout'
|
|
);
|
|
|
|
subtest 'issuer' => sub {
|
|
plan tests => 3;
|
|
my $patron = $builder->build_object(
|
|
{
|
|
class => 'Koha::Patrons',
|
|
value => { branchcode => $library->{branchcode} }
|
|
}
|
|
);
|
|
my $issuer = $builder->build_object(
|
|
{
|
|
class => 'Koha::Patrons',
|
|
value => { branchcode => $library->{branchcode} }
|
|
}
|
|
);
|
|
|
|
my $item = $builder->build_sample_item;
|
|
my $checkout = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
issuer_id => $issuer->borrowernumber,
|
|
itemnumber => $item->itemnumber,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store;
|
|
|
|
my $i = $checkout->issuer;
|
|
is( ref($i), 'Koha::Patron',
|
|
'Koha::Checkout->issuer should return a Koha::Patron' );
|
|
is( $i->borrowernumber, $issuer->borrowernumber,
|
|
'Koha::Checkout->issuer should return the correct patron' );
|
|
|
|
# Testing Koha::Old::Checkout->patron now
|
|
my $issue_id = $checkout->issue_id;
|
|
C4::Circulation::MarkIssueReturned( $patron->borrowernumber,
|
|
$checkout->itemnumber );
|
|
$i->delete;
|
|
my $old_issue = Koha::Old::Checkouts->find($issue_id);
|
|
is( $old_issue->issuer_id, undef,
|
|
'Koha::Checkout->issuer_id should return undef if the patron record has been deleted'
|
|
);
|
|
|
|
};
|
|
|
|
subtest 'Koha::Old::Checkouts->filter_by_todays_checkins' => sub {
|
|
|
|
plan tests => 3;
|
|
|
|
# We will create 7 checkins for a given patron
|
|
# 3 checked in today - 2 days, and 4 checked in today
|
|
my $librarian = $builder->build_object(
|
|
{
|
|
class => 'Koha::Patrons',
|
|
value => { branchcode => $library->{branchcode} }
|
|
}
|
|
);
|
|
t::lib::Mocks::mock_userenv( { patron => $librarian } );
|
|
my $patron = $builder->build_object(
|
|
{
|
|
class => 'Koha::Patrons',
|
|
value => { branchcode => $library->{branchcode} }
|
|
}
|
|
);
|
|
|
|
my @checkouts;
|
|
# Create 7 checkouts
|
|
for ( 0 .. 6 ) {
|
|
my $item = $builder->build_sample_item;
|
|
push @checkouts,
|
|
Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $item->itemnumber,
|
|
branchcode => $library->{branchcode},
|
|
}
|
|
)->store;
|
|
}
|
|
|
|
# Checkin 3 today - 2 days
|
|
my $not_today = dt_from_string->add( days => -2 );
|
|
for my $i ( 0 .. 2 ) {
|
|
my $checkout = $checkouts[$i];
|
|
C4::Circulation::AddReturn(
|
|
$checkout->item->barcode, $library->{branchcode},
|
|
undef, $not_today->set_hour( int( rand(24) ) )
|
|
);
|
|
}
|
|
# Checkin 4 today
|
|
my $today = dt_from_string;
|
|
for my $i ( 3 .. 6 ) {
|
|
my $checkout = $checkouts[$i];
|
|
C4::Circulation::AddReturn(
|
|
$checkout->item->barcode, $library->{branchcode},
|
|
undef, $today->set_hour( int( rand(24) ) )
|
|
);
|
|
}
|
|
|
|
my $old_checkouts = $patron->old_checkouts;
|
|
is( $old_checkouts->count, 7, 'There should be 7 old checkouts' );
|
|
my $todays_checkins = $old_checkouts->filter_by_todays_checkins;
|
|
is( $todays_checkins->count, 4, 'There should be 4 checkins today' );
|
|
is_deeply(
|
|
[ $todays_checkins->get_column('itemnumber') ],
|
|
[ map { $_->itemnumber } @checkouts[ 3 .. 6 ] ],
|
|
q{Correct list of today's checkins}
|
|
);
|
|
};
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
subtest 'automatic_checkin' => sub {
|
|
|
|
plan tests => 9;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
|
|
|
|
my $due_ac_item =
|
|
$builder->build_sample_item(
|
|
{ homebranch => $patron->branchcode, itemlost => 0 } );
|
|
my $ac_item =
|
|
$builder->build_sample_item(
|
|
{ homebranch => $patron->branchcode, itemlost => 0 } );
|
|
my $odue_ac_item =
|
|
$builder->build_sample_item(
|
|
{ homebranch => $patron->branchcode, itemlost => 0 } );
|
|
my $normal_item =
|
|
$builder->build_sample_item(
|
|
{ homebranch => $patron->branchcode, itemlost => 0 } );
|
|
|
|
$due_ac_item->itemtype->automatic_checkin(1)->store;
|
|
$odue_ac_item->itemtype->automatic_checkin(1)->store;
|
|
$ac_item->itemtype->automatic_checkin(1)->store;
|
|
$normal_item->itemtype->automatic_checkin(0)->store;
|
|
|
|
my $today = dt_from_string;
|
|
my $tomorrow = dt_from_string->add( days => 1 );
|
|
my $yesterday = dt_from_string->subtract( days => 1 );
|
|
|
|
# Checkout do for automatic checkin
|
|
my $checkout_due_aci = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $due_ac_item->itemnumber,
|
|
branchcode => $patron->branchcode,
|
|
date_due => $today,
|
|
}
|
|
)->store;
|
|
|
|
# Checkout not due for automatic checkin
|
|
my $checkout_odue_aci = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $odue_ac_item->itemnumber,
|
|
branchcode => $patron->branchcode,
|
|
date_due => $yesterday
|
|
}
|
|
)->store;
|
|
|
|
# Checkout not due for automatic checkin
|
|
my $checkout_aci = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $ac_item->itemnumber,
|
|
branchcode => $patron->branchcode,
|
|
date_due => $tomorrow
|
|
}
|
|
)->store;
|
|
|
|
# due checkout for nomal itemtype
|
|
my $checkout_ni = Koha::Checkout->new(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
itemnumber => $normal_item->itemnumber,
|
|
branchcode => $patron->branchcode,
|
|
date_due => $today,
|
|
}
|
|
)->store;
|
|
|
|
my $searched = Koha::Checkouts->find( $checkout_ni->issue_id );
|
|
is( $searched->issue_id, $checkout_ni->issue_id,
|
|
'checkout for normal_item exists' );
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_aci->issue_id );
|
|
is( $searched->issue_id, $checkout_aci->issue_id,
|
|
'checkout for ac_item exists' );
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_due_aci->issue_id );
|
|
is(
|
|
$searched->issue_id,
|
|
$checkout_due_aci->issue_id,
|
|
'checkout for due_ac_item exists'
|
|
);
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_odue_aci->issue_id );
|
|
is(
|
|
$searched->issue_id,
|
|
$checkout_odue_aci->issue_id,
|
|
'checkout for odue_ac_item exists'
|
|
);
|
|
|
|
Koha::Checkouts->automatic_checkin;
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_ni->issue_id );
|
|
is( $searched->issue_id, $checkout_ni->issue_id,
|
|
'checkout for normal_item still exists' );
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_aci->issue_id );
|
|
is( $searched->issue_id, $checkout_aci->issue_id,
|
|
'checkout for ac_item still exists' );
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_due_aci->issue_id );
|
|
is( $searched, undef, 'checkout for due_ac_item doesn\'t exist anymore' );
|
|
|
|
$searched = Koha::Checkouts->find( $checkout_odue_aci->issue_id );
|
|
is( $searched, undef, 'checkout for odue_ac_item doesn\'t exist anymore' );
|
|
|
|
$searched = Koha::Old::Checkouts->find( $checkout_odue_aci->issue_id );
|
|
is( dt_from_string($searched->returndate), $yesterday, 'old checkout for odue_ac_item has the right return date' );
|
|
|
|
$schema->storage->txn_rollback;
|
|
}
|
|
|