Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/C4
History
Marcel de Rooy 795dc61f75 Bug 3264 UnCloneField() / minus button in MARC editor can clear all subfields (authorities AND biblio) 
All subfields following the removed subfield were not saved.
Problem is in C4/Biblio routine TransformHtmlToMarc.
If the field is emptied, the param list contains a code param but no subfield
param. The while loop handling the subfields could not handle that. Also added
a FIXME because the whole routine depends on an assumption about the order of
cgi parameters that is not strictly guaranteed.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I was unable to replicate the problem, but can confirm that the patch does
not break anything under any of the following platforms/browsers:
Mac OS X 10.6.8:
Chrome 16.0.912.77
Firefox 9.0.1

Windows 7:
Firefox 3.6.3
Firefox 9.0.1
IE 8.0.7600.16385

Ubuntu 11.10
Firefox 8.0
Chromium 15.0.874.106 (Developer Build 107270 Linux)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-02-16 18:52:46 +01:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:38:42 +13:00
Cache
ClassSortRoutine
Creators
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 08:38:58 +12:00
Heading
ILSDI Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT 2011-12-27 18:38:42 +01:00
Installer Bug 6836: Adding dependency on Modern::Perl 2012-01-27 11:33:16 +01:00
Labels Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
Members
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards
Reports Bug 6755 : Fixing a bug with guided reports 2011-09-27 07:04:02 +13:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
SIP
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
Utils
VirtualShelves Merge remote-tracking branch 'origin/new/bug_7083' 2012-01-18 16:20:26 +01:00
Accounts.pm
Acquisition.pm
Auth.pm
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_ldap.pm Bug 6022: Auth_with_ldap check if categorycode is valid 2011-12-06 19:51:15 +01:00
AuthoritiesMarc.pm Use MARCAuthorityControlField008 in AddAuthority for empty 008s 2011-12-27 17:57:42 +01:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm Bug 3264 UnCloneField() / minus button in MARC editor can clear all subfields (authorities AND biblio) 2012-02-16 18:52:46 +01:00
Bookseller.pm Bug 3388: Restore account number on vendor page 2011-11-25 11:07:11 +01:00
Boolean.pm
Branch.pm Bug 7034: de-nesting C4/Branch.pm 2011-10-19 03:23:31 +13:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-06 08:22:06 +13:00
Budgets.pm bug_4831: Use unitprice (actual cost) when totalling spent amounts for "All available funds", as in "Already received" 2011-09-22 19:35:40 +12:00
Cache.pm
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm Bug 6989 Patron categories not properly displayed if not pure ASCII 2011-11-04 12:07:08 +01:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm bug_7090: AllowItemsOnHandCheckout syspref 2012-02-10 19:28:25 +01:00
ClassSortRoutine.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
ClassSource.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
Context.pm
Contract.pm
Creators.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Csv.pm
Dates.pm Bug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with no way to clear it, fixed also. 2012-01-13 16:17:48 +01:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 6875 de-nesting C4::Heading 2012-02-15 14:58:39 +01:00
Images.pm
ImportBatch.pm Bug 5859: Allow user to set encoding for import 2011-04-19 13:05:48 +12:00
ImportExportFramework.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-03 14:22:15 +01:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm Bug 6699 follow-up 2011-12-03 07:43:15 +01:00
ItemCirculationAlertPreference.pm
Items.pm Bug 6488 adding a 2nd \n to silence logs 2012-02-02 15:21:25 +01:00
ItemType.pm
Koha.pm Bug 6875 de-nesting C4::Koha.pm 2012-02-15 14:58:28 +01:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm Bug 7432 : Fixing caching for C4::Languages 2012-02-15 10:26:26 +01:00
Letters.pm Bug 5347: Set translatable the "no email" error 2012-01-20 14:12:28 +01:00
Log.pm
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm Renew membership from expiry date or from current date based on a syspref 2012-02-01 22:53:40 +01:00
Message.pm
NewsChannels.pm
Output.pm
Overdues.pm Bug 6987 Make return from Overdues::GetFine consistent 2011-12-08 11:19:10 +01:00
Patroncards.pm
Print.pm Bug 6627 [Signed Off] - Update to improve security in specified log files - bug 6627 2012-01-06 14:20:34 +01:00
Record.pm Bug 7345: Enable exporting records sans private fields 2012-02-13 11:32:18 +01:00
Reports.pm
Reserves.pm bug_2830: Remove reserve when checking out if the borrower is not the first one in the reserve queue 2011-12-16 16:21:38 +01:00
Review.pm Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
Ris.pm bug 5780 followup: RIS export now includes all URLs 2011-10-14 10:37:31 +13:00
RotatingCollections.pm
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-13 08:17:27 +13:00
Search.pm Bug 6539 follow-up, fixing wrong indentation 2012-02-01 17:51:05 +01:00
Serials.pm
Service.pm
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm
Stats.pm
Suggestions.pm
Tags.pm
Templates.pm
TmplToken.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
TmplTokenType.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
TTParser.pm
UploadedFile.pm Bug 1633: [SIGNED-OFF] Add support for uploading images to Koha 2012-01-24 11:16:02 +01:00
Utils.pm
VirtualShelves.pm Bug 6875 de-nesting C4::VirtualShelves 2012-02-15 14:58:40 +01:00
XISBN.pm
XSLT.pm Bug 7476 Remove executable bit from files that probably should not be executed 2012-02-03 14:22:15 +01:00
Z3950.pm