Marcel de Rooy
7a62005468
Since delete is not part of the upload process, we will move it now to Koha::UploadedFile[s]. Deleting the file will be done in UploadedFile. The (multiple) delete method in UploadedFiles refers to the single delete. Test plan: [1] Run t/db_dependent/Upload.t The warning ("but file was missing") in the last subtest is fine; the file did not exist. Will be addressed in a follow-up. [2] Search for uploads on Tools/Upload. Clone this tab (repeat search on a new tab in your browser). [3] Delete an existing upload on the first tab. [4] Try to delete it again on the second tab. Error message? [5] Bonus points: Add an upload. Mark the file immutable with chattr +i. Try to delete the file. You should see a "Could not be deleted"-message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
||
---|---|---|
.. | ||
automatic_item_modification_by_age.tt | ||
batch_delete_records.tt | ||
batch_record_modification.tt | ||
batchMod-del.tt | ||
batchMod-edit.tt | ||
batchMod.tt | ||
cleanborrowers.tt | ||
csv-profiles.tt | ||
export.tt | ||
holidays.tt | ||
import_borrowers.tt | ||
inventory.tt | ||
koha-news.tt | ||
letter.tt | ||
manage-marc-import.tt | ||
marc_modification_templates.tt | ||
modborrowers.tt | ||
overduerules.tt | ||
picture-upload.tt | ||
quotes-upload.tt | ||
quotes.tt | ||
scheduler.tt | ||
showdiffmarc.tt | ||
stage-marc-import.tt | ||
tools-home.tt | ||
upload-images.tt | ||
upload.tt | ||
viewlog.tt |