Koha/cataloguing
Fridolyn SOMERS cac06afeb1 Bug 11254: make reservoir search normalize ISBNs
When importing records, the ISBN is normalized and stored
into database (see C4::ImportBatch::_add_biblio_fields).  But when
searching with ISBN into reservoir, it is not normalized
(see C4::Breeding::BreedingSearch).  So search does not match.

This patch adds the normalisation to reservoir search.  Also, it
replaces call private method _isbn_cleanup by GetNormalizedISBN,
the correct public method.  Also allows the reservoir search
on ISBN with hyphens.

This is intended to fix only reservoir searches.

Revised Test plan
-----------------
 1) Back up DB
 2) Save copy of attached example somewhere findable
 2) Home -> Tools -> Stage MARC records for import
 3) Click Browse and select the example MARC file
 4) Click Upload file
 5) Tweak as desired then click Stage for import
 6) Click Manage staged records
 7) Click Import this batch into the catalog
 8) Home -> Cataloging
 9) In the Cataloging search text box type 978-0-691-14289-0 and
     click Submit
    -- ISBN13 with hypens not found in reservoir
10) In the Cataloging search text box type 9780691142890 and
     click Submit
    -- ISBN13 without hypens not found in reservoir
11) In the Cataloging search text box type 0-691-14289-0 and
     click Submit
    -- ISBN10 with hypens not found in reservoir
12) In the Cataloging search text box type 0691142890 and
     click Submit
    -- ISBN10 without hypens found in reservoir
13) Apply patch
14) Repeat steps 9-12, this time it is always found! :)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-04-19 21:44:30 +00:00
..
value_builder Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
addbiblio.pl Bug 11313: supply empty value in mandatory comboboxs in MARC record editors 2014-01-23 03:47:38 +00:00
addbooks.pl Bug 11254: make reservoir search normalize ISBNs 2014-04-19 21:44:30 +00:00
additem.pl Bug 7002: fix some invalid superlibrarian permission checks 2014-01-06 05:32:22 +00:00
linkitem.pl
merge.pl Bug 9755 QA follow-up: move MARC-specific functionality to utility class 2013-07-23 23:10:21 +00:00
merge_ajax.pl Bug 8860 - can't merge if you don't have fast cataloging permissions 2012-10-05 16:51:32 +02:00
moveitem.pl Bug 10504: Remove the unused C4::Acq::ModOrderItem routine 2013-07-15 16:06:19 +00:00
plugin_launcher.pl Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
ysearch.pl Bug 8278: build the structure with to_json instead of manually. 2013-05-08 09:49:55 -04:00
z3950_auth_search.pl Bug 10096 - (follow-up) various QA improvements 2013-10-04 14:29:18 +00:00
z3950_search.pl Bug 10096 - Add a Z39.50 interface for authority searching 2013-10-04 14:26:29 +00:00