Kyle M Hall
6997276e51
Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven Signed-off-by: Liz Rea <liz@catalyst.net.nz> Verified bug, fix corrects the problem. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Also tested waiving fines form the check-in page still works. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
77 lines
2.5 KiB
Perl
Executable file
77 lines
2.5 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2014 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 3 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI;
|
|
use JSON qw(to_json);
|
|
|
|
use C4::Circulation;
|
|
use C4::Items qw(GetBarcodeFromItemnumber GetItem ModItem);
|
|
use C4::Context;
|
|
use C4::Auth qw(check_cookie_auth);
|
|
|
|
my $input = new CGI;
|
|
|
|
my ( $auth_status, $sessionID ) =
|
|
check_cookie_auth( $input->cookie('CGISESSID'),
|
|
{ circulate => 'circulate_remaining_permissions' } );
|
|
|
|
if ( $auth_status ne "ok" ) {
|
|
exit 0;
|
|
}
|
|
|
|
binmode STDOUT, ":encoding(UTF-8)";
|
|
print $input->header( -type => 'text/plain', -charset => 'UTF-8' );
|
|
|
|
my $itemnumber = $input->param('itemnumber');
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
my $override_limit = $input->param('override_limit');
|
|
my $exempt_fine = $input->param('exempt_fine');
|
|
my $branchcode = $input->param('branchcode')
|
|
|| C4::Context->userenv->{'branch'};
|
|
|
|
# Expect these inputs to come in as JSON boolean values
|
|
$override_limit = $override_limit ? $override_limit eq 'true' : undef;
|
|
$exempt_fine = $exempt_fine ? $exempt_fine eq 'true' : undef;
|
|
|
|
my $barcode = GetBarcodeFromItemnumber($itemnumber);
|
|
|
|
my $data;
|
|
$data->{itemnumber} = $itemnumber;
|
|
$data->{borrowernumber} = $borrowernumber;
|
|
$data->{branchcode} = $branchcode;
|
|
|
|
if ( C4::Context->preference("InProcessingToShelvingCart") ) {
|
|
my $item = GetItem($itemnumber);
|
|
if ( $item->{'location'} eq 'PROC' ) {
|
|
$item->{'location'} = 'CART';
|
|
ModItem( $item, $item->{'biblionumber'}, $item->{'itemnumber'} );
|
|
}
|
|
}
|
|
|
|
if ( C4::Context->preference("ReturnToShelvingCart") ) {
|
|
my $item = GetItem($itemnumber);
|
|
$item->{'location'} = 'CART';
|
|
ModItem( $item, $item->{'biblionumber'}, $item->{'itemnumber'} );
|
|
}
|
|
|
|
( $data->{returned} ) = AddReturn( $barcode, $branchcode, $exempt_fine );
|
|
|
|
print to_json($data);
|