Koha/opac
Jonathan Druart 0ab22e1c7c Bug 18789: Send Koha::Patron object to the templates
In order to simplify and make uniform the code, the controller scripts send
a Koha::Patron object to the templates instead of all attributes of a patron.

That will make the code much more easier to maintain and will be less
error-prone.

The variable "patron" sent to the templates is supposed to represent the
patron the librarian is editing the detail.

In the members module and some scripts of the circulation module, the
patron's detail are sent one by one to the template. That leads to
frustration from developpers (making sure everything is passed from all
scripts) and to regression (we got tone of bugs in the last year because
of this way to do).
With this patch set it will be easy access patron's detail, passing only
1 variable from the controllers.

Test plan:
Play with the patron and circulation module and make sur the detail of
the patron you are editing/seeing info are correctly displayed.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-02-16 13:03:58 -03:00
..
clubs Bug 12461 - Add patron clubs feature 2017-04-28 08:37:44 -04:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
external/overdrive bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron 2017-02-21 19:58:20 +00:00
rss
sco Bug 19280: Pass a Koha::Patron to CanBookBeIssued 2018-01-09 17:23:15 -03:00
svc Bug 18915: Renaming svc/patron_notes to svc/checkout_notes 2018-01-15 12:14:00 -03:00
ilsdi.pl Bug 13990: ILS-DI LookupPatron requires ID Type 2018-01-30 14:18:21 -03:00
maintenance.pl Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
oai.pl Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
opac-account-pay-paypal-return.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-account-pay-return.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account-pay.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account.pl Bug 19173: Add opac payment and marc conversion plugins to the pulldown filter list 2017-09-19 14:15:52 -03:00
opac-addbybiblionumber.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-alert-subscribe.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-article-request-cancel.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
opac-authorities-home.pl Bug 18204 - Authority searches are not saved in Search history 2017-05-28 22:12:01 -04:00
opac-authoritiesdetail.pl Bug 18149: Move CountUsage calls to Koha namespace 2017-09-19 11:47:32 -03:00
opac-basket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-blocked.pl
opac-browser.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-changelanguage.pl Bug 18946 [QA Followup] - code cleanup 2017-09-01 13:02:26 -03:00
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
opac-discharge.pl Bug 19212: Preventing warns when asking for discharge 2017-10-27 16:05:55 -03:00
opac-downloadcart.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-downloadshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-export.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-ics.pl Bug 5456 - Create a link to opac-ics.pl 2016-09-02 15:55:32 +00:00
opac-idref.pl Bug 19640: fix OPAC IdRef webservice display 2017-12-07 09:37:09 -03:00
opac-illrequests.pl Bug 7317: Handle backend absense more gracefuly 2017-11-09 11:42:14 -03:00
opac-image.pl Bug 16154: CGI->multi_param - Manual changes 2016-04-26 23:16:43 +00:00
opac-imageviewer.pl Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
opac-ISBDdetail.pl Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy 2018-02-13 13:36:00 -03:00
opac-issue-note.pl Bug 18915: Fix checkout note email message 2018-01-15 12:14:00 -03:00
opac-main.pl Bug 20068: Check if user logged in before passing dashboard params to template 2018-01-23 09:33:29 -03:00
opac-MARCdetail.pl Bug 19301: (QA follow-up) Add POD, use statements and correct typo 2018-02-13 13:36:00 -03:00
opac-memberentry.pl Bug 18403: Add new methods Koha::Patrons->search_limited and use it where needed 2018-02-12 15:41:39 -03:00
opac-messaging.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-modrequest-suspend.pl
opac-modrequest.pl Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
opac-mymessages.pl
opac-news-rss.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-overdrive-search.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
opac-passwd.pl Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
opac-password-recovery.pl Bug 18956: Fix empty to in message queue 2017-10-27 13:57:10 -03:00
opac-patron-image.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
opac-privacy.pl Bug 18169: Make 'before' param non mandatory for Koha::Patrons->anonymise_issue_history 2017-03-03 18:16:54 +00:00
opac-ratings-ajax.pl Bug 17089: Improve errors handling 2016-09-09 09:31:30 +00:00
opac-ratings.pl Bug 17089: Improve errors handling 2016-09-09 09:31:30 +00:00
opac-readingrecord.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-registration-verify.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-renew.pl Bug 18572 - QA Followup 2017-07-24 13:38:31 -03:00
opac-request-article.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
opac-reserve.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
opac-restrictedpage.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-retrieve-file.pl Bug 17501: Move getCategories and httpheaders from Upload.pm 2017-01-20 14:20:05 +00:00
opac-review.pl Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made 2017-12-21 11:07:51 -03:00
opac-search-history.pl Bug 12497: Fix OPAC search history reachable by URL even when disabled 2017-12-07 10:09:52 -03:00
opac-search.pl Bug 20157: Use group 'features' to decide which groups to use for group searching functionality 2018-02-12 15:41:58 -03:00
opac-sendbasket.pl Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address 2018-01-02 11:46:40 -03:00
opac-sendshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-serial-issues.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-shareshelf.pl Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address 2018-01-02 11:46:40 -03:00
opac-shelves.pl Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy 2018-02-13 13:36:00 -03:00
opac-showmarc.pl Bug 19569: Set X-Frame-Options=SAMEORIGIN - opac-showmarc.ok 2018-01-09 17:23:14 -03:00
opac-showreviews.pl Bug 19808: Handle deleted reviewers gracefully - opac-showreview 2017-12-21 11:07:37 -03:00
opac-suggestions.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-tags.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-tags_subject.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-topissues.pl Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
opac-user.pl Bug 13796: OPAC: Display rental charge for renewing 2017-10-27 16:05:51 -03:00
tracklinks.pl Bug 19847: Track links within the records and 404 for others 2018-02-15 16:04:52 -03:00
unapi Bug 19439: (follow-up) Remove four spaces from lines 133-149 2017-12-11 11:34:24 -03:00