e1b5fa657d
- Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! - Rebased t/db_dependent/Items.t conflict. The test plan is in comment #112 last I checked. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
367 lines
12 KiB
Perl
Executable file
367 lines
12 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright (C) 2000-2002 Katipo Communications
|
|
# Parts Copyright (C) 2010 BibLibre
|
|
# Parts Copyright (C) 2013 Mark Tompsett
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
=head1 NAME
|
|
|
|
opac-MARCdetail.pl : script to show a biblio in MARC format
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
=cut
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This script needs a biblionumber as parameter
|
|
|
|
It shows the biblio in a (nice) MARC format depending on MARC
|
|
parameters tables.
|
|
|
|
The template is in <templates_dir>/catalogue/MARCdetail.tt.
|
|
this template must be divided into 11 "tabs".
|
|
|
|
The first 10 tabs present the biblio, the 11th one presents
|
|
the items attached to the biblio
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use CGI qw ( -utf8 );
|
|
use MARC::Record;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Reserves;
|
|
use C4::Members;
|
|
use C4::Acquisition;
|
|
use C4::Koha;
|
|
use List::MoreUtils qw( any uniq );
|
|
use Koha::Biblios;
|
|
use Koha::IssuingRules;
|
|
use Koha::Items;
|
|
use Koha::ItemTypes;
|
|
use Koha::Patrons;
|
|
use Koha::RecordProcessor;
|
|
|
|
my $query = CGI->new();
|
|
|
|
my $biblionumber = $query->param('biblionumber');
|
|
if ( ! $biblionumber ) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
$biblionumber = int($biblionumber);
|
|
|
|
# open template
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-MARCdetail.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $patron = Koha::Patrons->find( $loggedinuser );
|
|
my $borcat = q{};
|
|
if ( C4::Context->preference('OpacHiddenItemsExceptions') ) {
|
|
# we need to fetch the borrower info here, so we can pass the category
|
|
$borcat = $patron ? $patron->categorycode : $borcat;
|
|
}
|
|
|
|
my $record = GetMarcBiblio({
|
|
biblionumber => $biblionumber,
|
|
embed_items => 1,
|
|
opac => 1,
|
|
borcat => $borcat });
|
|
if ( ! $record ) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
|
|
my @all_items = GetItemsInfo($biblionumber);
|
|
my $biblio = Koha::Biblios->find( $biblionumber );
|
|
my $framework = $biblio ? $biblio->frameworkcode : q{};
|
|
my $tagslib = &GetMarcStructure( 0, $framework );
|
|
my ($tag_itemnumber,$subtag_itemnumber) = &GetMarcFromKohaField('items.itemnumber',$framework);
|
|
my @nonhiddenitems = $record->field($tag_itemnumber);
|
|
if (scalar @all_items >= 1 && scalar @nonhiddenitems == 0) {
|
|
print $query->redirect("/cgi-bin/koha/errors/404.pl");
|
|
exit;
|
|
}
|
|
|
|
my $record_processor = Koha::RecordProcessor->new({
|
|
filters => 'ViewPolicy',
|
|
options => {
|
|
interface => 'opac',
|
|
frameworkcode => $framework
|
|
}
|
|
});
|
|
$record_processor->process($record);
|
|
|
|
# get biblionumbers stored in the cart
|
|
if(my $cart_list = $query->cookie("bib_list")){
|
|
my @cart_list = split(/\//, $cart_list);
|
|
if ( grep {$_ eq $biblionumber} @cart_list) {
|
|
$template->param( incart => 1 );
|
|
}
|
|
}
|
|
|
|
my ($bt_tag,$bt_subtag) = GetMarcFromKohaField('biblio.title',$framework);
|
|
$template->param(
|
|
bibliotitle => $biblio->title,
|
|
) if $tagslib->{$bt_tag}->{$bt_subtag}->{hidden} <= 0 && # <=0 OPAC visible.
|
|
$tagslib->{$bt_tag}->{$bt_subtag}->{hidden} > -8; # except -8;
|
|
|
|
my $allow_onshelf_holds;
|
|
for my $itm (@all_items) {
|
|
my $item = Koha::Items->find( $itm->{itemnumber} );
|
|
$allow_onshelf_holds = Koha::IssuingRules->get_onshelfholds_policy( { item => $item, patron => $patron } );
|
|
last if $allow_onshelf_holds;
|
|
}
|
|
|
|
if( $allow_onshelf_holds || CountItemsIssued($biblionumber) || $biblio->has_items_waiting_or_intransit ) {
|
|
$template->param( ReservableItems => 1 );
|
|
}
|
|
|
|
# adding the $RequestOnOpac param
|
|
my $RequestOnOpac;
|
|
if (C4::Context->preference("RequestOnOpac")) {
|
|
$RequestOnOpac = 1;
|
|
}
|
|
|
|
# fill arrays
|
|
my @loop_data = ();
|
|
my $tag;
|
|
|
|
# loop through each tab 0 through 9
|
|
for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) {
|
|
|
|
# loop through each tag
|
|
my @loop_data = ();
|
|
my @subfields_data;
|
|
|
|
# deal with leader
|
|
unless ( $tagslib->{'000'}->{'@'}->{tab} ne $tabloop
|
|
or $tagslib->{'000'}->{'@'}->{hidden} > 0 )
|
|
{
|
|
my %subfield_data;
|
|
$subfield_data{marc_lib} = $tagslib->{'000'}->{'@'}->{lib};
|
|
$subfield_data{marc_value} = $record->leader();
|
|
$subfield_data{marc_subfield} = '@';
|
|
$subfield_data{marc_tag} = '000';
|
|
push( @subfields_data, \%subfield_data );
|
|
my %tag_data;
|
|
$tag_data{tag} = '000 -' . $tagslib->{'000'}->{lib};
|
|
my @tmp = @subfields_data;
|
|
$tag_data{subfield} = \@tmp;
|
|
push( @loop_data, \%tag_data );
|
|
undef @subfields_data;
|
|
}
|
|
my @fields = $record->fields();
|
|
for ( my $x_i = 0 ; $x_i <= $#fields ; $x_i++ ) {
|
|
|
|
# if tag <10, there's no subfield, use the "@" trick
|
|
if ( $fields[$x_i]->tag() < 10 ) {
|
|
next
|
|
if (
|
|
$tagslib->{ $fields[$x_i]->tag() }->{'@'}->{tab} ne $tabloop );
|
|
next if ( $tagslib->{ $fields[$x_i]->tag() }->{'@'}->{hidden} > 0 );
|
|
my %subfield_data;
|
|
$subfield_data{marc_lib} =
|
|
$tagslib->{ $fields[$x_i]->tag() }->{'@'}->{lib};
|
|
$subfield_data{marc_value} = $fields[$x_i]->data();
|
|
$subfield_data{marc_subfield} = '@';
|
|
$subfield_data{marc_tag} = $fields[$x_i]->tag();
|
|
push( @subfields_data, \%subfield_data );
|
|
}
|
|
else {
|
|
my @subf = $fields[$x_i]->subfields;
|
|
my $previous = '';
|
|
# loop through each subfield
|
|
for my $i ( 0 .. $#subf ) {
|
|
$subf[$i][0] = "@" unless defined($subf[$i][0]);
|
|
my $sf_def = $tagslib->{ $fields[$x_i]->tag() };
|
|
$sf_def = $sf_def->{ $subf[$i][0] } if defined($sf_def);
|
|
my ($tab,$hidden,$lib);
|
|
$tab = $sf_def->{tab} if defined($sf_def);
|
|
$tab = $tab // int($fields[$x_i]->tag()/100);
|
|
$hidden = $sf_def->{hidden} if defined($sf_def);
|
|
$hidden = $hidden // 0;
|
|
next if ( $tab != $tabloop );
|
|
next if ( $hidden > 0 );
|
|
my %subfield_data;
|
|
$lib = $sf_def->{lib} if defined($sf_def);
|
|
$lib = $lib // '--';
|
|
$subfield_data{marc_lib} = ($lib eq $previous) ? '--' : $lib;
|
|
$previous = $lib;
|
|
$subfield_data{link} = $sf_def->{link};
|
|
$subf[$i][1] =~ s/\n/<br\/>/g;
|
|
if ( $sf_def->{isurl} ) {
|
|
$subfield_data{marc_value} = "<a href=\"$subf[$i][1]\">$subf[$i][1]</a>";
|
|
}
|
|
elsif ( defined($sf_def->{kohafield}) && $sf_def->{kohafield} eq "biblioitems.isbn" ) {
|
|
$subfield_data{marc_value} = $subf[$i][1];
|
|
}
|
|
else {
|
|
if ( $sf_def->{authtypecode} ) {
|
|
$subfield_data{authority} = $fields[$x_i]->subfield(9);
|
|
}
|
|
$subfield_data{marc_value} = GetAuthorisedValueDesc( $fields[$x_i]->tag(),
|
|
$subf[$i][0], $subf[$i][1], '', $tagslib, '', 'opac' );
|
|
}
|
|
$subfield_data{marc_subfield} = $subf[$i][0];
|
|
$subfield_data{marc_tag} = $fields[$x_i]->tag();
|
|
push( @subfields_data, \%subfield_data );
|
|
}
|
|
}
|
|
if ( $#subfields_data >= 0 ) {
|
|
my %tag_data;
|
|
if ( ( $fields[$x_i]->tag() eq $fields[ $x_i - 1 ]->tag() )
|
|
&& ( C4::Context->preference('LabelMARCView') eq 'economical' )
|
|
)
|
|
{
|
|
$tag_data{tag} = "";
|
|
}
|
|
else {
|
|
if ( C4::Context->preference('hide_marc') ) {
|
|
$tag_data{tag} = $tagslib->{ $fields[$x_i]->tag() }->{lib};
|
|
}
|
|
else {
|
|
my $sf_def = $tagslib->{ $fields[$x_i]->tag() };
|
|
my $lib;
|
|
$lib = $sf_def->{lib} if defined($sf_def);
|
|
$lib = $lib // '';
|
|
$tag_data{tag} = $fields[$x_i]->tag() . ' '
|
|
. C4::Koha::display_marc_indicators($fields[$x_i])
|
|
. " - $lib";
|
|
}
|
|
}
|
|
my @tmp = @subfields_data;
|
|
$tag_data{subfield} = \@tmp;
|
|
push( @loop_data, \%tag_data );
|
|
undef @subfields_data;
|
|
}
|
|
}
|
|
$template->param( "tab" . $tabloop . "XX" => \@loop_data );
|
|
}
|
|
|
|
|
|
# now, build item tab !
|
|
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
|
|
# loop through each tag
|
|
# warning : we may have differents number of columns in each row. Thus, we first build a hash, complete it if necessary
|
|
# then construct template.
|
|
# $record has already had all the item fields filtered above.
|
|
my @fields = $record->fields();
|
|
my %witness
|
|
; #---- stores the list of subfields used at least once, with the "meaning" of the code
|
|
my @item_subfield_codes;
|
|
my @item_loop;
|
|
foreach my $field (@fields) {
|
|
next if ( $field->tag() < 10 );
|
|
my @subf = $field->subfields;
|
|
my $item;
|
|
|
|
# loop through each subfield
|
|
for my $i ( 0 .. $#subf ) {
|
|
my $sf_def = $tagslib->{ $field->tag() }->{ $subf[$i][0] };
|
|
next if ( ($sf_def->{tab}||0) != 10 );
|
|
next if ( ($sf_def->{hidden}||0) > 0 );
|
|
push @item_subfield_codes, $subf[$i][0];
|
|
$witness{ $subf[$i][0] } = $sf_def->{lib};
|
|
|
|
if ( $sf_def->{isurl} ) {
|
|
$item->{ $subf[$i][0] } = "<a href=\"$subf[$i][1]\">$subf[$i][1]</a>";
|
|
}
|
|
elsif ( $sf_def->{kohafield} eq "biblioitems.isbn" ) {
|
|
$item->{ $subf[$i][0] } = $subf[$i][1];
|
|
}
|
|
else {
|
|
$item->{ $subf[$i][0] } = GetAuthorisedValueDesc( $field->tag(), $subf[$i][0],
|
|
$subf[$i][1], '', $tagslib, '', 'opac' );
|
|
}
|
|
}
|
|
push @item_loop, $item if $item;
|
|
}
|
|
my ( $holdingbrtagf, $holdingbrtagsubf ) =
|
|
&GetMarcFromKohaField( "items.holdingbranch", $framework );
|
|
@item_loop =
|
|
sort { ($a->{$holdingbrtagsubf}||'') cmp ($b->{$holdingbrtagsubf}||'') } @item_loop;
|
|
|
|
@item_subfield_codes = uniq @item_subfield_codes;
|
|
# fill item info
|
|
my @item_header_loop;
|
|
for my $subfield_code ( @item_subfield_codes ) {
|
|
push @item_header_loop, $witness{$subfield_code};
|
|
for my $item_data ( @item_loop ) {
|
|
$item_data->{$subfield_code} ||= " "
|
|
}
|
|
}
|
|
|
|
if ( C4::Context->preference("OPACISBD") ) {
|
|
$template->param( ISBD => 1 );
|
|
}
|
|
|
|
#Search for title in links
|
|
my $marcflavour = C4::Context->preference("marcflavour");
|
|
my $dat = TransformMarcToKoha( $record );
|
|
my $isbn = GetNormalizedISBN(undef,$record,$marcflavour);
|
|
my $marccontrolnumber = GetMarcControlnumber ($record, $marcflavour);
|
|
my $marcissns = GetMarcISSN( $record, $marcflavour );
|
|
my $issn = $marcissns->[0] || '';
|
|
|
|
if (my $search_for_title = C4::Context->preference('OPACSearchForTitleIn')){
|
|
$dat->{title} =~ s/\/+$//; # remove trailing slash
|
|
$dat->{title} =~ s/\s+$//; # remove trailing space
|
|
$search_for_title = parametrized_url(
|
|
$search_for_title,
|
|
{
|
|
TITLE => $dat->{title},
|
|
AUTHOR => $dat->{author},
|
|
ISBN => $isbn,
|
|
ISSN => $issn,
|
|
CONTROLNUMBER => $marccontrolnumber,
|
|
BIBLIONUMBER => $biblionumber,
|
|
}
|
|
);
|
|
$template->param('OPACSearchForTitleIn' => $search_for_title);
|
|
}
|
|
|
|
if( C4::Context->preference('ArticleRequests') ) {
|
|
my $artreqpossible = $patron
|
|
? $biblio->can_article_request( $patron )
|
|
: Koha::ItemTypes->find($biblio->itemtype)->may_article_request;
|
|
$template->param( artreqpossible => $artreqpossible );
|
|
}
|
|
|
|
$template->param(
|
|
item_loop => \@item_loop,
|
|
item_header_loop => \@item_header_loop,
|
|
item_subfield_codes => \@item_subfield_codes,
|
|
biblio => $biblio,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|