Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
Jonathan Druart c345694808 Bug 13970: Remove category_type related code 
Working on bug 13497 and bug 9314, I run into some Koha vestiges.
The category_type parameter should not be passed to memberentry.
On creating a new patron, the categorycode should be passed, and on
editing, it's useless. We can work with the borrowernumber and retrieve
these values.

Details of the changes:
- members-toolbar.inc: Remove the category_type parameter passed to
memberentry.pl
- memberentrygen.tt: Just remove the useless category_type parameter on
  editing a patron. Also remove the unused one passed to
  guarantor_search.pl.
- tables/members_results.tt: the borrowernumber is enough to edit a
  patron.
- memberentry.pl: check_categorytype is never used in the template, all
  the process to calculate/retrieve it is unnecessary.
- members/nl-search.tt: The borrowernumber is enough to edit a patron.

Test plan:
Try to create and edit patrons and verify that
- the guarantor search still work
- the form (memberentry) behave as before

Edit a patron from the nl-search.pl script (Magnus?)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

On top of 9314 (13497 already pushed)

No evident regressions found, add/edit patron works,
search/set guarantor works.

Cant test nl-patron.pl save for exec it.
prove -v t/NorwegianPatronDB.t runs

No koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-06-11 10:11:01 -03:00

170 lines
10 KiB
Text
Raw Blame History

[% USE KohaDates %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Search the Norwegian national patron database</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="pat_nl_search" class="pat">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'patron-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> &rsaquo; Search the Norwegian national patron database</div>
<div id="doc3" class="yui-t2">
<div id="bd">
<div id="yui-main">
<div class="yui-b">
<h1>Search the Norwegian national patron database</h1>
[% IF (error) %]
<div class="dialog alert">
[% IF ( error.nlenabled == 0 ) %]<p>You need to activate this function with the NorwegianPatronDBEnable system preference in order to use it.</p>[% END %]
[% IF ( error.endpoint == 0 ) %]<p>You need to specify an endpoint with the NorwegianPatronDBEndpoint system preference.</p>[% END %]
[% IF ( error.userpass == 0 ) %]<p>You need to fill in the NorwegianPatronDBUsername and NorwegianPatronDBPassword system preferences in order to use this function.</p>[% END %]
[% IF ( error == 'COULD_NOT_ADD_PATRON' ) %]<p>Could not add a new patron.</p>[% END %]
</div>
[% ELSE %]
[% SET nl_search_form_title='Search' %]
[% INCLUDE 'nl-search-form.tt' %]
[% END %]
[% IF ( local_result ) %]
<h3>Existing patrons</h3>
<ul>
[% FOREACH patron IN local_result %]
<li>[% patron.firstname %] [% patron.surname %] [% patron.cardnumber %] |
<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber %]">Details</a> |
<a href="/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% patron.borrowernumber %]">Edit</a> |
<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% patron.borrowernumber %]">Check out</a>
</li>
[% END %]
</ul>
[% END %]
[% IF ( result ) %]
[% IF result.antall_poster_returnert == 0 %]
<div class="dialog alert">
<p>No results found in the Norwegian national patron database. Message: "[% result.melding %]"</p>
</div>
[% ELSE %]
<h3>Results from the Norwegian national patron database</h3>
<div class="yui-g">
<div class="yui-u first">
[% PROCESS patron_detail p=result.respons_poster.0 %]
</div>
[% IF ( result.respons_poster.1 ) %]
<div class="yui-u">
[% PROCESS patron_detail p=result.respons_poster.1 %]
</div>
[% END %]
</div>
[% END %]
[% END %]
</div>
</div>
<div class="yui-b">
[% INCLUDE 'circ-menu.inc' %]
</div>
</div>
[% INCLUDE 'intranet-bottom.inc' %]
[% BLOCK patron_detail %]
<div class="rows">
<h4>[% p.navn | html_entity %]</h4>
<ol>
[% IF ( p.kjonn ) %]<li><span class="label">kjonn: </span>[% p.kjonn | html_entity %]</li>[% END %]
[% IF ( p.fdato ) %]<li><span class="label">fdato: </span>[% p.fdato | html_entity %]</li>[% END %]
[% IF ( p.lnr ) %]<li><span class="label">lnr: </span>[% p.lnr | html_entity %]</li>[% END %]
[% IF ( p.fnr_hash ) %]<li><span class="label">fnr_hash: </span>[% p.fnr_hash | html_entity %]</li>[% END %]
[% IF ( p.epost ) %]<li><span class="label">epost: </span>[% p.epost | html_entity %]</li>[% END %]
[% IF ( p.epost_sjekk ) %]<li><span class="label">epost_sjekk: </span>[% p.epost_sjekk | html_entity %]</li>[% END %]
[% IF ( p.tlf_mobil ) %]<li><span class="label">tlf_mobil: </span>[% p.tlf_mobil | html_entity %]</li>[% END %]
[% IF ( p.tlf_hjemme ) %]<li><span class="label">tlf_hjemme: </span>[% p.tlf_hjemme | html_entity %]</li>[% END %]
[% IF ( p.tlf_jobb ) %]<li><span class="label">tlf_jobb: </span>[% p.tlf_jobb | html_entity %]</li>[% END %]
[% IF ( p.p_adresse1 ) %]<li><span class="label">p_adresse1: </span>[% p.p_adresse1 | html_entity %]</li>[% END %]
[% IF ( p.p_adresse2 ) %]<li><span class="label">p_adresse2: </span>[% p.p_adresse2 | html_entity %]</li>[% END %]
[% IF ( p.p_postnr ) %]<li><span class="label">p_postnr: </span>[% p.p_postnr | html_entity %]</li>[% END %]
[% IF ( p.p_sted ) %]<li><span class="label">p_sted: </span>[% p.p_sted | html_entity %]</li>[% END %]
[% IF ( p.p_land ) %]<li><span class="label">p_land: </span>[% p.p_land | html_entity %]</li>[% END %]
[% IF ( p.p_sjekk ) %]<li><span class="label">p_sjekk: </span>[% p.p_sjekk | html_entity %]</li>[% END %]
[% IF ( p.m_adresse1 ) %]<li><span class="label">m_adresse1: </span>[% p.m_adresse1 | html_entity %]</li>[% END %]
[% IF ( p.m_adresse2 ) %]<li><span class="label">m_adresse2: </span>[% p.m_adresse2 | html_entity %]</li>[% END %]
[% IF ( p.m_postnr ) %]<li><span class="label">m_postnr: </span>[% p.m_postnr | html_entity %]</li>[% END %]
[% IF ( p.m_sted ) %]<li><span class="label">m_sted: </span>[% p.m_sted | html_entity %]</li>[% END %]
[% IF ( p.m_land ) %]<li><span class="label">m_land: </span>[% p.m_land | html_entity %]</li>[% END %]
[% IF ( p.m_sjek ) %]<li><span class="label">m_sjekk: </span>[% p.m_sjekk | html_entity %]</li>[% END %]
[% IF ( p.m_gyldig_til ) %]<li><span class="label">m_gyldig_til: </span>[% p.m_gyldig_til | html_entity %]</li>[% END %]
[% IF ( p.pin ) %]<li><span class="label">pin: </span>[% p.pin | html_entity %]</li>[% END %]
[% IF ( p.passord ) %]<li><span class="label">passsord: </span>[% p.passord | html_entity %]</li>[% END %]
[% IF ( p.feide ) %]<li><span class="label">feide: </span>[% p.feide | html_entity %]</li>[% END %]
[% IF ( p.folkeregsjekk_dato ) %]<li><span class="label">folkeregsjekk_dato: </span>[% p.folkeregsjekk_dato | html_entity %]</li>[% END %]
[% IF ( p.hjemmebibliotek ) %]<li><span class="label">hjemmebibliotek: </span>[% p.hjemmebibliotek | html_entity %]</li>[% END %]
[% IF ( p.opprettet ) %]<li><span class="label">opprettet: </span>[% p.opprettet | html_entity %]</li>[% END %]
[% IF ( p.opprettet_av ) %]<li><span class="label">opprettet_av: </span>[% p.opprettet_av | html_entity %]</li>[% END %]
[% IF ( p.sist_endret ) %]<li><span class="label">sist_endret: </span>[% p.sist_endret | html_entity %]</li>[% END %]
[% IF ( p.sist_endret_av ) %]<li><span class="label">sist_endret_av: </span>[% p.sist_endret_av | html_entity %]</li>[% END %]
[% IF ( p.gyldig_til ) %]<li><span class="label">gyldig_til: </span>[% p.gyldig_til | html_entity %]</li>[% END %]
[% IF ( p.prim_kontakt ) %]<li><span class="label">prim_kontakt: </span>[% p.prim_kontakt | html_entity %]</li>[% END %]
</ol>
<form action="nl-search.pl" method="POST">
<input type="hidden" name="op" value="save" />
<input type="hidden" name="navn" value="[% p.navn | html_entity %]" />
<input type="hidden" name="kjonn" value="[% p.kjonn | html_entity %]" />
<input type="hidden" name="fdato" value="[% p.fdato | html_entity %]" />
<input type="hidden" name="lnr" value="[% p.lnr | html_entity %]" />
<input type="hidden" name="fnr_hash" value="[% p.fnr_hash | html_entity %]" />
<input type="hidden" name="p_adresse1" value="[% p.p_adresse1 | html_entity %]" />
<input type="hidden" name="p_adresse2" value="[% p.p_adresse2 | html_entity %]" />
<input type="hidden" name="p_postnr" value="[% p.p_postnr | html_entity %]" />
<input type="hidden" name="p_sted" value="[% p.p_sted | html_entity %]" />
<input type="hidden" name="p_land" value="[% p.p_land | html_entity %]" />
<input type="hidden" name="p_sjekk" value="[% p.p_sjekk | html_entity %]" />
<input type="hidden" name="m_adresse1" value="[% p.m_adresse1 | html_entity %]" />
<input type="hidden" name="m_adresse2" value="[% p.m_adresse2 | html_entity %]" />
<input type="hidden" name="m_postnr" value="[% p.m_postnr | html_entity %]" />
<input type="hidden" name="m_sted" value="[% p.m_sted | html_entity %]" />
<input type="hidden" name="m_land" value="[% p.m_land | html_entity %]" />
<input type="hidden" name="m_sjekk" value="[% p.m_sjekk | html_entity %]" />
<input type="hidden" name="m_gyldig_til" value="[% p.m_gyldig_til | html_entity %]" />
<input type="hidden" name="pin" value="[% p.pin %]" />
<input type="hidden" name="passord" value="[% p.passord | html_entity %]" />
<input type="hidden" name="feide" value="[% p.feide | html_entity %]" />
<input type="hidden" name="folkeregsjekk_dato" value="[% p.folkeregsjekk_dato | html_entity %]" />
<input type="hidden" name="hjemmebibliotek" value="[% p.hjemmebibliotek | html_entity %]" />
<input type="hidden" name="opprettet" value="[% p.opprettet | html_entity %]" />
<input type="hidden" name="opprettet_av" value="[% p.opprettet_av | html_entity %]" />
<input type="hidden" name="sist_endret" value="[% p.sist_endret | html_entity %]" />
<input type="hidden" name="sist_endret_av" value="[% p.sist_endret_av | html_entity %]" />
<input type="hidden" name="gyldig_til" value="[% p.gyldig_til | html_entity %]" />
<input type="hidden" name="epost" value="[% p.epost | html_entity %]" />
<input type="hidden" name="epost_sjekk" value="[% p.epost_sjekk | html_entity %]" />
<input type="hidden" name="tlf_mobil" value="[% p.tlf_mobil | html_entity %]" />
<input type="hidden" name="tlf_hjemme" value="[% p.tlf_hjemme | html_entity %]" />
<input type="hidden" name="tlf_jobb" value="[% p.tlf_jobb | html_entity %]" />
<input type="hidden" name="prim_kontakt" value="[% p.prim_kontakt | html_entity %]" />
<input type="submit" value="Import this patron" />
as
<select name="categorycode">
[% FOREACH c IN categories %]
<option value="[% c.categorycode %]">[% c.description %]</option>
[% END %]
</select>
</form>
</div>
[% END %]
View git blame Copy permalink