Alex Buckley
81826a7af7
This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'REF' (don't use 'CART' as this is blanked by bug 14576 on checkout). Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
||
|---|---|---|
| .. | ||
| Acquisition | ||
| Biblio | ||
| Budgets | ||
| Circulation | ||
| cypress | ||
| data | ||
| db_dependent | ||
| edi_testfiles | ||
| etc | ||
| External | ||
| Koha | ||
| lib | ||
| Number | ||
| Search | ||
| Serials | ||
| SIP | ||
| Template | ||
| Test | ||
| 00-check-atomic-updates.t | ||
| 00-deprecated.t | ||
| 00-load.t | ||
| 00-merge-conflict-markers.t | ||
| 00-testcritic.t | ||
| 00-valid-xml.t | ||
| Auth.t | ||
| AuthoritiesMarc_MARC21.t | ||
| AuthoritiesMarc_UNIMARC.t | ||
| Barcodes_annual.t | ||
| Barcodes_EAN13.t | ||
| Barcodes_hbyymmincr.t | ||
| Barcodes_incremental.t | ||
| Biblio.t | ||
| Biblio2.t | ||
| Budgets.t | ||
| Charset.t | ||
| Circulation_barcodedecode.t | ||
| ClassSortRoutine.t | ||
| ClassSortRoutine_Dewey.t | ||
| ClassSortRoutine_Generic.t | ||
| ClassSortRoutine_LCC.t | ||
| ClassSource.t | ||
| Context.t | ||
| Contract.t | ||
| CookieManager.t | ||
| Creators.t | ||
| DateUtils.t | ||
| dummy.t | ||
| Edifact.t | ||
| EdiInvoice.t | ||
| Ediorder.t | ||
| Ediordrsp.t | ||
| Form_MessagingPreferences.t | ||
| HtmlTags.t | ||
| ImportBatch.t | ||
| Installer_PerlModules.t | ||
| ItemCirculationAlertPreference.t | ||
| Koha_MetadataRecord.t | ||
| Koha_SearchEngine_Elasticsearch_Browse.t | ||
| Koha_Template_Plugin_Cache.t | ||
| Koha_Template_Plugin_HtmlId.t | ||
| Koha_Template_Plugin_Koha.t | ||
| Koha_Util_FrameworkPlugin.t | ||
| Koha_Util_MARC.t | ||
| Koha_XSLT_HTTPS.t | ||
| Labels.t | ||
| Labels_split_ccn.t | ||
| Labels_split_ddcn.t | ||
| Labels_split_lccn.t | ||
| Labels_split_Regex.t | ||
| Languages.t | ||
| Logger.t | ||
| Makefile.t | ||
| Members_Messaging.t | ||
| OpenLibrarySearch.t | ||
| Output.t | ||
| Output_JSONStream.t | ||
| Patroncards.t | ||
| Patroncards_Batch.t | ||
| Patroncards_Lib.t | ||
| Patroncards_Patroncard.t | ||
| Patroncards_Profile.t | ||
| Patroncards_Template.t | ||
| RecordProcessor.t | ||
| Ris.t | ||
| Scheduler.t | ||
| Scrubber.t | ||
| Search.t | ||
| Search_PazPar2.t | ||
| SimpleMARC.t | ||
| SMS.t | ||
| SuggestionEngine.t | ||
| SuggestionEngine_AuthorityFile.t | ||
| template_filters.t | ||
| timezones.t | ||
| TmplToken.t | ||
| Token.t | ||