Jonathan Druart
4e6d9defc1
# Failed test 'The date_due should have been set depending on the circ
rules when the on-site checkout has been switched'
# at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 126.
# got: '2018-10-16T23:59:00'
# expected: '2018-10-21T23:59:00'
TestBuilder set date to today, so issuingrules.harduedate will be set to
today.
issuingrules.hardduedatecompare will be set to an integer.
If set to 0, $datedue will be reset to the hard due date
The call stack is: AddIssue > CalcDateDue > GetHardDueDate
In GetHardDueDate:
3509 if ( $hardduedatecompare == 0 || $hardduedatecompare == $cmp ) {
3510 $datedue = $hardduedate->clone;
3511 }
To fix this random failure we need to set issuingrules.harduedate to undef.
Test plan:
0. Do not apply this patch
1. Modify the test to set hardduedatecompare to 0 (search 'my $issuingrule = ')
2. Execute the test and confirm the failure
3. Apply this patch
4. Execute the test and confirm the it is no longer failing
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
|
||
|---|---|---|
| .. | ||
| Acquisition | ||
| Biblio | ||
| Budgets | ||
| Circulation | ||
| db_dependent | ||
| edi_testfiles | ||
| etc | ||
| External | ||
| Koha | ||
| lib | ||
| Members | ||
| Number | ||
| Search | ||
| Serials | ||
| SIP | ||
| Test | ||
| 00-checkdatabase-version.t | ||
| 00-deprecated.t | ||
| 00-load.t | ||
| 00-merge-conflict-markers.t | ||
| 00-testcritic.t | ||
| 00-valid-xml.t | ||
| Auth_with_shibboleth.t | ||
| AuthoritiesMarc_MARC21.t | ||
| AuthoritiesMarc_UNIMARC.t | ||
| AuthUtils.t | ||
| Barcodes_annual.t | ||
| Barcodes_EAN13.t | ||
| Barcodes_hbyymmincr.t | ||
| Barcodes_incremental.t | ||
| Biblio.t | ||
| Biblio2.t | ||
| Bookseller.t | ||
| Boolean.t | ||
| Budgets.t | ||
| Cache.t | ||
| Calendar.t | ||
| Charset.t | ||
| Circulation_barcodedecode.t | ||
| ClassSortRoutine.t | ||
| ClassSortRoutine_Dewey.t | ||
| ClassSortRoutine_Generic.t | ||
| ClassSortRoutine_LCC.t | ||
| ClassSource.t | ||
| Context.t | ||
| Contract.t | ||
| Creators.t | ||
| DateUtils.t | ||
| Debug.t | ||
| dummy.t | ||
| Edifact.t | ||
| EdiInvoice.t | ||
| Ediorder.t | ||
| Ediordrsp.t | ||
| Form_MessagingPreferences.t | ||
| Heading.t | ||
| HtmlTags.t | ||
| Images.t | ||
| ImportBatch.t | ||
| Installer_PerlDependencies.t | ||
| Installer_PerlModules.t | ||
| Installer_pm.t | ||
| ItemCirculationAlertPreference.t | ||
| Koha.t | ||
| Koha_Email.t | ||
| Koha_ExternalContent_OverDrive.t | ||
| Koha_ExternalContent_RecordedBooks.t | ||
| Koha_MetadataRecord.t | ||
| Koha_Template_Plugin_Cache.t | ||
| Koha_Template_Plugin_Koha.t | ||
| Koha_Util_FrameworkPlugin.t | ||
| Koha_Util_MARC.t | ||
| Labels.t | ||
| Labels_split_ccn.t | ||
| Labels_split_ddcn.t | ||
| Labels_split_lccn.t | ||
| Languages.t | ||
| Letters.t | ||
| Log.t | ||
| Logger.t | ||
| Makefile.t | ||
| Matcher.t | ||
| Members_Attributes.t | ||
| Members_AttributeTypes.t | ||
| Members_Messaging.t | ||
| OpenLibrarySearch.t | ||
| Output.t | ||
| Output_JSONStream.t | ||
| Patron.t | ||
| Patroncards.t | ||
| Patroncards_Batch.t | ||
| Patroncards_Layout.t | ||
| Patroncards_Lib.t | ||
| Patroncards_Patroncard.t | ||
| Patroncards_Profile.t | ||
| Patroncards_Template.t | ||
| perlcriticrc | ||
| Prices.t | ||
| Print.t | ||
| QueryParser.t | ||
| RecordProcessor.t | ||
| Ris.t | ||
| Scheduler.t | ||
| Scrubber.t | ||
| Search.t | ||
| Search_PazPar2.t | ||
| SimpleMARC.t | ||
| SMS.t | ||
| SocialData.t | ||
| Stats.t | ||
| SuggestionEngine.t | ||
| SuggestionEngine_AuthorityFile.t | ||
| template_filters.t | ||
| timezones.t | ||
| TmplToken.t | ||
| Token.t | ||
| XSLT.t | ||