8d76a99d47
This patch fixes issue introduced by BZ32530 Test Plan (on main): 1 - Edit a patron 2 - Do not change anything and submit -> you get an error 3 - Apply both patches 4 - Repeat 1&2 -> everything works fine 5 - Try and delete the guarantor -> it will be deleted Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
959 lines
36 KiB
Perl
Executable file
959 lines
36 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2006 SAN OUEST PROVENCE et Paul POULAIN
|
|
# Copyright 2010 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
# pragma
|
|
use Modern::Perl;
|
|
use Try::Tiny;
|
|
|
|
# external modules
|
|
use CGI qw ( -utf8 );
|
|
|
|
# internal modules
|
|
use C4::Auth qw( get_template_and_user haspermission );
|
|
use C4::Context;
|
|
use C4::Output qw( output_and_exit output_and_exit_if_error output_html_with_http_headers );
|
|
use C4::Koha qw( GetAuthorisedValues );
|
|
use C4::Letters qw( GetPreparedLetter EnqueueLetter SendQueuedMessages );
|
|
use C4::Form::MessagingPreferences;
|
|
use Koha::AuthUtils;
|
|
use Koha::AuthorisedValues;
|
|
use Koha::Email;
|
|
use Koha::Patron::Debarments qw( AddDebarment DelDebarment );
|
|
use Koha::Patron::Restriction::Types;
|
|
use Koha::Cities;
|
|
use Koha::DateUtils qw( dt_from_string );
|
|
use Koha::Libraries;
|
|
use Koha::Patrons;
|
|
use Koha::Patron::Attribute::Types;
|
|
use Koha::Patron::Categories;
|
|
use Koha::Patron::HouseboundRole;
|
|
use Koha::Patron::HouseboundRoles;
|
|
use Koha::Policy::Patrons::Cardnumber;
|
|
use Koha::Plugins;
|
|
use Koha::SMS::Providers;
|
|
|
|
my $input = CGI->new;
|
|
my %data;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my ($template, $loggedinuser, $cookie)
|
|
= get_template_and_user({template_name => "members/memberentrygen.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
flagsrequired => {borrowers => 'edit_borrowers'},
|
|
});
|
|
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
my $patron = Koha::Patrons->find($borrowernumber);
|
|
|
|
if ( $borrowernumber and not $patron ) {
|
|
output_and_exit( $input, $cookie, $template, 'unknown_patron' );
|
|
}
|
|
|
|
if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) {
|
|
my @providers = Koha::SMS::Providers->search( {}, { order_by => 'name' } )->as_list;
|
|
$template->param( sms_providers => \@providers );
|
|
}
|
|
|
|
my $modify = $input->param('modify');
|
|
my $delete = $input->param('cud-delete');
|
|
my $op = $input->param('op') || q{};
|
|
my $destination = $input->param('destination');
|
|
my $cardnumber = $input->param('cardnumber');
|
|
my $check_member = $input->param('check_member');
|
|
my $nodouble = $input->param('nodouble');
|
|
my $duplicate = $input->param('duplicate');
|
|
my $quickadd = $input->param('quickadd');
|
|
my $check_patron;
|
|
|
|
$nodouble = 1 if ($op eq 'edit_form' or $op eq 'duplicate'); # FIXME hack to represent fact that if we're
|
|
# modifying an existing patron, it ipso facto
|
|
# isn't a duplicate. Marking FIXME because this
|
|
# script needs to be refactored.
|
|
my $nok = $input->param('nok');
|
|
my $step = $input->param('step') || 0;
|
|
my @errors;
|
|
my $borrower_data;
|
|
my $NoUpdateLogin;
|
|
my $NoUpdateEmail;
|
|
my $CanUpdatePasswordExpiration;
|
|
my $CanUpdateProtectPatron;
|
|
my $userenv = C4::Context->userenv;
|
|
my @messages;
|
|
|
|
## Deal with guarantor stuff
|
|
$template->param( relationships => $patron->guarantor_relationships ) if $patron;
|
|
|
|
my $guarantor_id = $input->param('guarantor_id');
|
|
my $guarantor = undef;
|
|
$guarantor = Koha::Patrons->find( $guarantor_id ) if $guarantor_id;
|
|
$template->param( guarantor => $guarantor );
|
|
|
|
#Search existing guarantor id(s) and new ones from params
|
|
my @guarantors;
|
|
my @new_guarantor_ids = grep { $_ ne '' } $input->multi_param('new_guarantor_id');
|
|
|
|
foreach my $new_guarantor_id (@new_guarantor_ids) {
|
|
my $new_guarantor = Koha::Patrons->find( { borrowernumber => $new_guarantor_id } );
|
|
push @guarantors, $new_guarantor;
|
|
}
|
|
|
|
my @existing_guarantors = $patron ? $patron->guarantor_relationships()->guarantors->as_list : ();
|
|
push @guarantors, @existing_guarantors;
|
|
|
|
## Deal with debarments
|
|
$template->param(
|
|
restriction_types => scalar Koha::Patron::Restriction::Types->search()
|
|
);
|
|
my @debarments_to_remove = $input->multi_param('remove_debarment');
|
|
foreach my $d ( @debarments_to_remove ) {
|
|
DelDebarment( $d );
|
|
}
|
|
if ( $input->param('add_debarment') ) {
|
|
|
|
my $expiration = $input->param('debarred_expiration');
|
|
$expiration =
|
|
$expiration
|
|
? dt_from_string($expiration)->ymd
|
|
: undef;
|
|
|
|
AddDebarment(
|
|
{
|
|
borrowernumber => $borrowernumber,
|
|
type => scalar $input->param('debarred_type') // 'MANUAL',
|
|
comment => scalar $input->param('debarred_comment'),
|
|
expiration => $expiration,
|
|
}
|
|
);
|
|
}
|
|
|
|
$template->param("uppercasesurnames" => C4::Context->preference('uppercasesurnames'));
|
|
|
|
# function to designate mandatory fields (visually with css)
|
|
my $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField");
|
|
my @field_check=split(/\|/,$check_BorrowerMandatoryField);
|
|
foreach (@field_check) {
|
|
$template->param( "mandatory$_" => 1 );
|
|
}
|
|
# function to designate unwanted fields
|
|
my $check_BorrowerUnwantedField=C4::Context->preference("BorrowerUnwantedField");
|
|
@field_check=split(/\|/,$check_BorrowerUnwantedField);
|
|
foreach (@field_check) {
|
|
next unless m/\w/o;
|
|
$template->param( "no$_" => 1 );
|
|
}
|
|
$template->param( "quickadd" => 1 ) if ( $quickadd );
|
|
$template->param( "duplicate" => 1 ) if ( $op eq 'duplicate' );
|
|
$template->param( "checked" => 1 ) if ( defined($nodouble) && $nodouble eq 1 );
|
|
if ( $op eq 'edit_form' or $op eq 'cud-save' or $op eq 'duplicate' ) {
|
|
my $logged_in_user = Koha::Patrons->find( $loggedinuser );
|
|
output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
|
|
|
|
# check permission to modify email info.
|
|
if ( $patron->is_superlibrarian && !$logged_in_user->is_superlibrarian ) {
|
|
$NoUpdateEmail = 1;
|
|
}
|
|
if ($logged_in_user->is_superlibrarian) {
|
|
$CanUpdatePasswordExpiration = 1;
|
|
$CanUpdateProtectPatron = 1;
|
|
}
|
|
|
|
$borrower_data = $patron->unblessed;
|
|
}
|
|
|
|
my $categorycode = $input->param('categorycode') || $borrower_data->{'categorycode'};
|
|
my $category = Koha::Patron::Categories->find($categorycode);
|
|
$template->param( patron_category => $category );
|
|
|
|
# if a add or modify is requested => check validity of data.
|
|
%data = %$borrower_data if ($borrower_data);
|
|
|
|
# initialize %newdata
|
|
my %newdata; # comes from $input->param()
|
|
if ( $op eq 'cud-insert' || $op eq 'edit_form' || $op eq 'cud-save' || $op eq 'duplicate' ) {
|
|
my @names = ( $borrower_data && $op ne 'cud-save' ) ? keys %$borrower_data : $input->param();
|
|
foreach my $key (@names) {
|
|
if (defined $input->param($key)) {
|
|
$newdata{$key} = $input->param($key);
|
|
}
|
|
}
|
|
|
|
# check permission to modify login info.
|
|
if (ref($borrower_data) && ($category->category_type eq 'S') && ! (C4::Auth::haspermission($userenv->{'id'},{'staffaccess'=>1})) ) {
|
|
$NoUpdateLogin = 1;
|
|
}
|
|
}
|
|
|
|
# remove keys from %newdata that is not part of patron's attributes
|
|
{
|
|
my @keys_to_delete = (
|
|
qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|updated_on|lastseen|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935
|
|
qr/^BorrowerMandatoryField$/,
|
|
qr/^check_member$/,
|
|
qr/^destination$/,
|
|
qr/^nodouble$/,
|
|
qr/^op$/,
|
|
qr/^save$/,
|
|
qr/^updtype$/,
|
|
qr/^SMSnumber$/,
|
|
qr/^setting_extended_patron_attributes$/,
|
|
qr/^setting_messaging_prefs$/,
|
|
qr/^digest$/,
|
|
qr/^modify$/,
|
|
qr/^step$/,
|
|
qr/^\d+$/,
|
|
qr/^\d+-DAYS/,
|
|
qr/^patron_attr_/,
|
|
qr/^csrf_token$/,
|
|
qr/^add_debarment$/, qr/^debarred_comment$/,qr/^debarred_expiration$/, qr/^debarred_type$/, qr/^remove_debarment$/, # We already dealt with debarments previously
|
|
qr/^housebound_chooser$/, qr/^housebound_deliverer$/,
|
|
qr/^select_city$/,
|
|
qr/^new_guarantor_/,
|
|
qr/^guarantor_firstname$/,
|
|
qr/^guarantor_surname$/,
|
|
qr/^delete_guarantor$/,
|
|
);
|
|
push @keys_to_delete,
|
|
map { qr/^$_$/ }
|
|
grep { $_ ne 'dateexpiry' } split( /\s*\|\s*/, C4::Context->preference('BorrowerUnwantedField') || q{} );
|
|
push @keys_to_delete, qr/^password_expiration_date$/ unless $CanUpdatePasswordExpiration;
|
|
push @keys_to_delete, qr/^protected$/ unless $CanUpdateProtectPatron;
|
|
for my $regexp (@keys_to_delete) {
|
|
for (keys %newdata) {
|
|
delete($newdata{$_}) if /$regexp/;
|
|
}
|
|
}
|
|
}
|
|
|
|
# Test uniqueness of surname, firstname and dateofbirth
|
|
if ( ( $op eq 'cud-insert' ) and !$nodouble ) {
|
|
my @dup_fields = split '\|', C4::Context->preference('PatronDuplicateMatchingAddFields');
|
|
my $conditions;
|
|
for my $f ( @dup_fields ) {
|
|
$conditions->{$f} = $newdata{$f} if $newdata{$f};
|
|
}
|
|
$nodouble = 1;
|
|
my $patrons = Koha::Patrons->search($conditions);
|
|
if ( $patrons->count > 0) {
|
|
$nodouble = 0;
|
|
$check_patron = $patrons->next;
|
|
$check_member = $check_patron->borrowernumber;
|
|
}
|
|
}
|
|
|
|
#Attempt to delete guarantors
|
|
my @delete_guarantor = $input->multi_param('delete_guarantor');
|
|
if (@delete_guarantor) {
|
|
if ( C4::Context->preference('ChildNeedsGuarantor')
|
|
&& scalar @guarantors - scalar @delete_guarantor == 0 )
|
|
{
|
|
push @errors, 'ERROR_cannot_delete_guarantor';
|
|
} else {
|
|
foreach my $id (@delete_guarantor) {
|
|
my $r = Koha::Patron::Relationships->find($id);
|
|
$r->delete() if $r;
|
|
}
|
|
}
|
|
}
|
|
|
|
#Check if guarantor requirements are met
|
|
my $valid_guarantor = @guarantors ? @guarantors : $newdata{'contactname'};
|
|
if ( ( $op eq 'cud-save' || $op eq 'cud-insert' )
|
|
&& C4::Context->preference('ChildNeedsGuarantor')
|
|
&& ( $category->category_type eq 'C' || $category->can_be_guarantee )
|
|
&& !$valid_guarantor )
|
|
{
|
|
push @errors, 'ERROR_child_no_guarantor';
|
|
}
|
|
|
|
foreach my $guarantor (@guarantors) {
|
|
if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) && $guarantor->is_child || $guarantor->category->can_be_guarantee ) {
|
|
push @errors, 'ERROR_guarantor_is_guarantee';
|
|
}
|
|
}
|
|
|
|
###############test to take the right zipcode, country and city name ##############
|
|
# set only if parameter was passed from the form
|
|
$newdata{'city'} = $input->param('city') if defined($input->param('city'));
|
|
$newdata{'zipcode'} = $input->param('zipcode') if defined($input->param('zipcode'));
|
|
$newdata{'country'} = $input->param('country') if defined($input->param('country'));
|
|
|
|
$newdata{'lang'} = $input->param('lang') if defined($input->param('lang'));
|
|
|
|
# Bug 32426 removed the fake_patron code here that filled $newdata{userid}. We should leave it now to patron->store.
|
|
|
|
my $extended_patron_attributes;
|
|
if ($op eq 'cud-save' || $op eq 'cud-insert'){
|
|
|
|
# If the cardnumber is blank, treat it as null.
|
|
$newdata{'cardnumber'} = undef if $newdata{'cardnumber'} =~ /^\s*$/;
|
|
|
|
my $new_barcode = $newdata{'cardnumber'};
|
|
Koha::Plugins->call( 'patron_barcode_transform', \$new_barcode );
|
|
|
|
$newdata{'cardnumber'} = $new_barcode;
|
|
|
|
my $is_valid = Koha::Policy::Patrons::Cardnumber->is_valid($newdata{cardnumber}, $patron );
|
|
unless ($is_valid) {
|
|
for my $m ( @{ $is_valid->messages } ) {
|
|
my $message = $m->message;
|
|
if ( $message eq 'already_exists' ) {
|
|
$template->param( ERROR_cardnumber_already_exists => 1 );
|
|
} elsif ( $message eq 'invalid_length' ) {
|
|
$template->param( ERROR_cardnumber_length => 1 );
|
|
}
|
|
}
|
|
}
|
|
|
|
my $dateofbirth;
|
|
if ($op eq 'cud-save' && $step == 3) {
|
|
$dateofbirth = $patron->dateofbirth;
|
|
}
|
|
else {
|
|
$dateofbirth = $newdata{dateofbirth};
|
|
}
|
|
|
|
if ( $dateofbirth ) {
|
|
my $patron = Koha::Patron->new({ dateofbirth => $dateofbirth });
|
|
my $age = $patron->get_age;
|
|
my ($low,$high) = ($category->dateofbirthrequired, $category->upperagelimit);
|
|
if (($high && ($age > $high)) or ($age < $low)) {
|
|
push @errors, 'ERROR_age_limitations';
|
|
$template->param( age_low => $low);
|
|
$template->param( age_high => $high);
|
|
}
|
|
}
|
|
|
|
if (C4::Context->preference("IndependentBranches")) {
|
|
unless ( C4::Context->IsSuperLibrarian() ){
|
|
unless (!$newdata{'branchcode'} || $userenv->{branch} eq $newdata{'branchcode'}){
|
|
push @errors, "ERROR_branch";
|
|
}
|
|
}
|
|
}
|
|
|
|
# Bug 32426 removed the userid unique-check here. Postpone it to patron->store.
|
|
|
|
my $password = $input->param('password');
|
|
my $password2 = $input->param('password2');
|
|
push @errors, "ERROR_password_mismatch" if ( $password ne $password2 );
|
|
|
|
if ( $password and $password ne '****' ) {
|
|
my ( $is_valid, $error ) = Koha::AuthUtils::is_password_valid( $password, $category );
|
|
unless ( $is_valid ) {
|
|
push @errors, 'ERROR_password_too_short' if $error eq 'too_short';
|
|
push @errors, 'ERROR_password_too_weak' if $error eq 'too_weak';
|
|
push @errors, 'ERROR_password_has_whitespaces' if $error eq 'has_whitespaces';
|
|
}
|
|
}
|
|
|
|
# Validate emails
|
|
my $emailprimary = $input->param('email');
|
|
my $emailsecondary = $input->param('emailpro');
|
|
my $emailalt = $input->param('B_email');
|
|
|
|
if ($emailprimary) {
|
|
push (@errors, "ERROR_bad_email") unless Koha::Email->is_valid($emailprimary);
|
|
}
|
|
if ($emailsecondary) {
|
|
push (@errors, "ERROR_bad_email_secondary") unless Koha::Email->is_valid($emailsecondary);
|
|
}
|
|
if ($emailalt) {
|
|
push (@errors, "ERROR_bad_email_alternative") unless Koha::Email->is_valid($emailalt);
|
|
}
|
|
|
|
if (C4::Context->preference('ExtendedPatronAttributes') and $input->param('setting_extended_patron_attributes')) {
|
|
$extended_patron_attributes = parse_extended_patron_attributes($input);
|
|
for my $attr ( @$extended_patron_attributes ) {
|
|
$attr->{borrowernumber} = $borrowernumber if $borrowernumber;
|
|
my $attribute = Koha::Patron::Attribute->new($attr);
|
|
if ( !$attribute->unique_ok ) {
|
|
push @errors, "ERROR_extended_unique_id_failed";
|
|
my $attr_type = Koha::Patron::Attribute::Types->find($attr->{code});
|
|
$template->param(
|
|
ERROR_extended_unique_id_failed_code => $attr->{code},
|
|
ERROR_extended_unique_id_failed_value => $attr->{attribute},
|
|
ERROR_extended_unique_id_failed_description => $attr_type->description()
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
elsif ( $borrowernumber ) {
|
|
$extended_patron_attributes = Koha::Patrons->find($borrowernumber)->extended_attributes->unblessed;
|
|
}
|
|
|
|
if ( ($op eq 'edit_form' || $op eq 'cud-insert' || $op eq 'cud-save'|| $op eq 'duplicate') and ($step == 0 or $step == 3 )){
|
|
unless ($newdata{'dateexpiry'}){
|
|
$newdata{'dateexpiry'} = $category->get_expiry_date( $newdata{dateenrolled} ) if $category;
|
|
}
|
|
}
|
|
|
|
# BZ 14683: Do not mixup mobile [read: other phone] with smsalertnumber
|
|
my $sms = $input->param('SMSnumber');
|
|
if ( defined $sms ) {
|
|
$newdata{smsalertnumber} = $sms;
|
|
}
|
|
|
|
### Error checks should happen before this line.
|
|
$nok = $nok || scalar(@errors);
|
|
if ((!$nok) and $nodouble and ($op eq 'cud-insert' or $op eq 'cud-save')){
|
|
my $success;
|
|
if ($op eq 'cud-insert'){
|
|
# we know it's not a duplicate borrowernumber or there would already be an error
|
|
delete $newdata{password2};
|
|
$success = 1;
|
|
$patron = try {
|
|
Koha::Patron->new( \%newdata )->store( { guarantors => \@guarantors } );
|
|
} catch {
|
|
$success = 0;
|
|
$nok = 1;
|
|
if( ref($_) eq 'Koha::Exceptions::Patron::InvalidUserid' ) {
|
|
push @errors, "ERROR_login_exist";
|
|
} else {
|
|
# FIXME Urgent error handling here, we cannot fail without relevant feedback
|
|
# Lot of code will need to be removed from this script to handle exceptions raised by Koha::Patron->store
|
|
warn "Patron creation failed! - $_"; # Maybe we must die instead of just warn
|
|
push @messages, {error => 'error_on_insert_patron'};
|
|
}
|
|
$op = "add_form";
|
|
return;
|
|
};
|
|
|
|
if ( $success ) {
|
|
add_guarantors( $patron, $input );
|
|
$borrowernumber = $patron->borrowernumber;
|
|
$newdata{'borrowernumber'} = $borrowernumber;
|
|
delete $newdata{password};
|
|
}
|
|
|
|
# If 'AutoEmailNewUser' syspref is on, email user their account details from the 'notice' that matches the user's branchcode.
|
|
if ( $patron && C4::Context->preference("AutoEmailNewUser") ) {
|
|
#look for defined primary email address, if blank - attempt to use borr.email and borr.emailpro instead
|
|
my $emailaddr = $patron->notice_email_address;
|
|
# if we manage to find a valid email address, send notice
|
|
if ($emailaddr) {
|
|
eval {
|
|
my $letter = GetPreparedLetter(
|
|
module => 'members',
|
|
letter_code => 'WELCOME',
|
|
branchcode => $patron->branchcode,,
|
|
lang => $patron->lang || 'default',
|
|
tables => {
|
|
'branches' => $patron->branchcode,
|
|
'borrowers' => $patron->borrowernumber,
|
|
},
|
|
want_librarian => 1,
|
|
) or return;
|
|
|
|
my $message_id = EnqueueLetter(
|
|
{
|
|
letter => $letter,
|
|
borrowernumber => $patron->id,
|
|
to_address => $emailaddr,
|
|
message_transport_type => 'email'
|
|
}
|
|
);
|
|
SendQueuedMessages( { message_id => $message_id } ) if $message_id;
|
|
};
|
|
if ($@) {
|
|
$template->param( error_alert => $@ );
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( $patron && (C4::Context->preference('EnhancedMessagingPreferences') and $input->param('setting_messaging_prefs')) ) {
|
|
C4::Form::MessagingPreferences::handle_form_action($input, { borrowernumber => $borrowernumber }, $template, 1, $newdata{'categorycode'});
|
|
}
|
|
|
|
# Create HouseboundRole if necessary.
|
|
# Borrower did not exist, so HouseboundRole *cannot* yet exist.
|
|
my ( $hsbnd_chooser, $hsbnd_deliverer ) = ( 0, 0 );
|
|
$hsbnd_chooser = 1 if $input->param('housebound_chooser');
|
|
$hsbnd_deliverer = 1 if $input->param('housebound_deliverer');
|
|
# Only create a HouseboundRole if patron has a role.
|
|
if ( $patron && ( $hsbnd_chooser || $hsbnd_deliverer ) ) {
|
|
Koha::Patron::HouseboundRole->new({
|
|
borrowernumber_id => $borrowernumber,
|
|
housebound_chooser => $hsbnd_chooser,
|
|
housebound_deliverer => $hsbnd_deliverer,
|
|
})->store;
|
|
}
|
|
|
|
} elsif ($op eq 'cud-save') {
|
|
|
|
if ($NoUpdateLogin) {
|
|
delete $newdata{'password'};
|
|
delete $newdata{'userid'};
|
|
}
|
|
|
|
$patron = Koha::Patrons->find( $borrowernumber );
|
|
|
|
if ($NoUpdateEmail) {
|
|
delete $newdata{'email'};
|
|
delete $newdata{'emailpro'};
|
|
delete $newdata{'B_email'};
|
|
}
|
|
|
|
delete $newdata{password2};
|
|
|
|
try {
|
|
$patron->set( \%newdata )->store( { guarantors => \@guarantors } ) if scalar( keys %newdata ) > 1;
|
|
# bug 4508 - avoid crash if we're not updating any columns in the borrowers table (editing patron attrs or msg prefs)
|
|
$success = 1;
|
|
} catch {
|
|
$success = 0;
|
|
$nok = 1;
|
|
if( ref($_) eq 'Koha::Exceptions::Patron::InvalidUserid' ) {
|
|
push @errors, "ERROR_login_exist";
|
|
} else {
|
|
warn "Patron modification failed! - $@"; # Maybe we must die instead of just warn
|
|
push @messages, {error => 'error_on_update_patron'};
|
|
}
|
|
$op = 'edit_form';
|
|
};
|
|
|
|
if ( $success ) {
|
|
|
|
# Update or create our HouseboundRole if necessary.
|
|
my $housebound_role = Koha::Patron::HouseboundRoles->find($borrowernumber);
|
|
my ( $hsbnd_chooser, $hsbnd_deliverer ) = ( 0, 0 );
|
|
$hsbnd_chooser = 1 if $input->param('housebound_chooser');
|
|
$hsbnd_deliverer = 1 if $input->param('housebound_deliverer');
|
|
if ( $housebound_role ) {
|
|
if ( $hsbnd_chooser || $hsbnd_deliverer ) {
|
|
# Update our HouseboundRole.
|
|
$housebound_role
|
|
->housebound_chooser($hsbnd_chooser)
|
|
->housebound_deliverer($hsbnd_deliverer)
|
|
->store;
|
|
} else {
|
|
$housebound_role->delete; # No longer needed.
|
|
}
|
|
} else {
|
|
# Only create a HouseboundRole if patron has a role.
|
|
if ( $hsbnd_chooser || $hsbnd_deliverer ) {
|
|
$housebound_role = Koha::Patron::HouseboundRole->new({
|
|
borrowernumber_id => $borrowernumber,
|
|
housebound_chooser => $hsbnd_chooser,
|
|
housebound_deliverer => $hsbnd_deliverer,
|
|
})->store;
|
|
}
|
|
}
|
|
|
|
# should never raise an exception as password validity is checked above
|
|
my $password = $newdata{password};
|
|
if ( $password and $password ne '****' ) {
|
|
$patron->set_password({ password => $password });
|
|
}
|
|
|
|
add_guarantors( $patron, $input );
|
|
if (C4::Context->preference('EnhancedMessagingPreferences') and $input->param('setting_messaging_prefs')) {
|
|
C4::Form::MessagingPreferences::handle_form_action($input, { borrowernumber => $borrowernumber }, $template);
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( $success ) {
|
|
if (C4::Context->preference('ExtendedPatronAttributes') and $input->param('setting_extended_patron_attributes')) {
|
|
$patron->extended_attributes->filter_by_branch_limitations->delete;
|
|
$patron->extended_attributes($extended_patron_attributes);
|
|
}
|
|
|
|
if ( $destination eq 'circ' and not C4::Auth::haspermission( C4::Context->userenv->{id}, { circulate => 'circulate_remaining_permissions' } ) ) {
|
|
# If we want to redirect to circulation.pl and need to check if the logged in user has the necessary permission
|
|
$destination = 'not_circ';
|
|
}
|
|
print scalar( $destination eq "circ" )
|
|
? $input->redirect(
|
|
"/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber")
|
|
: $input->redirect(
|
|
"/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber"
|
|
);
|
|
exit; # You can only send 1 redirect! After that, content or other headers don't matter.
|
|
}
|
|
}
|
|
|
|
if ($delete){
|
|
print $input->redirect("/cgi-bin/koha/deletemem.pl?member=$borrowernumber");
|
|
exit; # same as above
|
|
}
|
|
|
|
if ($nok or !$nodouble){
|
|
$op = 'add_form' if ( $op eq 'cud-insert' );
|
|
$op = 'edit_form' if ( $op eq 'cud-save' );
|
|
%data=%newdata;
|
|
unless ($step){
|
|
$template->param( step_1 => 1,step_2 => 1,step_3 => 1, step_4 => 1, step_5 => 1, step_6 => 1, step_7 => 1 );
|
|
}
|
|
}
|
|
|
|
$template->param( "op" => $op );
|
|
|
|
if (C4::Context->preference("IndependentBranches")) {
|
|
my $userenv = C4::Context->userenv;
|
|
if ( !C4::Context->IsSuperLibrarian() && $data{'branchcode'} ) {
|
|
unless ($userenv->{branch} eq $data{'branchcode'}){
|
|
print $input->redirect("/cgi-bin/koha/members/members-home.pl");
|
|
exit;
|
|
}
|
|
}
|
|
}
|
|
|
|
# Define the fields to be pre-filled in guarantee records
|
|
my $prefillguarantorfields=C4::Context->preference("PrefillGuaranteeField");
|
|
my @prefill_fields=split(/\,/,$prefillguarantorfields);
|
|
$template->param(
|
|
prefill_fields => \@prefill_fields,
|
|
to_api_mapping => Koha::Patron->new->to_api_mapping
|
|
);
|
|
|
|
if ($op eq 'add_form'){
|
|
if ($guarantor_id) {
|
|
foreach (@prefill_fields) {
|
|
$newdata{$_} = $guarantor->$_;
|
|
}
|
|
}
|
|
$template->param( updtype => 'I', step_1=>1, step_2=>1, step_3=>1, step_4=>1, step_5 => 1, step_6 => 1, step_7 => 1);
|
|
}
|
|
if ($op eq 'edit_form') {
|
|
$template->param( updtype => 'M',modify => 1 );
|
|
$template->param( step_1=>1, step_2=>1, step_3=>1, step_4=>1, step_5 => 1, step_6 => 1, step_7 => 1) unless $step;
|
|
if ( $step == 4 ) {
|
|
$template->param( categorycode => $borrower_data->{'categorycode'} );
|
|
}
|
|
}
|
|
if ( $op eq "duplicate" ) {
|
|
$template->param( updtype => 'I' );
|
|
$template->param( step_1 => 1, step_2 => 1, step_3 => 1, step_4 => 1, step_5 => 1, step_6 => 1, step_7 => 1 ) unless $step;
|
|
$data{'cardnumber'} = "";
|
|
}
|
|
|
|
if(!defined($data{'sex'})){
|
|
$template->param( none => 1);
|
|
} elsif($data{'sex'} eq 'F'){
|
|
$template->param( female => 1);
|
|
} elsif ($data{'sex'} eq 'M'){
|
|
$template->param( male => 1);
|
|
} elsif ($data{'sex'} eq 'O') {
|
|
$template->param( other => 1);
|
|
} else {
|
|
$template->param( none => 1);
|
|
}
|
|
|
|
##Now all the data to modify a member.
|
|
|
|
my $patron_categories = Koha::Patron::Categories->search_with_library_limits(
|
|
{
|
|
category_type => [qw(C A S P I X)],
|
|
( $guarantor_id ? ( can_be_guarantee => 1 ) : () )
|
|
},
|
|
{ order_by => ['categorycode'] }
|
|
);
|
|
my $no_categories = ! $patron_categories->count;
|
|
my $categories = {};
|
|
my @patron_categories = $patron_categories->as_list;
|
|
# When adding a guarantor we don't have a category yet, and only want to choose from the eligible categories
|
|
unless ( !$category || $patron_categories->find( $category->id ) ){
|
|
$template->param( limited_category => 1 );
|
|
push @patron_categories, $category;
|
|
}
|
|
foreach my $patron_category ( @patron_categories ) {
|
|
push @{ $categories->{ $patron_category->category_type } }, $patron_category;
|
|
}
|
|
|
|
$template->param(
|
|
patron_categories => $categories,
|
|
no_categories => $no_categories,
|
|
);
|
|
|
|
my $cities = Koha::Cities->search( {}, { order_by => 'city_name' } );
|
|
$template->param(
|
|
cities => $cities,
|
|
);
|
|
|
|
my $default_borrowertitle = '';
|
|
unless ( $op eq 'duplicate' ) { $default_borrowertitle=$data{'title'} }
|
|
|
|
my @relationships = split /,|\|/, C4::Context->preference('borrowerRelationship');
|
|
my @relshipdata;
|
|
while (@relationships) {
|
|
my $relship = shift @relationships || '';
|
|
my %row = ('relationship' => $relship);
|
|
if (defined($data{'relationship'}) and $data{'relationship'} eq $relship) {
|
|
$row{'selected'}=' selected';
|
|
} else {
|
|
$row{'selected'}='';
|
|
}
|
|
push(@relshipdata, \%row);
|
|
}
|
|
|
|
# get Branch Loop
|
|
# in modify mod: userbranch value comes from borrowers table
|
|
# in add mod: userbranch value comes from branches table (ip correspondence)
|
|
|
|
my $userbranch = '';
|
|
if (C4::Context->userenv && C4::Context->userenv->{'branch'}) {
|
|
$userbranch = C4::Context->userenv->{'branch'};
|
|
}
|
|
|
|
if (defined ($data{'branchcode'}) and ( $op eq 'edit_form' || $op eq 'duplicate' || $op eq 'add_form' )) {
|
|
$userbranch = $data{'branchcode'};
|
|
}
|
|
$template->param( userbranch => $userbranch );
|
|
|
|
my $no_add;
|
|
if ( Koha::Libraries->search->count < 1 ){
|
|
$no_add = 1;
|
|
$template->param(no_branches => 1);
|
|
}
|
|
if($no_categories){
|
|
$no_add = 1;
|
|
$template->param(no_categories => 1);
|
|
}
|
|
$template->param(no_add => $no_add);
|
|
# --------------------------------------------------------------------------------------------------------
|
|
|
|
$template->param( sort1 => $data{'sort1'});
|
|
$template->param( sort2 => $data{'sort2'});
|
|
$template->param( autorenew => $data{'autorenew'});
|
|
|
|
if ($nok) {
|
|
foreach my $error (@errors) {
|
|
$template->param($error) || $template->param( $error => 1);
|
|
}
|
|
$template->param(nok => 1);
|
|
|
|
#Prevent losing guarantor data if error occurs
|
|
my @new_guarantors;
|
|
my @new_guarantor_id = $input->multi_param('new_guarantor_id');
|
|
my @new_guarantor_relationship = $input->multi_param('new_guarantor_relationship');
|
|
foreach my $gid ( @new_guarantor_id ) {
|
|
my $patron = Koha::Patrons->find( $gid );
|
|
my $relationship = shift( @new_guarantor_relationship );
|
|
next unless $patron;
|
|
my $g = { patron => $patron, relationship => $relationship };
|
|
push( @new_guarantors, $g );
|
|
}
|
|
$template->param( new_guarantors => \@new_guarantors );
|
|
}
|
|
|
|
#Formatting data for display
|
|
|
|
if (!defined($data{'dateenrolled'}) or $data{'dateenrolled'} eq ''){
|
|
$data{'dateenrolled'} = dt_from_string;
|
|
}
|
|
if ( $op eq 'duplicate' ) {
|
|
$data{'dateenrolled'} = dt_from_string;
|
|
$data{dateexpiry} = $category->get_expiry_date( $data{dateenrolled} );
|
|
}
|
|
if (C4::Context->preference('uppercasesurnames')) {
|
|
$data{'surname'} &&= uc( $data{'surname'} );
|
|
$data{'contactname'} &&= uc( $data{'contactname'} );
|
|
}
|
|
|
|
if ( C4::Context->preference('ExtendedPatronAttributes') ) {
|
|
patron_attributes_form( $template, $extended_patron_attributes, $op );
|
|
}
|
|
|
|
if (C4::Context->preference('EnhancedMessagingPreferences')) {
|
|
if ($op eq 'add_form') {
|
|
C4::Form::MessagingPreferences::set_form_values({ categorycode => $categorycode }, $template);
|
|
} else {
|
|
C4::Form::MessagingPreferences::set_form_values({ borrowernumber => $borrowernumber }, $template);
|
|
}
|
|
$template->param(SMSSendDriver => C4::Context->preference("SMSSendDriver"));
|
|
$template->param(SMSnumber => $data{'smsalertnumber'} );
|
|
$template->param(TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification"));
|
|
}
|
|
|
|
$template->param( borrower_data => \%data );
|
|
$template->param( "show_guarantor" => $category ? $category->can_be_guarantee : 1); # associate with step to know where you are
|
|
$template->param( "step_$step" => 1) if $step; # associate with step to know where u are
|
|
$template->param( step => $step ) if $step; # associate with step to know where u are
|
|
|
|
$template->param(
|
|
BorrowerMandatoryField => C4::Context->preference("BorrowerMandatoryField"),#field to test with javascript
|
|
destination => $destination,#to know where u come from and where u must go in redirect
|
|
check_member => $check_member,#to know if the borrower already exist(=>1) or not (=>0)
|
|
check_patron => $check_patron
|
|
);
|
|
|
|
$template->param(
|
|
patron => $patron ? $patron : \%newdata, # Used by address include templates now
|
|
nodouble => $nodouble,
|
|
borrowernumber => $borrowernumber, #register number
|
|
relshiploop => \@relshipdata,
|
|
btitle => $default_borrowertitle,
|
|
modify => $modify,
|
|
nok => $nok, #flag to know if an error
|
|
NoUpdateLogin => $NoUpdateLogin,
|
|
NoUpdateEmail => $NoUpdateEmail,
|
|
CanUpdatePasswordExpiration => $CanUpdatePasswordExpiration,
|
|
CanUpdateProtectPatron => $CanUpdateProtectPatron,
|
|
);
|
|
|
|
# HouseboundModule data
|
|
$template->param(
|
|
housebound_role => Koha::Patron::HouseboundRoles->find($borrowernumber),
|
|
);
|
|
|
|
if(defined($data{'flags'})){
|
|
$template->param(flags=>$data{'flags'});
|
|
}
|
|
if(defined($data{'contacttitle'})){
|
|
$template->param("contacttitle_" . $data{'contacttitle'} => "SELECTED");
|
|
}
|
|
|
|
|
|
my ( $min, $max ) = Koha::Policy::Patrons::Cardnumber->get_valid_length();
|
|
if ( defined $min ) {
|
|
$template->param(
|
|
minlength_cardnumber => $min,
|
|
maxlength_cardnumber => $max
|
|
);
|
|
}
|
|
|
|
if ( C4::Context->preference('TranslateNotices') ) {
|
|
my $translated_languages = C4::Languages::getTranslatedLanguages( 'opac', C4::Context->preference('template') );
|
|
$template->param( languages => $translated_languages );
|
|
}
|
|
|
|
$template->param( messages => \@messages );
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
|
|
sub parse_extended_patron_attributes {
|
|
my ($input) = @_;
|
|
my @patron_attr = grep { /^patron_attr_\d+$/ } $input->multi_param();
|
|
|
|
my @attr = ();
|
|
my %dups = ();
|
|
foreach my $key (@patron_attr) {
|
|
my $value = $input->param($key);
|
|
next unless defined($value) and $value ne '';
|
|
my $code = $input->param("${key}_code");
|
|
next if exists $dups{$code}->{$value};
|
|
$dups{$code}->{$value} = 1;
|
|
push @attr, { code => $code, attribute => $value };
|
|
}
|
|
return \@attr;
|
|
}
|
|
|
|
sub patron_attributes_form {
|
|
my $template = shift;
|
|
my $attributes = shift;
|
|
my $op = shift;
|
|
|
|
my $library_id = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
|
|
my $attribute_types = Koha::Patron::Attribute::Types->search_with_library_limits({}, {}, $library_id);
|
|
if ( $attribute_types->count == 0 ) {
|
|
$template->param(no_patron_attribute_types => 1);
|
|
return;
|
|
}
|
|
|
|
# map patron's attributes into a more convenient structure
|
|
my %attr_hash = ();
|
|
foreach my $attr (@$attributes) {
|
|
push @{ $attr_hash{$attr->{code}} }, $attr;
|
|
}
|
|
|
|
my @attribute_loop = ();
|
|
my $i = 0;
|
|
my %items_by_class;
|
|
while ( my ( $attr_type ) = $attribute_types->next ) {
|
|
my $entry = {
|
|
class => $attr_type->class(),
|
|
code => $attr_type->code(),
|
|
description => $attr_type->description(),
|
|
repeatable => $attr_type->repeatable(),
|
|
category => $attr_type->authorised_value_category(),
|
|
category_code => $attr_type->category_code(),
|
|
mandatory => $attr_type->mandatory(),
|
|
is_date => $attr_type->is_date(),
|
|
};
|
|
if (exists $attr_hash{$attr_type->code()}) {
|
|
foreach my $attr (@{ $attr_hash{$attr_type->code()} }) {
|
|
my $newentry = { %$entry };
|
|
$newentry->{value} = $attr->{attribute};
|
|
$newentry->{use_dropdown} = 0;
|
|
if ($attr_type->authorised_value_category()) {
|
|
$newentry->{use_dropdown} = 1;
|
|
$newentry->{auth_val_loop} = GetAuthorisedValues($attr_type->authorised_value_category(), $attr->{attribute});
|
|
}
|
|
$i++;
|
|
undef $newentry->{value} if ($attr_type->unique_id() && $op eq 'duplicate');
|
|
$newentry->{form_id} = "patron_attr_$i";
|
|
push @{$items_by_class{$attr_type->class()}}, $newentry;
|
|
}
|
|
} else {
|
|
$i++;
|
|
my $newentry = { %$entry };
|
|
if ($attr_type->authorised_value_category()) {
|
|
$newentry->{use_dropdown} = 1;
|
|
$newentry->{auth_val_loop} = GetAuthorisedValues($attr_type->authorised_value_category());
|
|
}
|
|
$newentry->{form_id} = "patron_attr_$i";
|
|
push @{$items_by_class{$attr_type->class()}}, $newentry;
|
|
}
|
|
}
|
|
for my $class ( sort keys %items_by_class ) {
|
|
my $av = Koha::AuthorisedValues->search({ category => 'PA_CLASS', authorised_value => $class });
|
|
my $lib = $av->count ? $av->next->lib : $class;
|
|
push @attribute_loop, {
|
|
class => $class,
|
|
items => $items_by_class{$class},
|
|
lib => $lib,
|
|
}
|
|
}
|
|
|
|
$template->param(patron_attributes => \@attribute_loop);
|
|
|
|
}
|
|
|
|
sub add_guarantors {
|
|
my ( $patron, $input ) = @_;
|
|
|
|
my @new_guarantor_id = $input->multi_param('new_guarantor_id');
|
|
my @new_guarantor_relationship = $input->multi_param('new_guarantor_relationship');
|
|
|
|
for ( my $i = 0 ; $i < scalar @new_guarantor_id ; $i++ ) {
|
|
my $guarantor_id = $new_guarantor_id[$i];
|
|
my $relationship = $new_guarantor_relationship[$i];
|
|
|
|
next unless $guarantor_id;
|
|
|
|
my $existing_relationship_count = Koha::Patron::Relationships->search(
|
|
{
|
|
guarantee_id => $patron->id,
|
|
guarantor_id => $guarantor_id,
|
|
}
|
|
)->count;
|
|
|
|
if ( $existing_relationship_count == 0 ) {
|
|
$patron->add_guarantor(
|
|
{
|
|
guarantor_id => $guarantor_id,
|
|
relationship => $relationship,
|
|
}
|
|
);
|
|
}
|
|
}
|
|
}
|