Koha/koha-tmpl/intranet-tmpl/prog
Katrin Fischer 8218653df7
Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account
When using sort1/sort2 with authorised values to create a pull down
list, there will be no empty entry unless one is manually added to
the authorised values list.

This is not a good default behaviour, as it can easily
cause errors on patron creation. Without the empty entry, the first
alphabetic value is pre-selected and will be saved if not explicitly
changed. It also doesn't allow to mark sort1/sort2 as mandatory,
as the value is always 'set', the required message won't be triggered.

This adds an empty parameter to av-build-dropbox.inc to allow selectively
adding this empty entry without causing side-effects in other places
this include is used.

To test:
- Create authorised values for either Bsort1 or Bsort2 authorised
  value category
- Create a new patron:
  - you should see a pull down list on one and an input field for the other
  - for the pull down list, there will be no empty entry and the first
    alphabetic value will be preselected
- Make your sort1 and sort2 mandatory using BorrowerMandatoryField
- Verify there is still on empty entry
- Apply patch
- Repeat tests and verify that the behaviour is as expected
  - There should now be an empty entry
  - When the field is marked mandatory and empty is left, the required
    warning will be shown.

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-04-20 12:28:04 +01:00
..
css Bug 25176: Compiled CSS 2020-04-20 12:17:44 +01:00
en Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account 2020-04-20 12:28:04 +01:00
img Bug 7882: Add ability to move and reorder fields in MARC editor 2020-01-03 16:27:59 +00:00
js Bug 23173: (follow-up) Display available partners 2020-04-06 11:04:59 +01:00
pdf Bug 5016: Fix some translation issues with English PDF order templates 2020-02-19 11:26:41 +00:00
sound