dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
117 lines
6.9 KiB
Text
117 lines
6.9 KiB
Text
[% USE Koha %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Web installer › Create Koha administrator patron</title>
|
|
[% INCLUDE 'installer-doc-head-close.inc' %]
|
|
[% INCLUDE 'validator-strings.inc' %]
|
|
[% INCLUDE 'installer-strings.inc' %]
|
|
<script type="text/javascript" src="[% interface | html %]/[% theme | html %]/js/onboarding.js"></script>
|
|
</head>
|
|
|
|
<body id="installer" class="installer">
|
|
<div class="container-fluid">
|
|
<div class="row">
|
|
<div id="onboarding-step3" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">
|
|
<h1 id="logo"><a href="#">Koha</a></h1>
|
|
<h2>Web installer › Create Koha administrator patron</h2>
|
|
|
|
[% INCLUDE 'onboarding_messages.inc' %]
|
|
|
|
<p>
|
|
Now we will create a patron with superlibrarian permissions. Log in with this to access Koha as a staff member with all permissions.
|
|
</p>
|
|
<form name="createpatron" id="createpatron" method="post" action="onboarding.pl">
|
|
<fieldset class="rows">
|
|
<input type="hidden" name="step" value="3" />
|
|
<input type="hidden" name="op" value="add_validate_patron" />
|
|
<h3>Administrator identity</h3>
|
|
<ol>
|
|
<li>
|
|
<label for="surname" class="required">Surname: </label>
|
|
<input type="text" id="surname" name="surname" value="[% surname | html %]" class="required" required="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="firstname" class="required">First name: </label>
|
|
<input type="text" name="firstname" id="firstname" size="20" value="[% firstname | html %]" class="required" required="required">
|
|
<span class="required">Required</span>
|
|
</li>
|
|
</ol>
|
|
|
|
<ol>
|
|
<li>
|
|
<label for="cardnumber" class="required">Card number: </label>
|
|
[% IF patrons && patrons > 1 %]
|
|
<input type="text" id="cardnumber" class="noEnterSubmit valid" name="cardnumber" value="[% newcardnumber | html %]" class="required" required="required">
|
|
[% ELSE %]
|
|
<input type="text" id="cardnumber" name="cardnumber" value="[% cardnumber | html %]" class="required" required="required">
|
|
[% END %]
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
|
|
<!--require a foreach loop to get all the values for the library that the user has either imported (in web installer) or created in the first step of this onboarding tool-->
|
|
<label for="libraries" class="required"> Library: </label>
|
|
<select name="libraries" size="1" id="libraries">
|
|
[% FOREACH library IN libraries %]
|
|
<option value="[% library.branchcode | html %]"> [% library.branchname | html %] </option>
|
|
[% END %]
|
|
</select>
|
|
<span class="required"> Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="categorycode_entry" class="required"> Patron category</label>
|
|
<select id="categorycode_entry" name="categorycode_entry">
|
|
[% FOREACH category IN categories %]
|
|
<option value = "[% category.categorycode | html %]">[% category.description | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
<span class="required">Required</span><br><br>
|
|
<b>Note:</b> If you installed sample patron categories please select the "Staff" option in the patron categories dropdown box.
|
|
</li>
|
|
</ol>
|
|
|
|
<h3>Administrator account permissions</h3>
|
|
<ol>
|
|
<li>
|
|
<input type="hidden" name="newflags" value="1" />
|
|
<input type="hidden" class="flag parent" id="flag-0" name="flag" value="superlibrarian" />
|
|
<code> superlibrarian</code>
|
|
</li>
|
|
</ol>
|
|
|
|
<h3>Administrator login</h3>
|
|
<ol>
|
|
<li>
|
|
<label for="userid" class="required">Username: </label>
|
|
<input type="text" name="userid" id ="userid" size="20" value="[% userid | html %]" class="required" required="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="password" class="required">Password: </label>
|
|
<input type="password" name="password" id="password" size="20" value="[% member.password | html %]" class="required" required="required">
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="password2" class="required">Confirm password: </label>
|
|
<input type="password" id="password2" name="password2" size="20" value="" class="required" required="required">
|
|
<span class="required">Required</span>
|
|
</li>
|
|
</ol>
|
|
<p>
|
|
To create another patron, go to:
|
|
<span class="breadcrumbs">Patrons › New patron</span>
|
|
</p>
|
|
<p>
|
|
To edit patron permissions, go to:
|
|
<span class="breadcrumbs">More › Set permissions</span>
|
|
</p>
|
|
</fieldset>
|
|
|
|
<input type="submit" class="btn btn-primary" value="Submit" />
|
|
</form>
|
|
</div> <!-- / #onboarding-step3 -->
|
|
</div> <!-- / .row -->
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|
|
[% PROCESS 'password_check.inc' %]
|
|
[% PROCESS 'add_password_check' new_password => 'password' %]
|