dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
51 lines
3 KiB
Text
51 lines
3 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Web installer › Create a new item type </title>
|
|
[% INCLUDE 'installer-doc-head-close.inc' %]
|
|
[% INCLUDE 'validator-strings.inc' %]
|
|
[% INCLUDE 'installer-strings.inc' %]
|
|
<script type="text/javascript" src="[% interface | html %]/[% theme | html %]/js/onboarding.js"></script>
|
|
</head>
|
|
|
|
<body id="installer" class="installer">
|
|
<div class="container-fluid">
|
|
<div class="row">
|
|
<div id="onboarding-step4" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">
|
|
<h1 id="logo"><a href="#">Koha</a></h1>
|
|
<h2>Web installer › Create a new item type </h2>
|
|
|
|
[% INCLUDE 'onboarding_messages.inc' %]
|
|
|
|
<!--Create a item type screen 1-->
|
|
|
|
<p> Item types are used to group related items. Examples of item types might be books, CDs, or DVDs.</p>
|
|
<p> When adding to your institution's catalog you will create an item of a particular item type.</p>
|
|
<p> Importantl: Item types are what you apply circulation rules to. Circulation rules govern how your institution will lend its items: Checkout length, renewal policy, hold policy, etc. For example a circulation rule applied to the DVD item type may enforce a payment of $1.00 for checking out any DVD.</p>
|
|
|
|
<form id="createitemform" method="post" action="onboarding.pl">
|
|
<fieldset class="rows">
|
|
<input type="hidden" name="step" value="4" />
|
|
<input type="hidden" name="op" value="add_validate_itemtype" />
|
|
<ol>
|
|
<li>
|
|
<label for="itemtype" class="required">Item type code: </label>
|
|
<input type="text" name="itemtype" pattern="[0-9A-Za-z]{1,10}" id="itemtype" size="10" maxlength="10" class="required" required="required" value="[% itemtype.itemtype | html %]" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
|
|
<li>
|
|
<label for="description" class="required">Description: </label>
|
|
<input type="text" name="description" id="description" size="42" value="[% itemtype.description | html %]" class="required" required="required">
|
|
<span class="required">Required</span>
|
|
</li>
|
|
</ol>
|
|
|
|
<p> To create another item type later and for more settings go to:
|
|
<span class="breadcrumbs"> Administration › Item types </span>
|
|
</p>
|
|
<input type="submit" class="btn btn-primary" value="Submit" />
|
|
</fieldset>
|
|
</form>
|
|
</div> <!-- / #onboarding-step4 -->
|
|
</div> <!-- / .row -->
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|