Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Jonathan Druart 8403799c72 Bug 18331: Fix CSV export (once and for all!) 
I am going to try and explain the problem here in order to make it a
have-to-read for next changes.

There are several things to test when and most of the time we break
something when we try to fix something else.

You have to test different CSV export, not only one. There are not all
processed the same way. For instance acqui/csv/basket.tt does not
contain any strings to translate and the translate script will copy the
original file as it.
But reports/csv/orders_by_budget.tt will not! Indeed it contains "TOTAL"
which will be translated. The generated tt file for the translated
language will remove all the carriage returns! That's why we cannot rely
on TT for newlines (contrary to bug 16914 assumption).

There are two possible methods:
1/ Fix the translate script
=> Hum... nope
2/ Remove all carriage returns and make them explicit by including an
file that only contains 1 carriage return

This second method is implemented in this patch.

How it works: Use the PRE_CHOMP "[%-" and POST_CHOMP "-%]"
(http://www.template-toolkit.org/docs/manual/Config.html#section_PRE_CHOMP_POST_CHOMP)
to remove all the newlines that could be added by TT in the original
(en) files. Then include the new_line.inc to add a new line.
That way original and translated files will behave the same way.
The BLOCK in the csv_headers avoid to have the newlines added, in any
cases. For instance: by default we will have an empty line at the end of
the headers, but the translated headers will not have it.

Test plan:
At least 2 signoffs will be needed, please test carefully!
You will need to generate CSV with at least 2 entries!
Test with the non-translated interface (en) and with the language you
want. To test with a translated language you will *have to*:
- cd misc/translator
- perl translate update LANG
- manually edit the po file, remove the fuzzy tags, correctly translate
the string (do not forget the additional %s in the headers)
- perl translate install LANG
1/ Export basket and basketgroup as CSV
2/ Export late orders as CSV
3/ Export items (from the item search) as CSV
4/ Export the 2 reports "Orders by fund" and "Cash register" as CSV

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-15 12:17:40 -03:00
..
catalogue Bug 16545 - Make edit link a styled button in item search results 2017-07-13 17:49:24 -03:00
csv_headers Bug 18331: Fix CSV export (once and for all!) 2017-08-15 12:17:40 -03:00
virtualshelves/merge
acquisitions-add-to-basket.inc Bug 11665: An ability to place orders directly from hold ratios list 2014-05-04 19:13:39 +00:00
acquisitions-menu.inc Bug 17972 - Reformat acquisitions sidebar menu with acquisitions and administration sections 2017-02-17 12:05:08 +00:00
acquisitions-search.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
acquisitions-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
additem.js.inc Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead 2016-09-13 17:21:05 +00:00
admin-items-search-field-form.inc Bug 17537: Fix valid-templates.t for some include files 2016-11-04 11:03:48 +00:00
admin-menu.inc Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active but not on linked page 2017-01-13 11:35:29 +00:00
adv-search.inc Bug 16549 - Remove the use of "onclick" from header search forms 2016-06-24 13:48:24 +00:00
auth-finder-search.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
authorities-search-results.inc Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files 2017-06-16 17:04:08 -03:00
authorities-search.inc Bug 16549 - Remove the use of "onclick" from header search forms 2016-06-24 13:48:24 +00:00
authorities-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
authorities.inc Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues 2016-02-11 19:39:53 +00:00
authorities_js.inc Bug 12295: fix Javascript error when merging authorities 2014-06-05 12:16:39 -03:00
av-build-dropbox.inc Bug 18682 - Translatability: Get rid of [%% in translation for 2 files av-build-dropbox.inc 2017-06-05 16:35:56 -03:00
biblio-default-view.inc
biblio-view-menu.inc Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
blocked-fines.inc Bug 18762: Remove warnings from xt/author/valid-templates.t 2017-06-14 14:36:28 -03:00
borrower_debarments.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
branch-selector.inc Bug 18693: Translatability: Get rid of exposing a [%% FOREACH loop in translation for branch-selector.inc 2017-06-05 16:47:22 -03:00
browser-strings.inc
budgets-active-currency.inc Bug 15049: (followup) Add warning about "No active currency" 2015-12-30 23:34:34 +00:00
budgets-admin-search.inc Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
budgets-admin-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
calendar.inc Bug 17855: Onboarding tool 2017-04-28 08:36:19 -04:00
cat-menu.inc
cat-search.inc Bug 16903 - Multiple class attributes on catalog search tab 2016-09-02 14:03:42 +00:00
cat-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
cataloging-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
cateditor-ui.inc Bug 18415 - Advanced Editor - Rancor - return focus to editor after successful macro 2017-05-08 09:03:34 -04:00
cateditor-widgets-marc21.inc Bug 11559: (followup) Fix import bugs, display/parsing issues 2015-10-27 12:18:00 -03:00
checkin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
checkouts-table-footer.inc Bug 15975 (QA Followup) Fix colspan for footer 2016-09-25 15:41:36 +00:00
checkouts-table.inc Bug 15498: Let the user choose the CSV profile to export circ history 2017-03-31 11:13:47 +00:00
circ-menu.inc Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files 2017-06-16 17:04:08 -03:00
circ-nav.inc Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
circ-patron-search-results.inc Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches 2016-10-27 13:21:13 +00:00
circ-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
cities-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
columns_settings.inc Bug 15921: Do not include datatables js/css files twice 2016-03-24 15:50:02 +00:00
contracts-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
country-list.inc Bug 14608: Move country list to an include file 2017-03-22 23:51:30 +00:00
currencies-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
datatables.inc Bug 16242 - Move staff client JavaScript out of language directory 2016-04-29 14:32:42 +00:00
date-format.inc Bug 12072: Make datepicker and templates to be aware of dmydot format 2015-11-19 13:15:19 -03:00
doc-head-close-receipt.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
doc-head-close.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
doc-head-open.inc Bug 13948: Prevent explosion when Template::Plugin::Stash not installed 2015-07-28 10:30:21 -03:00
empty_line.inc Bug 18331: Fix CSV export (once and for all!) 2017-08-15 12:17:40 -03:00
facets.inc Bug 17169 - Use CCODE descriptions instead of codes 2017-03-22 19:24:23 +00:00
form-blocks.inc
format_price.inc Bug 16768: (followup) Add Swiss format for datatables (format_price.inc) 2016-06-24 14:00:03 +00:00
greybox.inc Revert "Bug 8992: Use the existing greybox plugin in interface/theme" 2015-04-29 12:07:23 -03:00
guided-reports-view.inc
header.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
help-bottom.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
help-top.inc Bug 16553 - Incorrect path to jQueryUI file in help template 2016-05-23 17:17:16 +00:00
home-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
html_helpers.inc Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
installer-doc-head-close.inc Bug 17942 - Add anti-clickjack code to installer doc head close 2017-05-09 20:54:30 +00:00
installer-strings.inc Bug 17942 - Update style of the web installer with Bootstrap 3 2017-05-09 20:54:30 +00:00
intranet-bottom.inc Bug 13835: Popup with searches: results hidden by language menu in footer 2017-04-28 08:35:30 -04:00
intranetstylesheet.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
js_includes.inc Bug 17870 - Call to include file incorrectly moved into the footer 2017-01-13 11:27:39 +00:00
labels-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
letters-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
member-alt-address-style-de.inc Bug 17559: Fixed HTML element ID of B_streetnumber 2016-11-18 14:16:43 +00:00
member-alt-address-style-fr.inc Bug 18110: Add a field FR to the syspref AddressFormat 2017-04-28 08:50:19 -04:00
member-alt-address-style-us.inc Bug 17559: Fixed HTML element ID of B_streetnumber 2016-11-18 14:16:43 +00:00
member-alt-contact-style-de.inc Bug 15373: Changing Zip to ZIP on OPAC and Intranet 2015-12-30 16:30:35 +00:00
member-alt-contact-style-fr.inc Bug 18110: Add a field FR to the syspref AddressFormat 2017-04-28 08:50:19 -04:00
member-alt-contact-style-us.inc Bug 15373: Changing Zip to ZIP on OPAC and Intranet 2015-12-30 16:30:35 +00:00
member-display-address-style-de.inc Bug 15542: Change for the German style address format 2016-01-23 19:15:08 +00:00
member-display-address-style-fr.inc Bug 18110: Folllowup to fix alternative address and add missing class 2017-04-28 08:50:19 -04:00
member-display-address-style-us.inc Bug 16779: Move road type after address in US style address formatting (main address) 2016-07-08 13:09:55 +00:00
member-display-alt-address-style-de.inc Bug 10760: Alternate Address: Display street number and street type 2016-07-08 13:45:41 +00:00
member-display-alt-address-style-fr.inc Bug 18110: Folllowup to fix alternative address and add missing class 2017-04-28 08:50:19 -04:00
member-display-alt-address-style-us.inc Bug 10760: (followup) Move street type after address 2016-07-08 13:45:42 +00:00
member-main-address-style-de.inc Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
member-main-address-style-fr.inc Bug 18110: Corrected display address format 2017-04-28 08:50:19 -04:00
member-main-address-style-us.inc Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
members-menu.inc Bug 5670: [QA Followup] Housebound link from patron edit. 2016-10-21 18:18:00 +00:00
members-toolbar.inc Bug 18423 - Add child button not always appearing - problem in template variable 2017-04-21 07:42:57 -04:00
merge-record-strings.inc Bug 8064: Change the way target record is built. 2015-11-09 15:08:57 -03:00
merge-record.inc Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues 2016-02-11 19:39:53 +00:00
messaging-preference-form.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
nl-search-form.tt Bug 11401: Add support for Norwegian national library card 2014-11-14 09:42:23 -03:00
noadd-warnings.inc Bug 17082: Translatability: Fix sentence splitting in member.tt 2016-08-10 13:49:48 +00:00
onboarding_messages.inc Bug 17942 - Update style of the web installer with Bootstrap 3 2017-05-09 20:54:30 +00:00
page-numbers.inc Bug 18005: Re-styled pagination on search results with Bootstrap 2017-02-07 17:48:10 +00:00
patron-article-requests.inc Bug 14610 - Follow-up 2016-10-26 12:15:23 +00:00
patron-search-box.inc Bug 17418 - Move staff client home page JavaScript to the footer 2016-12-16 11:53:39 +00:00
patron-search.inc Bug 18551: followup - hide advanced filters in header, move hidding to css file 2017-05-19 10:49:53 -04:00
patron-title.inc Bug 17365: Fix XSS in moremember.pl and memberentry.pl 2016-10-11 16:19:56 +00:00
patron-toolbar.inc Bug 18832: Missing space between icon and label in button 'Patron lists' 2017-07-17 13:13:54 -03:00
patroncards-errors.inc Bug 17181: Check for duplicate image names when uploading image to patron card creator 2017-01-13 12:28:07 +00:00
patroncards-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
patrons-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
permissions.inc Bug 12461 - Add patron clubs feature 2017-04-28 08:37:44 -04:00
popup-bottom.inc
prefs-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
prefs-menu.inc Bug 11559: Rancor: advanced cataloging interface 2015-10-27 12:17:39 -03:00
printers-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
quotes-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
quotes-upload-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
reports-menu.inc Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) 2016-10-28 11:50:24 +00:00
reports-toolbar.inc Bug 18283: 'sql' should be 'SQL' 2017-03-31 14:07:53 +00:00
resort_form.inc
rotating-collections-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
search_indexes.inc Bug 18839: Suggestion.pl spelling mistake 2017-07-13 16:42:04 -03:00
select2.inc Bug 13501: Highlight select2 control if field is required and value is missing 2016-09-02 16:25:04 +00:00
serials-menu.inc Bug 10855: Search subscriptions by additional fields 2015-10-02 15:10:30 -03:00
serials-search.inc Bug 17025: Fix XSS in serials-search.pl 2016-08-10 13:17:19 +00:00
serials-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
slip-print.inc Bug 17014 - Remove more event attributes from patron templates 2017-03-31 14:33:51 +00:00
strings.inc Bug 18839: Suggestion.pl spelling mistake 2017-07-13 16:42:04 -03:00
subscriptions-search.inc Bug 17537: Fix valid-templates.t for some include files 2016-11-04 11:03:48 +00:00
subtypes_unimarc.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
suggestions-add-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
timepicker.inc Bug 11618: ensure jQuery timepicker is picked up by the i18n toolchain 2014-02-18 21:19:16 +00:00
tools-item-action.inc Bug 7131: teach MARC import how to overlay items 2013-10-30 04:31:07 +00:00
tools-menu.inc Bug 12461 - Add patron clubs feature 2017-04-28 08:37:44 -04:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
wysiwyg-systempreferences.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
z3950-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
z3950_search.inc Bug 16812: Revise JS script for z3950_search.tts and remove onclick events 2016-07-15 15:24:57 +00:00