dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
61 lines
3.1 KiB
Text
61 lines
3.1 KiB
Text
[% USE Koha %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Discharge</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% BLOCK cssinclude %][% END %]
|
|
</head>
|
|
<body id="opac-discharge" class="scrollto">
|
|
[% INCLUDE 'masthead.inc' %]
|
|
|
|
<div class="main">
|
|
<ul class="breadcrumb">
|
|
<li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li>
|
|
<li><a href="#">Discharge</a></li>
|
|
</ul>
|
|
|
|
<div class="container-fluid">
|
|
<div class="row-fluid">
|
|
<div class="span2">
|
|
<div id="navigation">
|
|
[% INCLUDE 'navigation.inc' IsPatronPage=1 %]
|
|
</div>
|
|
</div>
|
|
<div class="span10">
|
|
<div id="discharge" class="maincontainer">
|
|
<h1>Discharge</h1>
|
|
[% FOR message IN messages %]
|
|
<div class="dialog [% message.type | html %]">
|
|
[% IF message.code == "unable_to_generate_pdf" %]
|
|
An error occurs when generating the pdf file.
|
|
Please contact the staff to resolve this problem.
|
|
[% END %]
|
|
</div>
|
|
[% END %]
|
|
|
|
[% IF success %]
|
|
<p>Your discharge request has been sent. Your discharge will be available on this page within a few days.</p>
|
|
[% ELSIF available %]
|
|
<a href="/cgi-bin/koha/opac-discharge.pl?op=get">Get your discharge</a></li>
|
|
[% ELSIF pending %]
|
|
<p>Your discharge will be available on this page within a few days.</p>
|
|
[% ELSIF has_issues %]
|
|
<p>You cannot be discharged, you have checked out items. Please return items before asking for a discharge.</p>
|
|
[% ELSIF not messages %]
|
|
<h2>What is a discharge?</h2>
|
|
<p>This document certifies that you have returned all borrowed items. It is sometimes asked during a file transfer from a school to another. The discharge is sent by us to your school. You will also find it available on your reader account.</p>
|
|
<p><strong>Warning</strong>: This request is only valid if you are in good standing with the library. Once the application is made, you can not borrow library materials.</p>
|
|
[% IF has_checkouts %]
|
|
<div class="dialog alert">You cannot be discharged, you have checked out items. Please return items before asking for a discharge.</div>
|
|
[% ELSE %]
|
|
<a href="/cgi-bin/koha/opac-discharge.pl?op=request">Ask for a discharge</a>
|
|
[% END %]
|
|
|
|
[% END %]
|
|
</div> <!-- / #discharge -->
|
|
</div> <!-- / .span10 -->
|
|
</div> <!-- / .row-fluid -->
|
|
</div> <!-- / .container-fluid -->
|
|
</div> <!-- / .main -->
|
|
|
|
[% INCLUDE 'opac-bottom.inc' %]
|
|
[% BLOCK jsinclude %][% END %]
|