Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart 86395f2282 Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 
The subroutines in C4::Reviews are only doing CRUD operations.
This patch set moves them to 2 new Koha::Review[s] classes.

Test plan for the whole patch set:
0/ Set the reviewson syspref
1/ At the OPAC, create a couple of reviews for a record
Try and create a review without html tags different that br b i em big
small strong: You should get a warning.
2/ Edit a review
3/ On the Staff interface, you should see a "Comments pending approval"
link on the mainpage
4/ Approve 1 review and delete the other
5/ At the OPAC you should only see 1 review (the approved one) in the
"Comments" tab
6/ Modify the review
7/ The review should appear again in the "comments awaiting moderation"
tab.
Note that even the comment has not been changed, it will have to be
reapproved (FIXME later). This behavior already existed prior to this
patch.

Tested all patches together (with database updated)
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-09 10:29:31 +00:00
..
Acquisition Bug 15531: (followup) Use a quantity of 1, not null, for standing orders 2016-04-29 13:07:18 +00:00
api/v1 Bug 14868: Display required permissions in permission error response 2016-09-02 12:20:36 +00:00
Auth
Biblio
Circulation Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
Creators
data
Exporter
Holds Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
Items Bug 16607: Remove CPL/MPL from two unit tests 2016-06-17 14:44:39 +00:00
Koha Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 2016-09-09 10:29:31 +00:00
Labels
LDAP
Letters Bug 16942 [QA Followup] - Add unit test 2016-09-01 17:21:24 +00:00
Members Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
OAI
Patron Bug 16849: Move IsDebarred to Koha::Patron->is_debarred 2016-07-15 18:08:14 +00:00
Record
Reports
Reserves Bug 14695 [QA Followup] - Unit Tests 2016-09-03 00:21:23 +00:00
Search
selenium Bug 13691: Add changes for 3.22 2016-07-08 20:36:57 +00:00
Serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-07-15 14:07:40 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Template/Plugin Bug 15758: Koha::Libraries - Do not select an option if selected is defined 2016-09-08 14:36:05 +00:00
Utils Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
www Bug 10171: (QA followup) Make search tests use the right form 2016-05-04 14:14:50 +00:00
XSLT_Handler
00-strict.t
Accounts.t Bug 16607: Remove CPL/MPL from two unit tests 2016-06-17 14:44:39 +00:00
Acquisition.t Bug 16934: Add test for ModOrder 2016-07-22 17:13:17 +00:00
AdditionalField.t
Amazon.t
AudioAlerts.t
Auth.t Bug 16853: Move changepassword to Koha::Patron->update_password 2016-07-15 18:09:17 +00:00
Auth_with_cas.t
Auth_with_ldap.t Bug 14144: Clean ups and refactors 2016-04-29 12:40:16 +00:00
AuthorisedValues.t
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t
Biblio.t Bug 16431: Use Koha::Cache to cache marc subfield structure 2016-07-08 12:44:58 +00:00
Bookseller.t
Breeding.t
Budgets.t Bug 15009 [QA Followup] - Update number of tests run 2016-04-29 13:01:07 +00:00
Charset.t
check_sysprefs.t
Circulation.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
ColumnsSettings.t
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-07-15 15:02:13 +00:00
Contract.t
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t Bug 17124: Fix tests in DecreaseLoanHighHolds.t 2016-08-18 15:57:03 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 14642: (QA followup) Add tests for Koha::Hold->delete 2016-08-17 18:43:13 +00:00
Holds.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
HoldsQueue.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
Holidays.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
ILSDI_Services.t Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t 2016-05-04 13:47:58 +00:00
ImportBatch.t Bug 9259: Use is instead of is_deeply 2016-07-08 13:43:53 +00:00
Installer.t
Items.t Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences 2016-09-08 10:24:46 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz
Koha.t
Koha_Authority.t
Koha_borrower_modifications.t Bug 16960: Update 1 missing occurrence of GetModifications 2016-08-22 11:46:05 +00:00
Koha_Database.t
Koha_ElasticSearch.t
Koha_ElasticSearch_Indexer.t Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing 2016-05-06 03:47:05 +00:00
Koha_Misc_Files.t
Koha_SearchEngine_Elasticsearch_Search.t Bug 16453: Make Elasticsearch tests be skipped if configuration entry missing 2016-05-06 03:47:05 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 16805: Tweak new test message to say getalert 2016-07-08 14:45:04 +00:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t
Members.t Bug 16819: Unit tests for C4::Members::DelMember 2016-07-08 14:49:09 +00:00
MungeMarcPrice.t
NewsChannels.t Bug 15758: Koha::Libraries - Remove GetBranchName 2016-09-08 14:36:01 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t
Patron.t Bug 14577 [QA Followup] 2016-04-29 11:54:23 +00:00
PatronLists.t Bug 16452: Remove the warnings raised by PatronLists.t 2016-05-05 20:44:47 +00:00
Patrons.t Bug 10459: Add tests for borrowers.updated_on 2016-06-10 17:10:23 +00:00
Plugins.t Bug 16502: Replace a few other ok-calls by is-calls 2016-06-17 14:32:40 +00:00
QueryParser.t
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Reports.t
Reserves.t Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
Review.t
rollingloans.t
RotatingCollections.t
Search.t Bug 17201: (bug 16431 follow-up2) Remove occurrence of marcfromkohafield 2016-09-02 14:00:11 +00:00
Serials.t Bug 12178: Fix tests not to depend on dateformat syspref 2016-07-15 14:07:41 +00:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t Bug 16751: What is sitemaper? 2016-06-24 13:19:06 +00:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' 2016-05-05 20:46:01 +00:00
sysprefs.t
Tags.t
Templates.t
TestBuilder.t Bug 16890: Make TestBuilder generate date for date columns (and not datetime) 2016-07-15 14:59:46 +00:00
Upload.t Bug 16501: Remove some unneeded warns in Upload.t 2016-05-16 17:46:25 +00:00
UsageStats.t Bug 14048: (QA followup) Update syspref name for HEA 2016-07-07 10:37:01 -06:00
Virtualshelves.t
XISBN.t
XSLT_Handler.t
zebra_config.pl