Martin Renvoize
87c3911bb8
This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
73 lines
1.9 KiB
Perl
Executable file
73 lines
1.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
#
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::RotatingCollections;
|
|
|
|
use CGI qw ( -utf8 );
|
|
|
|
my $query = CGI->new;
|
|
|
|
my $colId = $query->param('colId');
|
|
my $toBranch = $query->param('toBranch');
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "rotating_collections/transferCollection.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
flagsrequired => { tools => 'rotating_collections' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
## Transfer collection
|
|
my ( $success, $messages );
|
|
if ($toBranch) {
|
|
( $success, $messages) =
|
|
TransferCollection( $colId, $toBranch );
|
|
|
|
if ($success) {
|
|
$template->param(
|
|
transferSuccess => 1,
|
|
messages => $messages
|
|
);
|
|
}
|
|
else {
|
|
$template->param(
|
|
transferFailure => 1,
|
|
messages => $messages
|
|
);
|
|
}
|
|
}
|
|
|
|
## Get data about collection
|
|
my ( $colTitle, $colDesc, $colBranchcode );
|
|
( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection($colId);
|
|
$template->param(
|
|
colId => $colId,
|
|
colTitle => $colTitle,
|
|
colDesc => $colDesc,
|
|
colBranchcode => $colBranchcode,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|