Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Indranil Das Gupta 8895caa339 Bug 14206: Adds delete function for non email templates 
C4::Letters::getletter() is called in tools/letter.pl by the function
delete_confirm() to display the selected notice for deletion. Due to
current implementation of getletter(), a notice that does not use
the 'email' template (but uses any/all of the other templates - sms,
print or phone) can't be deleted from the staff client.

This patch adds deletion capability for notices that do not use email
template, but uses any/all of the other templates i.e. sms, print or
phone. This also adds 2 tests to t/db_dependent/Letters.t for testing
both conditions - a) when message_transport_type is specified b) when
it is not.

Test plan
=========

1/ Go to Tools -> Notices & Slips. Add a new notice only for print,
   leave 'Library' and 'Koha module' options as default selections.
   Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name
   respectively, and 'Test' and 'Test Message' for subject and body.
   Leave the Email, Phone and SMS tabs blank. Save the notice.
2/ On the notices listing page the new notice will be listed. Try to
   delete it. It will load the 'Delete notice' dialog form, but the
   table will not show any data under <th>s - 'Library', 'Module',
   'Code' or 'Name'.
3/ Click the "Yes, delete" button. The page will be submitted and the
   Notices listing reloaded. The print-only KOHA_14206 notice should
   continue to exist. This is *wrong*.
4/ Apply this patch
5/ Reload the listings page and click on the 'Delete' link for Notice
   KOHA_14206. This time, it should show the data under 'Module',
   'Code' or 'Name' at least.
6/ Click on 'Yes, delete'. The page should submit and the listing page
   reload. This time KOHA_14206 will be gone.
7/ Run prove -v t/db_dependent/Letters.t
   All tests should PASS without any error.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-06-11 10:14:22 -03:00
..
Acquisition Bug 13967: (QA followup) Make DBIx control transactions on tests 2015-06-04 15:12:45 -03:00
Circulation Bug 11201: Add a in-house use list pages 2015-03-31 11:30:55 -03:00
Creators Bug 14059: Deleting 'issues' table before processing the tests 2015-05-22 17:02:22 -03:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
Holds Bug 11126: (RM followup) remove diags from tests 2014-11-04 18:59:42 -03:00
Items Bug 14057: Inventory is painfully slow 2015-05-06 10:40:23 -03:00
Koha Bug 14057: Inventory is painfully slow 2015-05-06 10:40:23 -03:00
Labels Bug 14204: (QA followup) remove unneeded messages 2015-05-15 15:34:22 -03:00
LDAP
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 12847: Items issued today is considered as overdue 2015-04-20 09:57:25 -03:00
OAI Bug 13940 : (QA followup) Add test for ModOAISet 2015-04-09 11:56:53 -03:00
Record Bug 12404: Allow equal sign '=' in the TT directive 2015-04-27 10:43:23 -03:00
Reports Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Search Bug 11430: (QA followup) we test for warnings, always 2015-03-11 15:14:24 -03:00
Serials Bug 12671: Guess next serial date when there are several issues per unit. Added support for real month and year lenghts. 2015-05-05 15:22:10 -03:00
Template/Plugin Bug 7380: Add tests for TT plugins 2015-05-19 10:10:31 -03:00
Utils Bug 13419: (follow-up) fix call to set_userenv 2015-04-22 14:59:10 -03:00
www Bug 13579: Prefer like instead of ok to match a regex 2015-01-14 12:24:29 -03:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) 2014-04-29 19:34:23 +00:00
Accounts.t Bug 13942 : Testing the 'recordpayment' function in C4::Accounts 2015-04-13 11:53:45 -03:00
Acquisition.t Bug 13967: (QA followup) Make DBIx control transactions on tests 2015-06-04 15:12:45 -03:00
Amazon.t
Auth.t Bug 5010: Fix OPACBaseURL to include protocol 2015-06-04 10:00:04 -03:00
Auth_with_cas.t Bug 5010: Fix OPACBaseURL to include protocol 2015-06-04 10:00:04 -03:00
Auth_with_ldap.t Bug 12831: (RM followup) regression test 2014-11-27 14:45:11 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 13606: Add tests and fix existing ones 2015-04-23 13:18:49 -03:00
Barcodes.t Bug 13673: (QA followup) Add license 2015-05-15 16:00:28 -03:00
Biblio.t Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN 2014-09-01 10:42:08 -03:00
Bookseller.t Bug 14334: t/db_dependent/Bookseller.t AutoCommit fix 2015-06-07 18:51:21 -03:00
Borrower.t Bug 13019: (follow-up) Remove smartmatch operator 2015-02-12 15:21:03 -03:00
Borrower_Debarments.t Bug 12416: add new tests of DelUniqueDebarment 2014-06-22 19:59:04 -03:00
Borrower_Discharge.t Bug 14325: Test calls C4::Context::set_userenv 2015-06-04 09:59:11 -03:00
Borrower_Files.t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-11 16:16:11 -03:00
Borrowers.t Bug 13967: Add a couple of tests for SysPref and Object 2015-06-04 10:39:16 -03:00
Branch.t Bug 9530: Follow-up - Fix t/db_dependent/Branch.t 2014-10-28 09:26:03 -03:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 14334: t/db_dependent/Budgets.t AutoCommit fix 2015-06-07 18:51:22 -03:00
Category.t Bug 12604: refactoring Category.t with TestBuilder 2015-04-20 10:12:08 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
check_sysprefs.t
Circulation.t Bug 13919: Make the tests pass fixing the number of tests 2015-04-28 15:11:34 -03:00
Circulation_Branch.t Bug 10683: (follow-up) improvements to the unit tests 2013-10-09 03:51:55 +00:00
Circulation_issue.t Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t 2015-04-13 15:15:31 -03:00
Circulation_Issuingrule.t Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Circulation_issuingrules.t Bug 11934: (follow-up) tidy up whitespace 2014-03-13 15:18:49 +00:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_transfers.t Bug 12122: TransferSlip should accept both itemnumber and barcode 2015-03-05 11:47:12 +01:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
ColumnsSettings.t Bug 10212: Columns configuration for tables - Unit tests 2014-08-26 09:28:18 -03:00
Context.t Bug 14342: Unit tests in t/db_dependent/Context.t failing due to Bug 13967 2015-06-07 18:38:45 -03:00
Contract.t Bug 12487: SQLHelper replacement - C4::Contract 2014-07-30 10:44:11 -03:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
default_search_class.pl Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
External_BakerTaylor.t
FrameworkPlugin.t Bug 10480: New module and unit test for framework plugins 2015-04-16 14:48:35 -03:00
Heading_MARC21.t
Holds.t Bug 13687: Move hold policy check into CanItemBeReserved 2015-05-19 12:05:50 -03:00
HoldsQueue.t Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
Holidays.t Bug 13451: Holidays.t assumes default data 2014-12-17 19:24:50 -03:00
ILSDI_Services.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
ImportBatch.t Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio 2015-04-16 13:40:59 -03:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 13713: Follow-up removing biblioitem routines 2015-03-19 14:06:01 -03:00
Items_DelItem.t Bug 12583: (followup) rename new test file 2014-07-26 10:17:09 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 13453: Koha.t daily quote tests assume sample data 2014-12-28 19:52:51 -03:00
Koha_Authority.t Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Koha_borrower_modifications.t Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t Bug 3050: QA follow-up 2014-05-25 21:15:03 +00:00
Koha_template_plugin_Branches.t Bug 10900 - Follow up, since more has been added to master 2015-02-09 17:00:15 -03:00
Koha_template_plugin_KohaDates.t Bug 12669: Centralize the timezone handle into Koha::DateUtils 2015-02-20 10:20:30 -03:00
Languages.t Bug 14030 - Added tests for duplicates. 2015-04-24 09:55:54 -03:00
Letters.t Bug 14206: Adds delete function for non email templates 2015-06-11 10:14:22 -03:00
Linker_FirstMatch.t
Log.t Bug 13889: Add unit tests 2015-05-04 11:11:32 -03:00
MarcModificationTemplates.t Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Members.t Bug 12633: Remove SQLHelper in C4::Members 2015-05-15 15:38:05 -03:00
Members_Attributes.t Bug 12427: Allow execution of UTs on a DB with issues 2014-06-24 09:43:04 -03:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
MungeMarcPrice.t Bug 9593: (follow-up) don't make currency.isocode required 2014-05-04 22:21:17 +00:00
NewsChannels.t Bug 7567: (follow-up) make tests of get_opac_new more readable 2014-04-07 18:14:20 +00:00
Overdues.t Bug 9180: All branches should be returned if a default rule exists 2014-08-19 09:29:51 -03:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Plugins.t Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
QueryParser.t Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
Ratings.t Bug 13998: (RM followup) tests expect data on the database 2015-04-21 13:53:40 -03:00
Record.t Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Reports.t
Reports_Guided.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
ReportsGuided.t Bug 13141: (QA Followup) Update number of unit tests 2014-10-31 13:15:06 -03:00
Reserves.t Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Review.t Bug 13969: (QA followup) Delete issues before borrowers 2015-05-14 11:11:46 -03:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
RotatingCollections.t Bug 8836: (RM followup) unit tests should use the new API 2014-11-07 11:09:14 -03:00
Search.t Bug 13088: (RM followup) add missing pref mock 2014-10-28 12:07:46 -03:00
Search_SearchHistory.t Bug 10807: (follow-up) remove comment about routine that is no longer present 2014-05-05 02:58:29 +00:00
Serials.t Bug 13423: Fix number of tests in Serials.t 2015-05-14 11:48:17 -03:00
Serials_2.t Bug 5342: Serial claiming improvements: add a counter 2014-10-28 10:07:37 -03:00
Service.t
ShelfBrowser.t Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 13007: Special case budgetid == '' 2015-02-09 15:49:57 -03:00
sysprefs.t Bug 13967: Add a couple of tests for SysPref and Object 2015-06-04 10:39:16 -03:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 14195: (followup) increment number of tests 2015-05-20 11:05:27 -03:00
UploadedFile.t
VirtualShelves.t Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate 2014-04-20 22:52:21 +00:00
VirtualShelves_Page.t
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2014-08-20 12:29:27 -03:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
zebra_config.pl Bug 12651: DOM indexing is the default 2014-10-27 12:35:44 -03:00