Jonathan Druart
51aa6db46c
The GetMemberAccountRecords may be a perf killer, it retrieves all the account lines of a patron and then the related item and biblio information. Most of the time we only want to know how much the patron owns to the library (sum of amountoutstanding). We already have this information in Koha::Patron->account->balance. This patch replaces the occurrences of this subroutine by fetching only the information we need, either the balance, the detail, or both. It removes the formatting done in the module, to use the TT plugin 'Price' instead. There is a very weird and error-prone behavior/feature in GetMemberAccountBalance (FIXME): as the accountlines.accounttype is a varchar(5), the value of the authorised value used for the ManInvInNoissuesCharge pref (category MANUAL_INV) is truncated to the 5 first characters. That could lead to unexpected behaviors. On the way, this patchset also replace the GetMemberAccountBalance subroutine, which returns the balance, the non issues charges and the other charges. We only need to have the balance and the non issues charges to calcul the third one. Test plan: Add several fees for a patron and play with HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge. The information (biblio and item info, as well as the account line) must be correctly displayed on the different screens: 'Fines' module, fine slips, circulation module Note that this patchset could introduce regression on price formatting, but will be easy to fix using the TT plugin. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
90 lines
3 KiB
Perl
Executable file
90 lines
3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright Katipo Communications 2002
|
|
# Copyright Biblibre 2007,2010
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Members;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use Koha::Account::Lines;
|
|
use Koha::Patrons;
|
|
use Koha::Plugins;
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-account.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 0,
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
my $category = $patron->category;
|
|
my $borrower= $patron->unblessed;
|
|
$borrower->{description} = $category->description;
|
|
$borrower->{category_type} = $category->category_type;
|
|
$template->param( BORROWER_INFO => $borrower );
|
|
|
|
my $total = $patron->account->balance;
|
|
my $accts = Koha::Account::Lines->search(
|
|
{ borrowernumber => $patron->borrowernumber },
|
|
{ order_by => { -desc => 'accountlines_id' } }
|
|
);
|
|
|
|
my @accountlines;
|
|
while ( my $line = $accts->next ) {
|
|
my $accountline = $line->unblessed;
|
|
$accountline->{'amount'} = sprintf( "%.2f", $accountline->{'amount'} || '0.00');
|
|
if ( $accountline->{'amount'} >= 0 ) {
|
|
$accountline->{'amountcredit'} = 1;
|
|
}
|
|
$accountline->{'amountoutstanding'} =
|
|
sprintf( "%.2f", $accountline->{'amountoutstanding'} || '0.00' );
|
|
if ( $accountline->{'amountoutstanding'} >= 0 ) {
|
|
$accountline->{'amountoutstandingcredit'} = 1;
|
|
}
|
|
push @accountlines, $accountline;
|
|
}
|
|
|
|
$template->param(
|
|
ACCOUNT_LINES => \@accountlines,
|
|
total => sprintf( "%.2f", $total ), # FIXME Use TT plugin Price
|
|
accountview => 1,
|
|
message => scalar $query->param('message') || q{},
|
|
message_value => scalar $query->param('message_value') || q{},
|
|
payment => scalar $query->param('payment') || q{},
|
|
payment_error => scalar $query->param('payment-error') || q{},
|
|
);
|
|
|
|
my $plugins_enabled = C4::Context->preference('UseKohaPlugins') && C4::Context->config("enable_plugins");
|
|
if ( $plugins_enabled ) {
|
|
my @plugins = Koha::Plugins->new()->GetPlugins({
|
|
method => 'opac_online_payment',
|
|
});
|
|
# Only pass in plugins where opac online payment is enabled
|
|
@plugins = grep { $_->opac_online_payment } @plugins;
|
|
$template->param( plugins => \@plugins );
|
|
}
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
|