Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 88f65287ef
Bug 37740: Fix saved SQL reports tab switching
The tabs on the saved SQL report page are not really full tabs, they're
just styled that way. There is only one tab "panel," and clicking each
tab triggers a DataTable filter so that the tab only shows the relevant
data.

The problem with this setup is that when Bootstrap tries to "switch"
tabs, it wants to hide the initial tab and then show the new one. There
is no "new" one here.

The attached patch solves this problem by adding a CSS rule to
guided_reports_start.tt with higher specificity than our global CSS
making the relevant tab pane visible at all times.

To test, apply the patch and go to Reports -> Use saved.

- If necessary, create multiple SQL reports and assign them to different
  report groups (Accounts, Acquisitions, Catalog, etc.).
- Test that tab switching works:
  - The tab should be style as "active" after you click it.
  - The table of reports should be filtered to include only reports in
    the relevant report group.

Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-08-30 12:45:45 +02:00
acqui Bug 35044: (QA follow-up): DRY code before set_additional_fields 2024-08-23 18:21:26 +02:00
admin Bug 37574: Add visual indicator that bookings are expired 2024-08-26 17:39:52 +02:00
api Bug 37513: Allow embedding usage_count in record sources 2024-08-27 12:14:25 +02:00
authorities Bug 37235: Fix export of single authority record 2024-07-08 17:49:19 +02:00
basket
bin
bookings
C4 Bug 34088: Short circuit database upgrade check 2024-08-29 18:16:19 +02:00
catalogue Bug 14322: (follow-up) Perl tidy 2024-08-26 17:39:50 +02:00
cataloguing Bug 37429: Set default value for global variables 2024-08-16 17:33:45 +02:00
circ Bug 37210: Properly escape SQL query parameters by using bind values 2024-08-01 17:26:46 +02:00
clubs
course_reserves Bug 28762: Use Koha::Course in course-details controller 2024-07-23 16:04:05 +01:00
debian Bug 37087: Add TCP keepalive support to SIP server 2024-08-20 15:32:47 +02:00
docs
erm
errors Bug 37741: Do not send cookie back from error pages 2024-08-30 12:45:45 +02:00
etc Bug 37087: Add TCP keepalive support to SIP server 2024-08-20 15:32:47 +02:00
ill Bug 24471: Rename handle_commit_maybe method 2024-08-23 19:13:48 +02:00
installer Bug 34088: Short circuit database upgrade check 2024-08-29 18:16:19 +02:00
Koha Bug 36919: Remove a warning from Koha/Object.t 2024-08-29 18:16:22 +02:00
koha-tmpl Bug 37740: Fix saved SQL reports tab switching 2024-08-30 12:45:45 +02:00
labels
lib
members Bug 35044: (QA follow-up): DRY code before set_additional_fields 2024-08-23 18:21:26 +02:00
misc Bug 37682: Lazy-load modules for setters in koha-preferences tool 2024-08-27 12:14:23 +02:00
offline_circ
opac Bug 37741: Do not send cookie back from error pages 2024-08-30 12:45:45 +02:00
patron_lists
patroncards Bug 37614: Printing patron cards from patron lists should be a GET 2024-08-16 17:33:45 +02:00
plugins
pos
preservation
recalls
reports Bug 37595: Double HTML escaped ampersand in pagination bar 2024-08-16 17:33:52 +02:00
reserve
reviews Bug 2486: Show user comments in staff interface 2024-08-26 17:39:42 +02:00
rotating_collections
serials Bug 35044: (QA follow-up): Allow for '0' in serials batch edit 2024-08-23 18:21:27 +02:00
services
skel
suggestion Bug 37337: Pass the save $op when biblio_exists 2024-07-18 17:53:12 +02:00
svc Bug 35931: More preselected items in the renew column on patron checkouts 2024-08-23 19:13:49 +02:00
t Bug 36919: Remove yet another warning from Koha/Object.t 2024-08-29 18:16:23 +02:00
tags
tools Bug 36915: Send email notification when a booking is cancelled 2024-08-27 12:14:17 +02:00
virtualshelves Bug 37285: (QA follow-up) Perl Tidy 2024-07-26 13:56:33 +01:00
xt Bug 37309: Adjust test 2024-08-26 17:39:45 +02:00
.editorconfig
.eslintrc.json
.gitignore Bug 35402: Update the OPAC and staff interface to Bootstrap 5 2024-08-23 15:58:41 +02:00
.htaccess
.mailmap
.perlcriticrc
.perltidyrc
.prettierrc.js
.proverc.dist
.stylelintrc.json
about.pl Bug 37509: Check Elasticsearch info for both 'about' and 'sysinfo' tabs 2024-08-21 19:13:55 +02:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 35755: Update cpanfile for Business::ISBN 3.009 2024-08-19 16:07:17 +02:00
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 35402: (follow-up) Use ~ to resolve to nearest node_modules when building css 2024-08-26 17:39:54 +02:00
help.pl
INSTALL
Koha.pm Bug 20411: DBRev 24.06.00.026 2024-08-26 17:39:47 +02:00
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json Bug 35402: (follow-up) Remove bootstrap version 4 and revert import paths to 'bootstrap' 2024-08-26 17:39:56 +02:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock Bug 35402: (follow-up) Remove bootstrap version 4 and revert import paths to 'bootstrap' 2024-08-26 17:39:56 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo