Koha/acqui
Nick Clemens 726ad7404c
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on vendor
On bug 14860 an 'else' was removed, assuming the price fields were set before discount,
this was incorrect. This patch renames the variable and always set the price, only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-22 16:25:41 -03:00
..
acqui-home.pl Bug 29287: Add child funds to display of parent funds on acqui home 2022-03-01 22:47:46 -10:00
addorder.pl Bug 31840: Consider current cost if modifying order 2022-11-04 20:03:12 -03:00
addorderiso2709.pl Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on vendor 2022-11-22 16:25:41 -03:00
ajax-getauthvaluedropbox.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket.pl Bug 15348: Add estimated delivery date field to individual orders 2022-09-16 10:36:53 -03:00
basketgroup.pl Bug 31257: Add a new English 1 page layout to export basketgroup 2022-10-11 10:44:10 -03:00
basketheader.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
booksellers.pl Bug 31017: Update field name to 'type' 2022-08-19 16:15:15 -03:00
cancelorder.pl Bug 29658: Fix crash on cancelling cancelled order 2022-09-12 16:14:47 -03:00
check_budget_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_uniqueness.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
duplicate_orders.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
edi_ean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edifactmsgs.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 29955: Move populate_order_with_prices to Koha namespace 2022-08-19 15:47:51 -03:00
histsearch.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
invoice-files.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
invoice.pl Bug 25763: Allow updating of order fund from invoice 2022-10-24 15:30:46 -03:00
invoices.pl Bug 31115: Add additional field filtering for invoice search 2022-10-24 14:11:07 -03:00
lateorders-export.pl Bug 15348: trivial code simplification 2022-09-16 10:36:53 -03:00
lateorders.pl Bug 30718: Pass DT to filter_by_lates 2022-08-19 08:26:37 -03:00
moddeliverydate.pl Bug 15348: (follow-up) Fix modal to edit delivery date 2022-09-16 10:36:57 -03:00
modordernotes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
neworderempty.pl Bug 29554: Do not hide display of itemtypes on neworderempty 2022-10-13 11:24:26 -03:00
newordersubscription.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersuggestion.pl Bug 23991: Move SearchSuggestion to Koha::Suggestions 2022-06-27 12:30:28 -03:00
ordered.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
orderreceive.pl Bug 31459: (follow-up) Preserve budget period display 2022-10-24 15:26:24 -03:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 31115: Add support for additional fields for invoices 2022-10-24 14:11:06 -03:00
showorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
spent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
supplier.pl Bug 28082: Add acquisitions toolbar to vendors on vendor search page 2022-05-10 15:17:17 -10:00
transferorder.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
uncertainprice.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
updatesupplier.pl Bug 31017: Update field name to 'type' 2022-08-19 16:15:15 -03:00
z3950_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00