Main Koha release repository https://koha-community.org
Find a file
Kyle M Hall 8b04a3f642 Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used
Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules.

Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value.

Test Plan:
1) Check out Koha 22.05.05
2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan period set to 7, with one of the non-default rules having a Loan period of 14.
3) Delete all but one of the non-default rules with the following query:
   Delete from circulation_rules where rule_name  = 'issuelength' and ( rule_value != 14 and not ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2;
4) Check out 254f721320
5) Run updatedatabase.pl and restart
6) Note the rules were recreated with the value 0
7) Repeat steps 1-4
8) Apply this patch
9) If you're using the same database, set the version to 22.0600023 and restart
10) Run updatedatabase.pl
11) Note the rules were recreated, but the value is the derived value from the all/all/all rule!

Signed-off-by: Kevin Carnes <kevin.carnes@ub.lu.se>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Bug 33847: Rewrite to use SQL

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Squashed, and added reference to new bug too
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit f6f2d1ae41)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2024-01-03 16:07:41 +01:00
acqui Bug 34708: Add ability to modify orderline to increase quantity 2023-11-09 10:15:05 -03:00
admin Bug 35460: Fix add and edit of hold rules in circulation rules table 2023-12-11 21:44:27 -10:00
api Bug 35574: Correct api permission for listing biblio specific bookings 2024-01-03 15:48:28 +01:00
authorities
basket
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2024-01-03 15:48:28 +01:00
C4 Bug 35405: Remove noise from MARC::Record in SearchAuthorities 2024-01-03 15:52:40 +01:00
catalogue Bug 26468: Add damaged as a searchable status in item search 2023-11-08 17:52:46 -03:00
cataloguing Bug 35414: Silence warn related to number_of_copies 2023-12-11 21:37:28 -10:00
circ Bug 35216: Rename error to issuingimpossible 2024-01-03 15:54:32 +01:00
clubs
course_reserves
debian Bug 35174: update control files for koha-l10n dependency package 2023-11-16 11:31:55 +01:00
docs 23.11.00: Update history.txt 2023-11-30 14:58:48 -03:00
erm
errors
etc Bug 34868: (QA follow-up) Fix XML 2023-11-10 10:59:39 -03:00
ill
installer Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used 2024-01-03 16:07:41 +01:00
Koha Bug 30287: (follow-up) Add content wrap matching send time 2024-01-03 16:03:42 +01:00
koha-tmpl Bug 30287: (follow-up) Add content wrap matching send time 2024-01-03 16:03:42 +01:00
labels
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2024-01-03 16:03:42 +01:00
misc Fix release notes for 23.11.01 2024-01-02 11:34:43 +01:00
offline_circ Bug 34529: Offline circulation should be able to accept userid as well as cardnumber 2023-11-06 11:34:44 -03:00
opac Bug 35496: (QA follow-up): tidy up code 2024-01-03 15:10:21 +01:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards
plugins
pos
preservation
recalls
reports Bug 34456: (QA follow-up) perltidy code 2023-11-01 17:23:18 -03:00
reserve Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reviews
rotating_collections
serials Bug 35073: perltidy subscription-batchedit.pl 2023-11-03 12:04:37 -03:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 10:32:38 -03:00
svc Bug 35181: Don't pass undef to header 2023-11-06 08:42:46 -03:00
t Bug 30287: (follow-up) Make unit test more reliable in ktd 2024-01-03 16:03:42 +01:00
tags
tools Bug 35291: (QA follow-up) Tidying script for QA test tools 2023-11-24 16:43:25 -03:00
virtualshelves
xt
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl Bug 35174: Add a warning to the about page 2023-11-16 08:56:36 +01:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile
cypress.config.ts
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2024-01-03 14:16:31 +01:00
help.pl
INSTALL
Koha.pm Bug 35413: DBRev 23.11.01.001 2024-01-03 15:44:41 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 29002: Update Makefile 2023-11-03 12:04:27 -03:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo