Kyle M Hall 9b10f69ee3 Bug 35322: Fix the logic for checking for holds in CanBookBeIssued ... We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. Test Plan: 1) Enable AllowItemsOnHoldCheckoutSCO 2) Place a hold on an item 3) Attempt to check that item out to another patron 4) Note the checkout is blocked 5) Apply this patch 6) Restart all the things! 7) Attempt the checkout again 8) The checkout now succeeds! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>		2024-01-16 12:06:13 +01:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
ClassSplitRoutine
Creators	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
External
Form
Heading	Bug 21828: build $bib_heading_fields only once per invocation	2023-09-22 12:57:46 -03:00
ILSDI	Bug 34950: Add availability statuses for in transit and on hold items.	2024-01-16 12:06:12 +01:00
Installer
Labels	Bug 10762: (QA follow-up) Perltidy	2023-10-25 10:35:31 -03:00
Linker
Members	Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name	2023-10-11 10:31:46 -03:00
OAI
Output
Patroncards	Bug 34532: Silence warns in Patroncard.pm	2023-09-15 11:57:08 -03:00
Reports	Bug 33046: Use process_tt in C4::Reports::Guided::EmailReport	2023-07-18 14:07:41 -03:00
Search
Serials
SIP	Bug 34868: (QA follow-up) Tidy sip_circulation_status	2023-11-10 10:59:39 -03:00
Utils
Accounts.pm
Acquisition.pm	Bug 14092: (QA follow-up) Avoid fiddling with the hash in the template	2023-10-20 16:31:15 -03:00
Auth.pm	Bug 35008: Make ILS-DI not require auth when OpacPublic disabled	2023-11-10 10:59:28 -03:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm
Auth_with_ldap.pm	Bug 34731: Don't call SendQueuedMessages if message_id is bad	2023-09-12 09:44:59 -03:00
Auth_with_shibboleth.pm	Bug 34731: Don't call SendQueuedMessages if message_id is bad	2023-09-12 09:44:59 -03:00
AuthoritiesMarc.pm	Bug 35702: Fetch biblios at once and loop	2024-01-16 12:06:03 +01:00
Barcodes.pm
Biblio.pm	Bug 33749: (QA follow-up) Tidy code for qa script	2023-11-03 12:08:07 -03:00
Breeding.pm	Bug 28166: (QA follow-up) Fix and tidy tests and code	2023-10-23 11:33:50 -03:00
Budgets.pm	Bug 31631: Optionally use tax-exclusive values for calculating fund values	2023-10-18 15:41:35 -03:00
Calendar.pm	Bug 32048: Added clear cache routine to delete_holiday_range_repeatable	2023-09-18 15:31:50 -03:00
Charset.pm
Circulation.pm	Bug 35322: Fix the logic for checking for holds in CanBookBeIssued	2024-01-16 12:06:13 +01:00
ClassSortRoutine.pm
ClassSource.pm
ClassSplitRoutine.pm
Context.pm	Bug 29033: Add C4::Context->multivalue_preference	2023-10-10 10:53:59 -03:00
Contract.pm
CourseReserves.pm
Creators.pm
Heading.pm	Bug 33557: Add LinkerConsiderThesaurus system preference	2023-05-10 15:26:26 -03:00
HoldsQueue.pm	Bug 34678: Allow new entries to overwrite hold_fill_targets	2023-10-27 16:44:24 -03:00
HTML5Media.pm
ImportBatch.pm	Bug 35438: Remove skip_intermediate_commit parameter	2024-01-16 12:06:08 +01:00
ImportExportFramework.pm
InstallAuth.pm
Installer.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-06 12:24:12 -03:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf	2023-09-15 11:57:13 -03:00
Koha.pm	Bug 34828: Fix test	2023-10-10 09:22:37 -03:00
Labels.pm
Languages.pm	Bug 32775: (QA follow-up) Fix tab and indenting issues	2023-05-15 18:23:54 -03:00
Letters.pm	Bug 20755: Add separate email configuration for acquisition and serial emails	2023-11-08 11:41:20 -03:00
Linker.pm
Log.pm	Bug 32057: (QA follow-up) Remove pretty flag	2023-03-14 08:49:34 -03:00
MarcModificationTemplates.pm
Matcher.pm	Bug 26611: Make authority record matching use required match checks	2023-05-24 11:21:31 -03:00
Members.pm	Bug 26170: Add protected status for patrons	2023-11-01 17:23:06 -03:00
Message.pm	Bug 18398: (follow-up) Update POD & Unit tests	2023-03-31 13:13:35 +02:00
Output.pm	Bug 30524: Core CSRF checking code	2023-08-07 20:59:58 -03:00
Overdues.pm	Bug 34279: Don't enforce overduefinescap unless it is greater than 0	2023-07-19 13:00:41 -03:00
Patroncards.pm
Record.pm	Bug 35588: Scope authorised value desc lookup according to field/subfield	2023-12-28 12:16:11 +01:00
Reports.pm
Reserves.pm	Bug 35491: Add logging to RevertWaitingStatus	2023-12-19 13:42:13 +01:00
Ris.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-06 12:24:12 -03:00
RotatingCollections.pm	Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines	2023-05-12 12:40:21 -03:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 33725: (follow-up) Add ccode to grouping logic	2023-06-07 16:42:05 -03:00
Serials.pm	Bug 31846: (QA follow-up) Tidy code to make qa script happy	2023-10-25 10:35:28 -03:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm	Bug 33833: Add two FIXMEs to SocialData::get_report	2023-09-05 14:35:35 -03:00
Stats.pm	Bug 33608: (QA follow-up) Remove ->insert method	2023-10-25 11:07:59 -03:00
Suggestions.pm	Bug 33236: (follow-up) Remove export of NewSuggestion	2023-06-06 10:08:36 -03:00
Tags.pm
Templates.pm	Bug 35070: Tidy	2024-01-04 16:51:45 +01:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm	Bug 26673: Remove #!/usr/bin/env perl from .pm modules too	2020-10-26 00:14:42 +01:00
UsageStats.pm	Bug 33961: Remove built-in offline circ tool	2023-06-12 16:53:25 -03:00
XISBN.pm
XSLT.pm	Bug 33217: Tidy	2023-11-08 17:52:42 -03:00