8b685c1e80
The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaining a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
144 lines
4.3 KiB
Perl
Executable file
144 lines
4.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2008-2009 LibLime
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use strict;
|
|
use warnings;
|
|
use CGI;
|
|
use MARC::Record;
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Members; # to use GetMember
|
|
use C4::Search; # enabled_staff_search_views
|
|
|
|
my $query = new CGI;
|
|
my $dbh = C4::Context->dbh;
|
|
my $biblionumber = $query->param('biblionumber');
|
|
my $frameworkcode = $query->param('frameworkcode');
|
|
$frameworkcode = GetFrameworkCode( $biblionumber ) unless ($frameworkcode);
|
|
my $popup =
|
|
$query->param('popup')
|
|
; # if set to 1, then don't insert links, it's just to show the biblio
|
|
|
|
# open template
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "catalogue/labeledMARCdetail.tmpl",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { catalogue => 1 },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $record = GetMarcBiblio($biblionumber);
|
|
if ( not defined $record ) {
|
|
# biblionumber invalid -> report and exit
|
|
$template->param( unknownbiblionumber => 1,
|
|
biblionumber => $biblionumber
|
|
);
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|
|
exit;
|
|
}
|
|
|
|
my $tagslib = GetMarcStructure(1,$frameworkcode);
|
|
my $biblio = GetBiblioData($biblionumber);
|
|
|
|
if($query->cookie("holdfor")){
|
|
my $holdfor_patron = GetMember('borrowernumber' => $query->cookie("holdfor"));
|
|
$template->param(
|
|
holdfor => $query->cookie("holdfor"),
|
|
holdfor_surname => $holdfor_patron->{'surname'},
|
|
holdfor_firstname => $holdfor_patron->{'firstname'},
|
|
holdfor_cardnumber => $holdfor_patron->{'cardnumber'},
|
|
);
|
|
}
|
|
|
|
#count of item linked
|
|
my $itemcount = GetItemsCount($biblionumber);
|
|
$template->param( count => $itemcount,
|
|
bibliotitle => $biblio->{title}, );
|
|
|
|
#Getting the list of all frameworks
|
|
my $queryfwk =
|
|
$dbh->prepare("select frameworktext, frameworkcode from biblio_framework");
|
|
$queryfwk->execute;
|
|
my %select_fwk;
|
|
my @select_fwk;
|
|
my $curfwk;
|
|
push @select_fwk, "Default";
|
|
$select_fwk{"Default"} = "Default";
|
|
|
|
while ( my ( $description, $fwk ) = $queryfwk->fetchrow ) {
|
|
push @select_fwk, $fwk;
|
|
$select_fwk{$fwk} = $description;
|
|
}
|
|
$curfwk=$frameworkcode;
|
|
my $framework=CGI::scrolling_list( -name => 'Frameworks',
|
|
-id => 'Frameworks',
|
|
-default => $curfwk,
|
|
-OnChange => 'Changefwk(this);',
|
|
-values => \@select_fwk,
|
|
-labels => \%select_fwk,
|
|
-size => 1,
|
|
-multiple => 0 );
|
|
$template->param(framework => $framework);
|
|
|
|
my @marc_data;
|
|
my $prevlabel = '';
|
|
for my $field ($record->fields)
|
|
{
|
|
my $tag = $field->tag;
|
|
next if ! exists $tagslib->{$tag}->{lib};
|
|
my $label = $tagslib->{$tag}->{lib};
|
|
if ($label eq $prevlabel)
|
|
{
|
|
$label = '';
|
|
}
|
|
else
|
|
{
|
|
$prevlabel = $label;
|
|
}
|
|
my $value = $tag < 10
|
|
? $field->data
|
|
: join ' ', map { $_->[1] } $field->subfields;
|
|
push @marc_data, {
|
|
label => $label,
|
|
value => $value,
|
|
};
|
|
}
|
|
|
|
$template->param (
|
|
marc_data => \@marc_data,
|
|
biblionumber => $biblionumber,
|
|
popup => $popup,
|
|
labeledmarcview => 1,
|
|
z3950_search_params => C4::Search::z3950_search_args($biblio),
|
|
C4::Search::enabled_staff_search_views,
|
|
searchid => $query->param('searchid'),
|
|
);
|
|
|
|
my $holds= C4::Reserves::GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
|
|
my $holdcount = scalar( @$holds );
|
|
$template->param( holdcount => $holdcount, holds => $holds );
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|