Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 8bf7c342bf Bug 26395: Move translatable strings out of letter.tt into letter.js
This patch moves strings defined for translation in letter.tt
into letter.js for translation using the new double-underscore
i81n function.

Note, the "MSG_NO_NOTICE_FOUND" usage has been removed because it didn't
work.

To test, apply the patch and go to Tools -> Notices & Slips.

- Use the "Copy" dropdown to copy an existing notice to a specific
  library.
- Save the copied notice.
- Return to the "All libraries" view on the Notices & Slips page.
- Repeat the same process above: Copy the same notice to the same
  library.
- When you click save on the "Add notice" page you should get an error
  message, "A letter with the code 'ACCTDETAILS' already exists for
  <library>"

- From the "All libraries" view on the Notices & Slips page, copy the
  text in the "Code" column of an existing notice.
- Click "New notice" and choose the module of the notice you copied
  from.
- On the "Add notice" page, paste the code into the "Code" field and
  enter a name in the "Name" field.
- Click "Save" without making any other changes. You should get an error
  message, "Please fill at least one template."
- Enter some data into one of the message body fields but not message
  subject, and click "Save" again.
- You should get an error, "Please specify title and content for
  <notice>"
- Enter data in the message subject field and click "Save" again.
- You should get an error, "A default letter with the code <CODE>
  already exists."

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

  > cd misc/translator
  > perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/js/letter.js for translation,
  e.g.:

  msgid "Please fill at least one template."
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

> perl translate install fr-FR

- Switch to your newly translated language in the staff client
  and repeat the test plan above. The translated strings should
  appear.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-29 14:28:18 +02:00
acqui Bug 17458: Remove use of datereceived from order receive page 2020-09-28 16:09:10 +02:00
admin Bug 26490: Fix column configuration for fines trasactions 2020-09-28 15:06:52 +02:00
api Bug 26271: Add null to the list of accepted account_line data types 2020-09-03 14:18:23 +02:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
C4 Bug 26414: Unable to export Withdrawn status using CSV profile 2020-09-28 15:07:39 +02:00
catalogue Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber 2020-09-03 14:18:23 +02:00
cataloguing Bug 15933: Add +x to the script 2020-09-28 11:08:03 +02:00
circ Bug 23485: Show barcode in holds to pull 2020-09-28 16:09:10 +02:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
debian Bug 16357: Only use Log4perl middleware if appenders defined 2020-09-28 16:09:10 +02:00
docs Bug 7143: Update about page for new dev - Alexis Ripetti 2020-09-29 14:28:18 +02:00
errors
etc Bug 16357: Use separate Log4Perl logger for each Plack app 2020-09-28 16:09:10 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26341: Database update for bug 21443 is not idempotent and will destroy settings 2020-09-23 22:08:25 +02:00
Koha Bug 26322: Permissions not checked correctly for plugins 2020-09-29 14:28:18 +02:00
koha-tmpl Bug 26395: Move translatable strings out of letter.tt into letter.js 2020-09-29 14:28:18 +02:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
members Bug 26269: Fix variable name mismatch for cash_register in paycollect 2020-09-18 10:38:04 +02:00
misc Bug 25624: Add --where option to update_patrons_category.pl 2020-09-28 16:09:10 +02:00
offline_circ Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
opac Bug 26464: Code correction in opac-main when news_id passed 2020-09-18 11:49:29 +02:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
plugins Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
pos Bug 26418: Fix translatability of REFUND credit type 2020-09-28 15:07:27 +02:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-03 14:18:23 +02:00
reserve Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
services
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 11176: Add active switch on budgets select in suggestions 2020-09-28 16:09:11 +02:00
svc Bug 26424: Better performance of svc/checkouts 2020-09-28 15:07:00 +02:00
t Bug 26322: Regression tests 2020-09-29 14:28:18 +02:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
tools Bug 24780: Make items.stocknumber show up in batch item modification 2020-09-28 16:09:10 +02:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
xt Bug 26384: Add .t extension to make the script executed by CI 2020-09-28 11:08:03 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
.gitignore
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 26394: Update .mailmap 2020-09-11 09:56:56 +02:00
.perlcriticrc
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
about.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
changelanguage.pl
cpanfile Bug 16357: Plack error logs are not time stamped 2020-09-28 16:09:10 +02:00
fix-perl-path.PL
gulpfile.js Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
help.pl
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 18958: DBRev 20.06.00.039 2020-09-18 11:49:29 +02:00
koha_perl_deps.pl
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
Makefile.PL Bug 26265: Add missing xt dir 2020-08-24 12:30:53 +02:00
MANIFEST.SKIP
package.json Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
README
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
rewrite-config.PL
yarn.lock Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo