Koha/opac
David Cook f57a057ef4 Bug 10974: make OAI-PMH resumption tokens handle time correctly
This patch changes the value separator in OAI-PMH resumption tokens
from colons to slashes, so that the token string isn't split incorrectly
when a time is included.

TEST PLAN:

1) Turn on the OAI-PMH server syspref in Koha
2) Send a ListRecords request using 'from' and 'until' arguments that
include times (Best to use very far apart times so that you retrieve
more than 50 records which will likely be the trigger for a resumptionToken).
Here is an example:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z

N.B. Replace KOHAINSTANCE with the URL of your Koha instance.

3) Scroll down to the bottom of the page until you find the resumptionToken.
It will look similar to this:

<resumptionToken cursor="50">
oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
</resumptionToken>

4) Copy that resumption token and send a request with it like so:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:

5) The page should (incorrectly) show no records.

6) APPLY PATCH

7) Repeat steps 2, 3, and 4

8) Note that the resumptionToken now uses slashes (e.g. /) instead of
colons.

Note also that now the second request will show records!!!

N.B. This will only happen if Koha has enough records to serve to you.
If your Koha has less than 50 records, try lowering the number provided
in the "OAI-PMH:MaxCount" system preference.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>

I understand; I can now confirm the behaviour described in the test plan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, all tests and QA script.
Resumption Token works correctly after applying the patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-31 18:01:52 +00:00
..
errors
rss
sco Bug 10016: force zero browser-side caching of SCO pages 2013-10-21 18:05:12 +00:00
svc Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
ilsdi.pl
maintenance.pl
oai.pl Bug 10974: make OAI-PMH resumption tokens handle time correctly 2013-10-31 18:01:52 +00:00
opac-account.pl
opac-addbybiblionumber.pl
opac-alert-subscribe.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl
opac-basket.pl
opac-browser.pl
opac-changelanguage.pl
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings 2013-10-31 16:53:56 +00:00
opac-downloadcart.pl Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
opac-downloadshelf.pl Bug 10853: All existing routing to get a CSV should return a MARC csv 2013-10-11 02:16:33 +00:00
opac-export.pl
opac-ics.pl
opac-image.pl
opac-imageviewer.pl
opac-ISBDdetail.pl
opac-main.pl
opac-MARCdetail.pl
opac-memberentry.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
opac-messaging.pl
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl
opac-overdrive-search.pl
opac-passwd.pl Bug 9611: (follow-up) move new password hashing routines to separate module 2013-10-09 03:29:22 +00:00
opac-patron-image.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
opac-privacy.pl
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl
opac-registration-verify.pl
opac-renew.pl
opac-reserve.pl Bug 2720 - Overdues which debar automatically should undebar automatically when returned 2013-10-31 01:53:22 +00:00
opac-review.pl
opac-search-history.pl Bug 10309 - New OPAC theme based on Bootstrap 2013-10-14 23:13:05 +00:00
opac-search.pl
opac-sendbasket.pl
opac-sendshelf.pl Bug 8368: (follow-up) restore use of quoted printable for message body 2013-10-18 07:27:30 +00:00
opac-serial-issues.pl
opac-shelves.pl
opac-showmarc.pl
opac-showreviews.pl
opac-suggestions.pl
opac-tags.pl
opac-tags_subject.pl
opac-topissues.pl
opac-user.pl Bug 2720 - Overdues which debar automatically should undebar automatically when returned 2013-10-31 01:53:22 +00:00
search.pl
tracklinks.pl
unapi