Main Koha release repository https://koha-community.org
Find a file
Fridolin Somers 8dca36661d Bug 11176: Add active switch on budgets select in suggestions
When creating a new purchase suggestion, all funds display and are available for selection.
The behaviour of this drop-down menu should mirror that of those drop-down menus elsewhere in acquisitions,
where only funds that are linked to active budgets display to the user.

This patch add the active switch based on what exists in acqui/invoice.tt and acqui/invoice.pl.

Looks like actually in suggestion.pl budgets list was fetches with GetBudgets().
But this is for the filter in 'Acquisition information'.
Budgets selection on suggestion creation/edition must use GetBudgetHierarchy(), like in acqui/invoice.pl,
in order to have the actif status.

Test plan :
1) Create a budget periods active B1 with a fund F1
2) Create a budget periods inactive B2 with a fund F2
3) Go to suggestions module
4) Create a new suggestion
5) Check you see only active fund F1
6) Click on 'Show inactive'
7) Check you see also 'F2 (inactive)'
8) Choose fund F1 and save
9) Select the suggestion and edit
10) Check fund F1 is selected
11) Come back to suggestion table
12) Check filter 'Book fund' under 'Acquisition information' contains all funds

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-28 16:09:11 +02:00
acqui Bug 17458: Remove use of datereceived from order receive page 2020-09-28 16:09:10 +02:00
admin Bug 26490: Fix column configuration for fines trasactions 2020-09-28 15:06:52 +02:00
api Bug 26271: Add null to the list of accepted account_line data types 2020-09-03 14:18:23 +02:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
C4 Bug 26414: Unable to export Withdrawn status using CSV profile 2020-09-28 15:07:39 +02:00
catalogue Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber 2020-09-03 14:18:23 +02:00
cataloguing Bug 15933: Add +x to the script 2020-09-28 11:08:03 +02:00
circ Bug 23485: Show barcode in holds to pull 2020-09-28 16:09:10 +02:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
debian Bug 16357: Only use Log4perl middleware if appenders defined 2020-09-28 16:09:10 +02:00
docs Bug 26179: Add Timothy Alexis Vass to contributors 2020-08-13 08:09:10 +02:00
errors
etc Bug 16357: Use separate Log4Perl logger for each Plack app 2020-09-28 16:09:10 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26341: Database update for bug 21443 is not idempotent and will destroy settings 2020-09-23 22:08:25 +02:00
Koha Bug 25265: (QA follow-up) Check server type in Elasticsearch::index_records 2020-09-28 11:07:24 +02:00
koha-tmpl Bug 11176: Add active switch on budgets select in suggestions 2020-09-28 16:09:11 +02:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
members Bug 26269: Fix variable name mismatch for cash_register in paycollect 2020-09-18 10:38:04 +02:00
misc Bug 25624: Add --where option to update_patrons_category.pl 2020-09-28 16:09:10 +02:00
offline_circ Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
opac Bug 26464: Code correction in opac-main when news_id passed 2020-09-18 11:49:29 +02:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
plugins Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
pos Bug 26418: Fix translatability of REFUND credit type 2020-09-28 15:07:27 +02:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-03 14:18:23 +02:00
reserve Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
serials Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
services
skel
suggestion Bug 11176: Add active switch on budgets select in suggestions 2020-09-28 16:09:11 +02:00
svc Bug 26424: Better performance of svc/checkouts 2020-09-28 15:07:00 +02:00
t Bug 26414: Tidy the tests 2020-09-28 16:09:10 +02:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
tools Bug 24780: Make items.stocknumber show up in batch item modification 2020-09-28 16:09:10 +02:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
xt Bug 26384: Add .t extension to make the script executed by CI 2020-09-28 11:08:03 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap Bug 26394: Update .mailmap 2020-09-11 09:56:56 +02:00
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml
about.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 16357: Plack error logs are not time stamped 2020-09-28 16:09:10 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
INSTALL
Koha.pm Bug 18958: DBRev 20.06.00.039 2020-09-18 11:49:29 +02:00
koha_perl_deps.pl
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LICENSE
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
Makefile.PL Bug 26265: Add missing xt dir 2020-08-24 12:30:53 +02:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
package.json Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
README
README.md
README.robots
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
yarn.lock Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo