Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart 8dce1cde3a Bug 16873: Improve renewal error messages on self check
When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.

To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.

Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-11-29 17:44:09 +00:00
acqui Bug 17642: use get_description_by_koha_field when needed 2016-11-18 15:52:00 +00:00
admin Bug 15581: Add a circ rule to limit the auto renewals given a delay 2016-11-02 10:28:57 +00:00
api/v1 Bug 17086: Reword borrowers to patrons in Swagger tags for holds 2016-11-22 11:31:08 +00:00
authorities
basket Bug 17642: Add and use get_descriptions_by_koha_field 2016-11-18 15:52:00 +00:00
C4 Bug 17278: Fix "show all items" link 2016-11-22 17:44:43 +00:00
catalogue Bug 17642: Add and use get_descriptions_by_koha_field 2016-11-18 15:52:00 +00:00
cataloguing Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks 2016-10-28 12:04:59 +00:00
circ Bug 17642: Add and use get_descriptions_by_koha_field 2016-11-18 15:52:00 +00:00
course_reserves
debian Bug 17513: Create GRANT for user@localhost in koha-create 2016-11-18 14:07:56 +00:00
docs
errors
etc Bug 16952: Czech language definitions for sorting in Zebra 2016-10-28 15:33:00 +00:00
install_misc
installer Bug 17676: Update default COLLATE of marc_subfield_structure 2016-11-29 17:41:34 +00:00
Koha Bug 17132 - Availability search broken when using Elastic 2016-11-22 11:26:18 +00:00
koha-tmpl Bug 16873: Improve renewal error messages on self check 2016-11-29 17:44:09 +00:00
labels
members Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl 2016-11-21 16:28:51 +00:00
misc Merge remote-tracking branch 'translations/16.11.0-translate' into HEAD 2016-11-22 17:47:36 +00:00
offline_circ
opac Bug 16873: Improve renewal error messages on self check 2016-11-29 17:44:09 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
patron_lists
patroncards
plugins
reports Bug 17642: [QA Follow-up] Issues_stats.pl is not plack safe 2016-11-18 15:52:01 +00:00
reserve
reviews
rotating_collections
serials Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
services
skel
sms
suggestion Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode 2016-10-21 15:35:21 +00:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-10-27 13:18:32 +00:00
t Bug 17278: Fix test compilation errors 2016-11-22 17:44:51 +00:00
tags
test
tmp/modified_authorities
tools Bug 17420 - record export fails when itemtype on biblio 2016-11-12 02:32:41 +00:00
virtualshelves Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects 2016-10-11 13:14:46 +00:00
xt
.editorconfig
.htaccess
.mailmap
about.pl Bug 17274: Display the place where the memcached is picked 2016-11-02 10:55:54 +00:00
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
install-CPAN.pl
Koha.pm DBRev 16.11.00.000 2016-11-22 17:48:00 +00:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
Makefile.PL Bug 16952: Czech language definitions for sorting in Zebra 2016-10-28 15:33:00 +00:00
MANIFEST.SKIP
README
README.md
README.robots
rewrite-config.PL

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-comminity.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo